Skip to content

[exabgp] Fix start/restart verification condition#1400

Merged
tahmed-dev merged 1 commit intosonic-net:masterfrom
tahmed-dev:taahme/fix-exabgp-start-condition-check
Feb 19, 2020
Merged

[exabgp] Fix start/restart verification condition#1400
tahmed-dev merged 1 commit intosonic-net:masterfrom
tahmed-dev:taahme/fix-exabgp-start-condition-check

Conversation

@tahmed-dev
Copy link
Contributor

Fix the issue when checking the return from status API. Previously
the check was done outside the module and the return was in a form of
hash map. With relocation of the condition to the exabgp module,
the return type is string and is not a hash map.

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

py.test --inventory veos.vtb --host-pattern all --user admin -vvvv --show-capture stdout --testbed vms-kvm-t0 --testbed_file vtestbed.csv --disable_loganalyzer --junitxml=tr.xml test_announce_routes.py -vvvv

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Fix the issue when checking the return from status API. Previously
the check was done outside the module and the return was in a form of
hash map. With relocation of the condition to the exabgp module,
the return type is strig and is not a map.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@tahmed-dev tahmed-dev merged commit a119dd5 into sonic-net:master Feb 19, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…sonic-net#6701)

sonic-swss:
- [Mux] Route handling based on mux status, kernel tunnel support (sonic-net#1615)
- Reduce noise during frequent route update (sonic-net#1624)
- Changed Error log to Notice log during FDB flush notification after VLAN delete (sonic-net#1618)
- [PortsOrch] Add reference counting to ports for ACL bindings (sonic-net#1614)
- [crm]: Ignore unsupported/non-implemented switch attributes (sonic-net#1613)
- [Mux] Fix repeating logs in case of tunnel creation fail (sonic-net#1610)

sonic-utilities:
- [config reload]: Restart mux container (sonic-net#1401)
- [storyteller] Enhance the storyteller utility (sonic-net#1400)
- [show] Fix int status when portchannel is in the system (sonic-net#1376)
- [config][show] cli support for retrieving ber, eye-info and configuring prbs, loopback on Y-cable  (sonic-net#1386)
- Skip route check for tun0 interfaces (sonic-net#1399)
- do not parse stderr to get correct routing stack (sonic-net#1398)
- [storyteller] allow storyteller to work on downloaded logs (sonic-net#1388)
- [show] Run fwutil with sudo (sonic-net#1364)

Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants