Skip to content

[PFC] Test if PFC can pause lossless priorities#1386

Merged
lguohan merged 11 commits intosonic-net:masterfrom
baiwei0427:pfc-test
Mar 29, 2020
Merged

[PFC] Test if PFC can pause lossless priorities#1386
lguohan merged 11 commits intosonic-net:masterfrom
baiwei0427:pfc-test

Conversation

@baiwei0427
Copy link
Contributor

@baiwei0427 baiwei0427 commented Feb 14, 2020

Description of PR

Signed-off-by: Wei Bai [email protected]

Summary: Two pytest tests:

  • Test if PFC can pause lossless priorities without affecting the other priorities
  • Test if lossless and lossy priorities can forward packets in the absence of PFC pause frames

Type of change

  • [] Test case(new/improvement)

Approach

How did you do it?

  1. Set up the testbed, including (1) copy the PFC packet generator toe the leaf fanout switches, and (2) copying the PTF script to the PTF container.

  2. Given a tested interface i on the DUT, we generate PFC pause frames at the leaf fanout to block the lossless priority p of this interface.

  3. The PTF script transmits two packets which should leave DUT from the interface i. One packet is mapped to priority p. The other packet is mapped to any other priority.

  4. The PTF script should only receive the packet that is not mapped to priority p.

How did you verify/test it?

I ran this test case in our testbed.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

Currently, the test case only supports T0 topology. I will add more topologies in the future.

Documentation

@neethajohn neethajohn requested review from yxieca and removed request for wendani March 23, 2020 18:06
return eos_intf_name.replace('Ethernet', 'et').replace('/', '_')
return eos_intf_name.replace('Ethernet', 'et').replace('/', '_')

def get_phy_intfs(host_ans):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should be moved to tests/common/platform/interface_utils.py

But do it with another PR.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of helper functions can be moved to tests/common under various folders. Please put up another PR for coding sharing.

@lguohan lguohan merged commit 63df74c into sonic-net:master Mar 29, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…sonic-net#6701)

sonic-swss:
- [Mux] Route handling based on mux status, kernel tunnel support (sonic-net#1615)
- Reduce noise during frequent route update (sonic-net#1624)
- Changed Error log to Notice log during FDB flush notification after VLAN delete (sonic-net#1618)
- [PortsOrch] Add reference counting to ports for ACL bindings (sonic-net#1614)
- [crm]: Ignore unsupported/non-implemented switch attributes (sonic-net#1613)
- [Mux] Fix repeating logs in case of tunnel creation fail (sonic-net#1610)

sonic-utilities:
- [config reload]: Restart mux container (sonic-net#1401)
- [storyteller] Enhance the storyteller utility (sonic-net#1400)
- [show] Fix int status when portchannel is in the system (sonic-net#1376)
- [config][show] cli support for retrieving ber, eye-info and configuring prbs, loopback on Y-cable  (sonic-net#1386)
- Skip route check for tun0 interfaces (sonic-net#1399)
- do not parse stderr to get correct routing stack (sonic-net#1398)
- [storyteller] allow storyteller to work on downloaded logs (sonic-net#1388)
- [show] Run fwutil with sudo (sonic-net#1364)

Signed-off-by: Danny Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants