Fix compatibility issue between python2 and python3 in null_route test#6701
Merged
xwjiang-ms merged 1 commit intosonic-net:masterfrom Nov 2, 2022
Merged
Conversation
What is the motivation for this PR? I fixed style issues in `null_route` test, but imported a compatibility issue. In python3, str type contains unicode characters, but if we use str in python2 instead of unicode, will cause AddressValueError, python2 can only recognize unicode IPv4/v6 address How did you do it? Use string.encode().decode() instead of str() or unicode(), and in python2, we will get unicode IPv4/v6 address, in python3, we will get IPv4/v6 address string How did you verify/test it? Run `acl/null_route/test_null_route_helper.py` test Any platform specific information? Supported testbed topology if it's a new test case?
wangxin
approved these changes
Nov 2, 2022
wangxin
pushed a commit
that referenced
this pull request
Dec 19, 2022
…est (#6701) What is the motivation for this PR? I fixed style issues in `null_route` test, but imported a compatibility issue. In python3, str type contains unicode characters, but if we use str in python2 instead of unicode, will cause AddressValueError, python2 can only recognize unicode IPv4/v6 address How did you do it? Use string.encode().decode() instead of str() or unicode(), and in python2, we will get unicode IPv4/v6 address, in python3, we will get IPv4/v6 address string How did you verify/test it? Run `acl/null_route/test_null_route_helper.py` test Any platform specific information? Supported testbed topology if it's a new test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
I fixed style issues in
null_routetest, but imported a compatibility issue.In python3, str type contains unicode characters, but if we use str in python2 instead of unicode, will cause AddressValueError. Python2 can only recognize unicode IPv4/v6 address
Relate PR: #6679
How did you do it?
Use string.encode().decode() instead of str() or unicode(), and in python2, we will get unicode IPv4/v6 address, in python3, we will get IPv4/v6 address string
How did you verify/test it?
Run
acl/null_route/test_null_route_helper.pytestAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation