Skip to content

[vxlan-decap]: Improvements of the test#1075

Merged
pavel-shirshov merged 4 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/vxlan_2
Aug 20, 2019
Merged

[vxlan-decap]: Improvements of the test#1075
pavel-shirshov merged 4 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/vxlan_2

Conversation

@pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Aug 20, 2019

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

  1. Added: Output offset of the test properties when the test failed. It does make sense when we need to understand was the port the number one for test or not
  2. Added: Add warm-up before the test
  3. Changed: Increase packet timeout time to 0.5 sec, to make sure python received a packet.

How did you verify/test it?

Run ansible test against my DUT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@pavel-shirshov pavel-shirshov requested a review from yxieca August 20, 2019 00:12
@pavel-shirshov pavel-shirshov self-assigned this Aug 20, 2019
@pavel-shirshov pavel-shirshov merged commit 703d97f into sonic-net:master Aug 20, 2019
@pavel-shirshov pavel-shirshov deleted the pavelsh/vxlan_2 branch August 20, 2019 02:03
yxieca pushed a commit that referenced this pull request Aug 20, 2019
@pavel-shirshov @yxieca
[vxlan-decap]: Improvements of the test (#1075)
d6f2ebe 
* Output offset of ports in data structures

* Warmup DUT before the test

* Increase wating time from 0.2 to 0.5

* Quote minigraph_vlans otherwise ansible could remove this variable
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@saiarcot895
[sairedis]: Update submodule (sonic-net#11762)
9ee0219 
This brings in the following changes:

```
21f3d7c Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075)
8ac3aa7 [sairedis] Fix reopen recoding file (sonic-net#1087)
0bbbb02 Transfer organization from Azure to sonic-net (sonic-net#1096)
3406c57 [sairedis] Perform log rotate on request (sonic-net#1083)
```
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][linkmgrd][utilities][swss][sairedis][platform-daemon][platfo…
b1456ee 
…rm-common] advance submodule head (sonic-net#11578)

linkmgrd:
* e0fe1d4 2022-07-27 | TSA enhancement (sonic-net#98) (HEAD -> 202205) [Jing Zhang]

utilities:
* 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (sonic-net#2268) (HEAD -> 202205) [Volodymyr Samotiy]
* b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (sonic-net#2258) [Marty Y. Lok]
* 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (sonic-net#2240) [tjchadaga]
* 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (sonic-net#2213) [Nathan Cohen]
* 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (sonic-net#2205) [bingwang-ms]
* d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (sonic-net#2163) [qinchuanares]
* 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (sonic-net#2111) [Kebo Liu]

swss:
* 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2397) (HEAD -> 202205) [Devesh Pathak]
* 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (sonic-net#2388) [Sudharsan Dhamal Gopalarathnam]
* 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (sonic-net#2376) [Ze Gan]
* c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (sonic-net#2367) [andywongarista]
* 57890d7 2022-07-27 | Fix for remote system interface not getting created (sonic-net#2364) [skeesara-nokia]
* 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) [jaganbal-a]

sairedis:
* a4903be 2022-07-20 | Update PN with XPN support (sonic-net#1081) (HEAD -> 202205, github/202205) [Ze Gan]
* 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075) [Vaibhav Hemant Dixit]

platform-daemon:
* 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (sonic-net#254) (HEAD -> 202205) [Prince George]

platform-common:
* f223b3f 2022-07-09 | Support get_port_or_cage_type (sonic-net#288) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Pterosaur pushed a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 25, 2026
@mssonicbld
[action] [PR:23033] [test_container_autorestart][otel] Added otel to …
0062dea 
…the skip condition list (sonic-net#1075)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
otel container is expected to always restart.
The test_containers_autorestart test consistently fails for the otel container. When the test kills the critical otel process, the container does not stop as expected because the otel program in the container's supervisord config has autorestart=true. This causes supervisord to immediately respawn the process before supervisor-proc-exit-listener can detect the exit and trigger a container-level stop — resulting in the assertion "Failed to stop container 'otel'".

Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202511

### Approach
#### What is the motivation for this PR?
The test_containers_autorestart test consistently fails for the otel container. When the test kills the critical otel process, the container does not stop as expected because the otel program in the container's supervisord config has autorestart=true. This causes supervisord to immediately respawn the process before supervisor-proc-exit-listener can detect the exit and trigger a container-level stop — resulting in the assertion "Failed to stop container 'otel'".
#### How did you do it?
Added otel to the skip_condition list in run_test_on_single_container()
#### How did you verify/test it?
In internal test setup.
#### Any platform specific information?
sn5640
#### Supported testbed topology if it's a new test case?
t0-isolated-d32u32s2
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

@pavel-shirshov pavel-shirshov

Labels

Enhancement Included in 201811 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavel-shirshov @yxieca