PFC Watchdog Test Plan by SubhajitPalKeysight · Pull Request #2205 · sonic-net/sonic-mgmt

SubhajitPalKeysight · 2020-09-11T09:16:43Z

Description of PR

Added test plan of PFC Watchdog. High Level description of technology and test strategy. Also included the documentation of the test cases ( Initial list ) and on subsequent version more tests to be appended. This test plan contains detailed :
Documentation of Test Case
Test Case - Objective
Test Case - Configuration
Test Steps

docs/PFCWD-test-plan.md

baiwei0427 · 2020-09-29T06:01:43Z

docs/PFCWD-test-plan.md

+## 1.2 Setup configuration
+
+### 1.2.1 DUT Configuration
+•PFC watchdog must be enabled in the DUT.


PFC watchdog and PFC must be abled at the DUT by default.

Thanks for suggestion and added into "PFC watchdog and PFC must be enabled at the DUT by default "

docs/PFCWD-test-plan.md

baiwei0427 · 2020-09-30T04:58:46Z

docs/PFCWD-test-plan.md

+### PFC Storm Restoration
+
+The watchdog should continue count the PFC frames received on the queue. If there is no PFC frame received over T1 period. Then, re-enable the PFC on the queue and stop dropping packets if the previous mitigation was drop. T1 is port level parameter. T1 should be on the scale of hundred milliseconds.
+


Add a subsection of PFC watchdog implementation to introduce polling interval

Added Polling Interval Documentation

baiwei0427 · 2020-09-30T05:01:39Z

docs/PFCWD-test-plan.md

+- On SONiC DUT configure the following:
+  1. Enable watchdog with default storm detection time (400ms) and restoration time (2sec).
+  2. Configure a single lossless priority value Pi (0 <= i <= 7).
+  3. To minimize configuration complexity, it is recommended that the SONiC DUT be configured as either Top of Rack (ToR) or Tier 0 (T0) switch with three VLAN interfaces.


Top of Rack (ToR) / Tier 0 (T0)

Thanks , added the notation "Top of Rack (ToR) / Tier 0 (T0)"

docs/PFCWD-test-plan.md

baiwei0427 · 2020-10-07T03:33:58Z

docs/PFCWD-test-plan.md

+#### 1.3.1.3 Test Configuration
+
+- On SONiC DUT configure the following:
+  1. Enable watchdog with default storm detection time (400ms) and restoration time (2sec). Please note that different switches have different detection times and restoration times, e.g., 200ms and 400ms.  


Do not specify any concrete values here! Different platforms use different detection time, restoration time and polling interval

Thanks for your comment. I've removed the specific values.

baiwei0427 · 2020-10-07T03:39:28Z

docs/PFCWD-test-plan.md

+  2. Traffic 2<->3 : Bi-directional traffic between Keysight port 2 and port 3, with DSCP value mapped to lossless priority Pi configured in the DUT. Traffic Tx rate should be configured as 50% of line rate.
+  3. PFC pause storm: Persistent PFC pause frames from Keysight
+        port 3 to et3 of DUT. Priority of the PFC pause
+        frames should be same as that configured in DUT and the


same as the lossless priority configured at DUT

Added "same as the lossless priority configured at DUT" in test plan documentation.

baiwei0427 · 2020-10-07T03:41:22Z

docs/PFCWD-test-plan.md

+
+1. At time **_T<sub>startTraffic</sub>_** , start all the bi-directional lossless traffic items.
+2. At time **_T<sub>startPause</sub>_** , start PFC pause storm.
+3. At time **_T<sub>stopPause</sub>_** , stop PFC pause storm. (**_T<sub>stopPause</sub> - T<sub>startPause</sub>_**) should be larger than PFC storm detection time to trigger PFC watchdog.


larger than PFC storm detection time + PFC watchdog polling interval

Thanks , changed the documentation to incorporate "larger than PFC storm detection time + PFC watchdog polling interval"

baiwei0427 · 2020-10-07T03:42:27Z

docs/PFCWD-test-plan.md

+   * PFC watchdog is triggered on the corresponding lossless priorities at DUT interface et3. 
+   * 'Traffic 1<->2' must not experience any packet loss in both directions. Its throughput should be close to 50% of the line rate.
+   * For 'Traffic 2<->3', between **_T<sub>startPause</sub>_** and **_T<sub>stopPause</sub>_** , there should be some packet loss in both directions. 
+   * After **_T<sub>stopPause</sub>_** , the traffic throughput should gradually increase and become 50% of line rate in both directions. 


This is totally wrong. You mix two test cases

Modification as per suggestion in meeting. We will add new test which you will be sending out in new revision of test plan.

yxieca · 2022-03-08T23:31:07Z

@baiwei0427 any further comments?

…rm-common] advance submodule head (sonic-net#11578) linkmgrd: * e0fe1d4 2022-07-27 | TSA enhancement (sonic-net#98) (HEAD -> 202205) [Jing Zhang] utilities: * 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (sonic-net#2268) (HEAD -> 202205) [Volodymyr Samotiy] * b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (sonic-net#2258) [Marty Y. Lok] * 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (sonic-net#2240) [tjchadaga] * 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (sonic-net#2213) [Nathan Cohen] * 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (sonic-net#2205) [bingwang-ms] * d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (sonic-net#2163) [qinchuanares] * 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (sonic-net#2111) [Kebo Liu] swss: * 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2397) (HEAD -> 202205) [Devesh Pathak] * 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (sonic-net#2388) [Sudharsan Dhamal Gopalarathnam] * 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (sonic-net#2376) [Ze Gan] * c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (sonic-net#2367) [andywongarista] * 57890d7 2022-07-27 | Fix for remote system interface not getting created (sonic-net#2364) [skeesara-nokia] * 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) [jaganbal-a] sairedis: * a4903be 2022-07-20 | Update PN with XPN support (sonic-net#1081) (HEAD -> 202205, github/202205) [Ze Gan] * 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075) [Vaibhav Hemant Dixit] platform-daemon: * 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (sonic-net#254) (HEAD -> 202205) [Prince George] platform-common: * f223b3f 2022-07-09 | Support get_port_or_cage_type (sonic-net#288) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <[email protected]>

SubhajitPalKeysight added 7 commits August 12, 2020 00:06

Ixia api server docker depolyment

689f5a3

Merge remote-tracking branch 'upstream/master'

a83c3b9

Merge remote-tracking branch 'upstream/master'

78024e2

Merge branch 'master' of https://github.com/Azure/sonic-mgmt

f7a35af

PFCWD Test Plan

7d6230f

PFCWD Test Plan Section No

0e7b96c

PFCWD Test edit

f764f9b

SuvenduMozumdar added a commit to SuvenduMozumdar/sonic-mgmt that referenced this pull request Sep 23, 2020

A separate PR (sonic-net#2205) is there for PFCWD, hence removing.

0bb5189

baiwei0427 requested changes Sep 30, 2020

View reviewed changes

PFC WD Test Plan Review

0820a70

baiwei0427 requested changes Oct 7, 2020

View reviewed changes

PFC WD Review comment address

2a98f47

This was referenced Oct 9, 2020

PFCWD test scripts #2318

Open

test_basic_pfcwd_two_senders_two_receivers #2320

Closed

test_basic_pfcwd_all_to_all #2321

Closed

SubhajitPalKeysight added 2 commits October 14, 2020 00:52

Add basic PFCWD Timer

4fd0470

Added PFC WD Test Work Flow Diagram

5865647

SubhajitPalKeysight mentioned this pull request Oct 27, 2020

Readme of PFCWD reboot and restart tests #2359

Open

1 task

yxieca force-pushed the master branch from 885053e to 8f9cb56 Compare October 31, 2020 02:57

SubhajitPalKeysight requested review from wangxin and yxieca as code owners March 2, 2022 17:37

		### PFC Storm Restoration

		The watchdog should continue count the PFC frames received on the queue. If there is no PFC frame received over T1 period. Then, re-enable the PFC on the queue and stop dropping packets if the previous mitigation was drop. T1 is port level parameter. T1 should be on the scale of hundred milliseconds.

Conversation

SubhajitPalKeysight commented Sep 11, 2020

Description of PR

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SubhajitPalKeysight Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SubhajitPalKeysight Oct 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SubhajitPalKeysight Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SubhajitPalKeysight Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SubhajitPalKeysight Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yxieca commented Mar 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SubhajitPalKeysight Oct 7, 2020 •

edited

Loading

SubhajitPalKeysight Oct 5, 2020 •

edited

Loading

SubhajitPalKeysight Oct 7, 2020 •

edited

Loading

SubhajitPalKeysight Oct 7, 2020 •

edited

Loading

SubhajitPalKeysight Oct 7, 2020 •

edited

Loading