[202205 | Nvidia] Fix qos sai test for supporting LAG port (#9587)#10121
Merged
yxieca merged 1 commit intosonic-net:202205from Sep 27, 2023
Merged
[202205 | Nvidia] Fix qos sai test for supporting LAG port (#9587)#10121yxieca merged 1 commit intosonic-net:202205from
yxieca merged 1 commit intosonic-net:202205from
Conversation
Description of PR Previously, on Nvidia devices, to make port congestion, we disable the port. So, if a LAG port is used as the tx port in the test, the LAG port will go down in 90s because the lacp pdus are also blocked, which will fail the tests. Therefore, we skip the test on the LAG port for QoS tests. Currently, to make the LAG port also support QoS test, we block the data plane queue instead of disabling the port. This change will work for all topo on Nvidia devices. Change-Id: I6580398b6038e6a850915c57dc6112cdb628ed99
Contributor
Author
|
@bingwang-ms , Could you help review it? |
6 tasks
nhe-NV
approved these changes
Sep 26, 2023
roy-sror
approved these changes
Sep 27, 2023
Collaborator
|
Thanks for the fix. LGTM. |
bingwang-ms
approved these changes
Sep 27, 2023
Collaborator
|
@yxieca Can you please help merge this PR to 202205? It's to fill a test gap on SN4600 T1. Thanks |
7 tasks
Collaborator
Contributor
Author
Hi @bingwang-ms, Thank you for your reminder kindly. |
This was referenced Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cherry-pick PR #9587 from master to 202205
Previously, on Nvidia devices, to make port congestion, we disable the port. So, if a LAG port is used as the tx port in the test, the LAG port will go down in 90s because the lacp pdus are also blocked, which will fail the tests. Therefore, we skip the test on the LAG port for QoS tests. Currently, to make the LAG port also support QoS test, we block the data plane queue instead of disabling the port. This change will work for all topo on Nvidia devices.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Make Qos sai test support LAG port
How did you do it?
we block the data plane queue instead of disabling the port. So the control plane still work normally.
How did you verify/test it?
Run qos sai test on t1-lag-64 topo
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Any
Documentation