Skip to content

miss necessary argument for calling __assignTestPortIps#10205

Merged
yxieca merged 1 commit intosonic-net:202205from
XuChen-MSFT:xuchen3/202205/assignTestPortIps
Oct 5, 2023
Merged

miss necessary argument for calling __assignTestPortIps#10205
yxieca merged 1 commit intosonic-net:202205from
XuChen-MSFT:xuchen3/202205/assignTestPortIps

Conversation

@XuChen-MSFT
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

encounter syntax issue for t1 device qos sai test

            testPortIps[src_dut_index] = {}
>           testPortIps[src_dut_index][src_asic_index] = self.__assignTestPortIps(src_mgFacts)
E           TypeError: __assignTestPortIps() takes exactly 3 arguments (2 given)

RCA:
introduced by PR #10131

How did you do it?

assign necessary argument "topo"

How did you verify/test it?

pass local test

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@XuChen-MSFT
Copy link
Contributor Author

@wangxin @StormLiangMS
can you help to merge?

@yxieca yxieca merged commit 309629b into sonic-net:202205 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants