Temporarily skip macsec tests on sonic t0 testbed.#10088
Merged
judyjoseph merged 1 commit intosonic-net:masterfrom Sep 21, 2023
Merged
Temporarily skip macsec tests on sonic t0 testbed.#10088judyjoseph merged 1 commit intosonic-net:masterfrom
judyjoseph merged 1 commit intosonic-net:masterfrom
Conversation
6 tasks
yejianquan
pushed a commit
that referenced
this pull request
Sep 27, 2023
judyjoseph
added a commit
to judyjoseph/sonic-mgmt
that referenced
this pull request
Oct 6, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Oct 19, 2023
* [pr_test]: Disable MACsec tests (#10101) Approach What is the motivation for this PR? Due to the TYPE 7 changing for MACsec, MACsec tests break the submodule,sonic-swss/sonic-sairedis, updating. How did you do it? Disable MACsec tests in the pr_test script. How did you verify/test it? Check Azp co-authorized by: jianquanye@microsoft.com * Temporarily skip macsec tests on sonic t0 testbed. (#10088) --------- Co-authored-by: Ze Gan <ganze718@gmail.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Summary: Revert the PRs, to get the macsec tests run sonic-net#10101 sonic-net#10088 co-authorized by: jianquanye@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
What is the motivation for this PR?
Similar to PR's done in 202205
#9874
#9903
These changes will be reverted later (new PR similar to below one, to be raised in master) once sonic-swss submodule is updated in master branch
#9909
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation