Add macsec skip in 202305#10246
Merged
StormLiangMS merged 2 commits intosonic-net:202305from Oct 19, 2023
Merged
Conversation
Approach What is the motivation for this PR? Due to the TYPE 7 changing for MACsec, MACsec tests break the submodule,sonic-swss/sonic-sairedis, updating. How did you do it? Disable MACsec tests in the pr_test script. How did you verify/test it? Check Azp co-authorized by: jianquanye@microsoft.com
Contributor
Author
|
@StormLiangMS could you approve and merge this PR, ADO updated in PR comments. |
judyjoseph
added a commit
to judyjoseph/sonic-mgmt
that referenced
this pull request
Nov 21, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
Following what as done in master and 202205 for macsec type7 changes
Add the remove first and later revert REF: #10132
MSFT ADO : 25261395
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation