Skip to content

Skip bgp/test_bgp_fact.py for sonic-t0 testbed#9903

Merged
yejianquan merged 1 commit intosonic-net:202205from
judyjoseph:202205_bgp_t0-sonic
Sep 8, 2023
Merged

Skip bgp/test_bgp_fact.py for sonic-t0 testbed#9903
yejianquan merged 1 commit intosonic-net:202205from
judyjoseph:202205_bgp_t0-sonic

Conversation

@judyjoseph
Copy link
Copy Markdown
Contributor

What is the motivation for this PR?

This is a follow up of the fix earlier made to skip macsec tests from pipeline t0-sonic via this PR : #9874

Even with this PR merged, there was still failures in one of the tests run in t0-sonic pipeline.

Further debugging showed that, we have this special param, to enable macsec (as shown below) which results in macsec setup with macsec enabled links which will fail again.

REF:

specific_param:

  t0-sonic:
  - name: bgp/test_bgp_fact.py
    param: "--neighbor_type=sonic --enable_macsec --macsec_profile=128_SCI,256_XPN_SCI" <<<<<<<
#  all the test modules under macsec directory
  - name: macsec
    param: "--neighbor_type=sonic --enable_macsec --macsec_profile=128_SCI,256_XPN_SCI"   <<<<<<<<
~                                                                                                                                                                                                                                                               
".azure-pipelines/pr_test_scripts.yaml" line 73 of 143 --51%-- col 1

How did you do it?

So idea here is to skip the test test_bgp_fact.py for t0-sonic pipeline alone.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@yejianquan yejianquan marked this pull request as draft September 8, 2023 05:20
@yejianquan yejianquan marked this pull request as ready for review September 8, 2023 05:50
Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 3430265 into sonic-net:202205 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants