Bump Thrift version from 0.13.0 to 0.14.1#9881
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Feb 16, 2022
Merged
Conversation
5 tasks
msosyak
force-pushed
the
thrift_0_14_1
branch
from
f0f7269 to
914dcf7
Compare
5 tasks
Contributor
Author
|
@richardyu-ms Please review. |
richardyu-ms
reviewed
Feb 8, 2022
richardyu-ms
previously approved these changes
Feb 9, 2022
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Feb 9, 2022
Per change to upgrade the thrift to 014 at sonic-net#9881 Upgrade the reference in related code, change the dependent thrift version from 013 to 014
5 tasks
5 tasks
msosyak
force-pushed
the
thrift_0_14_1
branch
from
914dcf7 to
fe7f97a
Compare
qiluo-msft
reviewed
Feb 14, 2022
rules/thrift_0_13_0.mk
Outdated
Collaborator
Contributor
There was a problem hiding this comment.
thanks for looking after it 👍
msosyak
force-pushed
the
thrift_0_14_1
branch
from
fe7f97a to
f5415f7
Compare
msosyak
force-pushed
the
thrift_0_14_1
branch
from
f5415f7 to
037629c
Compare
qiluo-msft
approved these changes
Feb 16, 2022
5 tasks
6 tasks
RyoYang
pushed a commit
to RyoYang/sonic-buildimage
that referenced
this pull request
Mar 10, 2022
To bump the Thrift version to 0.14.1 - To avoid [CVE-2020-13949](https://nvd.nist.gov/vuln/detail/CVE-2020-13949) - to fix some dependencies issues - rename `src/thrfit_0_13_0` to `src/thrift_2` to remove version number in the path. (`src/thrift` contains rules to build thrift 0.11.0 ) - Add thrift sources as submodule as there are no prepared debian packages for version >0.13.0 on [debian.org](https://packages.debian.org/search?searchon=sourcenames&keywords=thrift) - Added patches with fixes for original thrift debian rules:(remove unneeded packages, fix multi job build) ``` BLDENV=buster make -f Makefile.work target/debs/buster/libthrift-dev_0.14.1_amd64.deb ```
RyoYang
pushed a commit
to RyoYang/sonic-buildimage
that referenced
this pull request
Apr 11, 2022
#### Why I did it To bump the Thrift version to 0.14.1 - To avoid [CVE-2020-13949](https://nvd.nist.gov/vuln/detail/CVE-2020-13949) - to fix some dependencies issues #### How I did it - rename `src/thrfit_0_13_0` to `src/thrift_2` to remove version number in the path. (`src/thrift` contains rules to build thrift 0.11.0 ) - Add thrift sources as submodule as there are no prepared debian packages for version >0.13.0 on [debian.org](https://packages.debian.org/search?searchon=sourcenames&keywords=thrift) - Added patches with fixes for original thrift debian rules:(remove unneeded packages, fix multi job build) #### How to verify it ``` BLDENV=buster make -f Makefile.work target/debs/buster/libthrift-dev_0.14.1_amd64.deb ```
6 tasks
RyoYang
added a commit
that referenced
this pull request
Apr 12, 2022
) * Bump Thrift version from 0.13.0 to 0.14.1 (#9881) #### Why I did it To bump the Thrift version to 0.14.1 - To avoid [CVE-2020-13949](https://nvd.nist.gov/vuln/detail/CVE-2020-13949) - to fix some dependencies issues #### How I did it - rename `src/thrfit_0_13_0` to `src/thrift_2` to remove version number in the path. (`src/thrift` contains rules to build thrift 0.11.0 ) - Add thrift sources as submodule as there are no prepared debian packages for version >0.13.0 on [debian.org](https://packages.debian.org/search?searchon=sourcenames&keywords=thrift) - Added patches with fixes for original thrift debian rules:(remove unneeded packages, fix multi job build) #### How to verify it ``` BLDENV=buster make -f Makefile.work target/debs/buster/libthrift-dev_0.14.1_amd64.deb ``` * Correct thrift 0141 typo fix (#10199) Correct libsaithrift dependency package name from LIBTHRIFT_DEV_0_14_1 THRIFT_COMPILER_0_14_1 to LIBTHRIFT_0_14_1_DEV THRIFT_0_14_1_COMPILER How I did it How to verify it Test Done: make BLDENV=buster SAITHRIFT_V2=y -f Makefile.work target/debs/buster/saiserverv2_0.9.4_amd64.deb Co-authored-by: Myron Sosyak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To bump the Thrift version to 0.14.1
How I did it
src/thrfit_0_13_0tosrc/thrift_2to remove version number in the path. (src/thriftcontains rules to build thrift 0.11.0 )How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)