[Cherry-pick] Bump Thrift version from 0.13.0 to 0.14.1#10201
Closed
RyoYang wants to merge 3 commits intosonic-net:202111from
Closed
[Cherry-pick] Bump Thrift version from 0.13.0 to 0.14.1#10201RyoYang wants to merge 3 commits intosonic-net:202111from
RyoYang wants to merge 3 commits intosonic-net:202111from
Conversation
To bump the Thrift version to 0.14.1 - To avoid [CVE-2020-13949](https://nvd.nist.gov/vuln/detail/CVE-2020-13949) - to fix some dependencies issues - rename `src/thrfit_0_13_0` to `src/thrift_2` to remove version number in the path. (`src/thrift` contains rules to build thrift 0.11.0 ) - Add thrift sources as submodule as there are no prepared debian packages for version >0.13.0 on [debian.org](https://packages.debian.org/search?searchon=sourcenames&keywords=thrift) - Added patches with fixes for original thrift debian rules:(remove unneeded packages, fix multi job build) ``` BLDENV=buster make -f Makefile.work target/debs/buster/libthrift-dev_0.14.1_amd64.deb ```
RyoYang
force-pushed
the
bump-thrift-version
branch
from
ddcf524 to
ed8a525
Compare
richardyu-ms
approved these changes
Mar 10, 2022
msosyak
reviewed
Mar 15, 2022
Correct libsaithrift dependency package name from LIBTHRIFT_DEV_0_14_1 THRIFT_COMPILER_0_14_1 to LIBTHRIFT_0_14_1_DEV THRIFT_0_14_1_COMPILER How I did it How to verify it Test Done: make BLDENV=buster SAITHRIFT_V2=y -f Makefile.work target/debs/buster/saiserverv2_0.9.4_amd64.deb
RyoYang
force-pushed
the
bump-thrift-version
branch
from
b935286 to
ab6966d
Compare
6 tasks
msosyak
approved these changes
Mar 29, 2022
Contributor
|
@RyoYang Please resolve the conflicts |
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To bump the Thrift version to 0.14.1 [Cherry-pick from #9881]
To avoid CVE-2020-13949
to fix some dependencies issues
rename
src/thrfit_0_13_0tosrc/thrift_2to remove version number in the path. (src/thriftcontains rules to build thrift 0.11.0 )Add thrift sources as submodule as there are no prepared debian packages for version >0.13.0 on debian.org
Added patches with fixes for original thrift debian rules:(remove unneeded packages, fix multi job build)
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)