[PTF-SAIv2]Add ptf docker for sai-ptf (saiv2)#9729
Merged
richardyu-ms merged 2 commits intosonic-net:masterfrom Feb 18, 2022
Merged
[PTF-SAIv2]Add ptf docker for sai-ptf (saiv2)#9729richardyu-ms merged 2 commits intosonic-net:masterfrom
richardyu-ms merged 2 commits intosonic-net:masterfrom
Conversation
richardyu-ms
changed the title
richardyu-ms
force-pushed
the
saiv2_ptf_docker
branch
2 times, most recently
from
248cfeb to
8df065f
Compare
5 tasks
msosyak
previously approved these changes
Feb 8, 2022
Base on current ptf docker create a new docker for sai-ptf(saiv2) upgrade related package use the latest ptf and install it test done: NOJESSIE=1 NOSTRETCH=1 NOBULLSEYE=1 ENABLE_SYNCD_RPC=y make target/docker-ptf-sai.gz BLDENV=buster make -f Makefile.work target/docker-ptf-sai.gz
richardyu-ms
force-pushed
the
saiv2_ptf_docker
branch
from
8df065f to
a4c5952
Compare
xumia
approved these changes
Feb 9, 2022
Contributor
|
Just to make it visible. |
RyoYang
approved these changes
Feb 18, 2022
msosyak
reviewed
Feb 18, 2022
| DOCKER_PTF_SAI = docker-ptf-sai.gz | ||
| DOCKER_PTF_BASE = docker-ptf.gz | ||
| $(DOCKER_PTF_SAI)_PATH = $(DOCKERS_PATH)/docker-ptf-sai | ||
| $(DOCKER_PTF_SAI)_DEPENDS += $(LIBTHRIFT_2) $(PYTHON3_THRIFT_2) |
Contributor
There was a problem hiding this comment.
Should be updated
Suggested change
| $(DOCKER_PTF_SAI)_DEPENDS += $(LIBTHRIFT_2) $(PYTHON3_THRIFT_2) | |
| $(DOCKER_PTF_SAI)_DEPENDS += $(LIBTHRIFT_0_14_1) $(PYTHON3_THRIFT_0_14_1) |
Also, I believe you should add $(PYTHON_SAITHRIFT) and $(PTF)
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 23, 2022
* [PTF-SAIv2]Add ptf dockre for sai-ptf (saiv2) Base on current ptf docker create a new docker for sai-ptf(saiv2) upgrade related package use the latest ptf and install it test done: NOJESSIE=1 NOSTRETCH=1 NOBULLSEYE=1 ENABLE_SYNCD_RPC=y make target/docker-ptf-sai.gz BLDENV=buster make -f Makefile.work target/docker-ptf-sai.gz * upgrade the thrift to 014
RyoYang
pushed a commit
that referenced
this pull request
Mar 16, 2022
* [PTF-SAIv2]Add ptf dockre for sai-ptf (saiv2) Base on current ptf docker create a new docker for sai-ptf(saiv2) upgrade related package use the latest ptf and install it test done: NOJESSIE=1 NOSTRETCH=1 NOBULLSEYE=1 ENABLE_SYNCD_RPC=y make target/docker-ptf-sai.gz BLDENV=buster make -f Makefile.work target/docker-ptf-sai.gz * upgrade the thrift to 014
RyoYang
added a commit
that referenced
this pull request
Mar 17, 2022
Why I did it To enable PTF-SAI testing on 202111 branch, cherry-pick necessary PR from master How I did it Based on the current ptf docker create a new docker for sai-ptf(saiv2) upgrade related package use the latest ptf and install it How to verify it Tested on DUT * [PTF-SAIv2]Add ptf docker for sai-ptf (saiv2) (#9729) * [PTF-SAIv2]Add ptf dockre for sai-ptf (saiv2) Base on current ptf docker create a new docker for sai-ptf(saiv2) upgrade related package use the latest ptf and install it test done: NOJESSIE=1 NOSTRETCH=1 NOBULLSEYE=1 ENABLE_SYNCD_RPC=y make target/docker-ptf-sai.gz BLDENV=buster make -f Makefile.work target/docker-ptf-sai.gz * upgrade the thrift to 014 * install xmlrunner python3 version (#10086) Co-authored-by: Yang Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Based on the current ptf docker create a new docker for sai-ptf(saiv2)
How I did it
upgrade related package
use the latest ptf and install it
How to verify it
test done:
NOJESSIE=1 NOSTRETCH=1 NOBULLSEYE=1 ENABLE_SYNCD_RPC=y make target/docker-ptf-sai.gz
BLDENV=buster make -f Makefile.work target/docker-ptf-sai.gz
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)