Skip to content

[AS5835-54X]Set port tx_dis to disable and fix thermalutil#9797

Closed
jostar-yang wants to merge 5 commits intosonic-net:masterfrom
jostar-yang:as5835-54x_20220119_thermalutil
Closed

[AS5835-54X]Set port tx_dis to disable and fix thermalutil#9797
jostar-yang wants to merge 5 commits intosonic-net:masterfrom
jostar-yang:as5835-54x_20220119_thermalutil

Conversation

@jostar-yang
Copy link
Copy Markdown
Contributor

Signed-off-by: Jostar Yang [email protected]

Why I did it

  1. Add to set port tx_dis to disable because CPLD enable at default
  2. Fix thermalutil and fanutil bug.

How I did it

1.Modify code to set port tx_dis to disable
2. Fix and modify code

How to verify it

  1. Check tx_dis sysfs
  2. Test thermal plan code

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@jostar-yang jostar-yang requested a review from lguohan as a code owner January 19, 2022 10:02
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 19, 2022

This pull request introduces 1 alert when merging 62a5f22 into 4ae504a - view on LGTM.com

new alerts:

  • 1 for Unused import

sujinmkang
sujinmkang previously approved these changes Jan 19, 2022
@sujinmkang
Copy link
Copy Markdown
Collaborator

@jostar-yang Can you please check the new lgtm alerts and address if needed?

@jostar-yang
Copy link
Copy Markdown
Contributor Author

We send new PR to fix this ticket,
#24028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants