[as5835-54x] Fix read thermal sensor issue#6802
Closed
jostar-yang wants to merge 22 commits intosonic-net:masterfrom
Closed
[as5835-54x] Fix read thermal sensor issue#6802jostar-yang wants to merge 22 commits intosonic-net:masterfrom
jostar-yang wants to merge 22 commits intosonic-net:masterfrom
Conversation
jostar-yang
force-pushed
the
as5835-54x_20210217_thermalutil
branch
from
7633291 to
c339c6e
Compare
|
This pull request introduces 1 alert when merging c339c6e3567cdc56e87922ecfbd162203ce00537 into 6998aef - view on LGTM.com new alerts:
|
added 3 commits
April 8, 2021 16:33
jostar-yang
force-pushed
the
as5835-54x_20210217_thermalutil
branch
from
e35e96a to
edcfca8
Compare
Contributor
Author
|
The PR is too old and get file conflict. So create new PR to handle related fixed code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix as5835-54x read thermal sensor issue.
Due to linux create hwmonN node number, N isn't fixed. So modify to use "" to let thermal.py can correct sysfs. For example, use /sys/bus/i2c/devices/18-004b/hwmon/hwmon/temp1_input to instead of /sys/bus/i2c/devices/18-004b/hwmon/hwmon3/temp1_input
How I did it
Fix as5835-54x thermalutil.py.
How to verify it
Reboot DUT, and check as5835-54x-platform-monitor.service.
systemctl status as5835-54x-platform-monitor.service -l
● as5835-54x-platform-monitor.service - Accton AS5835-54X Platform Monitoring se
Loaded: loaded (/lib/systemd/system/as5835-54x-platform-monitor.service; enab
Active: active (running) since Wed 2021-02-17 03:14:18 UTC; 2h 22min ago
Make sure there is no error message.
Error case that will show below message,
Feb 9 03:13:32.531678 54x-02 INFO accton_as5835_54x_monitor.py[2474]: No such device_path=/sys/bus/i2c/devices/19-004c/hwmon/hwmon4/temp1_input
Feb 9 03:13:32.531831 54x-02 INFO accton_as5835_54x_monitor.py[2474]: No such device_path=/sys/bus/i2c/devices/20-0049/hwmon/hwmon5/temp1_input
......
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)