Skip to content

[AS5835-54X]Set port tx_dis to disable and fix thermalutil #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jostar-yang wants to merge 5 commits into from
Closed

[AS5835-54X]Set port tx_dis to disable and fix thermalutil #9797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4466d1b
[AS5835-54X]Set port tx_dis to disable and fix thermalutil
Jan 19, 2022
62a5f22
Fix sfputil bug for need to use int instead of float
Jan 19, 2022
8f78bba
Fix LGTM alert
Jan 20, 2022
aa52428
Remvoe not needed debug code
Jan 20, 2022
ba2383f
Merge branch 'master' into as5835-54x_20220119_thermalutil
jostar-yang Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions platform/broadcom/sonic-platform-modules-accton/as5835-54x/classes/fanutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,8 @@ class FanUtil(object):
key2 = fan node index (interger) starting from 1
value = path to fan device file (string) """
_fan_to_device_path_mapping = {}

#fan1_direction
#fan1_fault
#fan1_present


#(FAN_NUM_2_IDX, FAN_NODE_DUTY_IDX_OF_MAP): 'fan2_duty_cycle_percentage',
_fan_to_device_node_mapping = {
(FAN_NUM_1_IDX, FAN_NODE_FAULT_IDX_OF_MAP): 'fan1_fault',
(FAN_NUM_1_IDX, FAN_NODE_DIR_IDX_OF_MAP): 'fan1_direction',
Expand Down Expand Up @@ -174,14 +170,10 @@ def get_fan_to_device_path(self, fan_num, node_num):
def get_fan_fault(self, fan_num):
return self._get_fan_node_val(fan_num, self.FAN_NODE_FAULT_IDX_OF_MAP)

#def get_fan_speed(self, fan_num):
# return self._get_fan_node_val(fan_num, self.FAN_NODE_SPEED_IDX_OF_MAP)

def get_fan_dir(self, fan_num):
return self._get_fan_node_val(fan_num, self.FAN_NODE_DIR_IDX_OF_MAP)

def get_fan_duty_cycle(self):
#duty_path = self.FAN_DUTY_PATH
try:
val_file = open(self.FAN_DUTY_PATH)
except IOError as e:
Expand All @@ -203,9 +195,6 @@ def set_fan_duty_cycle(self, val):
fan_file.close()
return True

#def get_fanr_fault(self, fan_num):
# return self._get_fan_node_val(fan_num, self.FANR_NODE_FAULT_IDX_OF_MAP)

def get_fanr_speed(self, fan_num):
return self._get_fan_node_val(fan_num, self.FANR_NODE_SPEED_IDX_OF_MAP)

Expand All @@ -218,9 +207,5 @@ def get_fan_status(self, fan_num):
logging.debug('GET. FAN fault. fan_num, %d', fan_num)
return False

#if self.get_fanr_fault(fan_num) is not None and self.get_fanr_fault(fan_num) > 0:
# logging.debug('GET. FANR fault. fan_num, %d', fan_num)
# return False

return True

2 changes: 2 additions & 0 deletions platform/broadcom/sonic-platform-modules-accton/as5835-54x/utils/accton_as5835_54x_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,8 @@ def do_sonic_platform_clean():
else:
print('{} is uninstalled'.format(PLATFORM_API2_WHL_FILE_PY3))

return

def do_install():
print("Checking system....")
if driver_check() == False:
Expand Down