Skip to content

build_debian: Disable IPv6 DAD#56

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:dad
Nov 3, 2016
Merged

build_debian: Disable IPv6 DAD#56
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:dad

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Nov 3, 2016

No description provided.

qiluo-msft
qiluo-msft reviewed Nov 3, 2016
View reviewed changes
build_debian.sh
set /files/etc/sysctl.conf/net.ipv4.conf.default.arp_filter 0
set /files/etc/sysctl.conf/net.ipv4.conf.default.arp_notify 0
set /files/etc/sysctl.conf/net.ipv4.conf.default.arp_ignore 0
set /files/etc/sysctl.conf/net.ipv6.conf.default.accept_dad 0
Copy link
Collaborator

@qiluo-msft qiluo-msft Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in playbook?

Copy link
Collaborator

@lguohan lguohan Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not neccessary since it is only for v6 and it is not deployed.

@lguohan
Copy link
Collaborator

lguohan commented Nov 3, 2016

can you add more description for this change? like what problem are we facing. Then, we know better why this change was introduced in the future.

lguohan
lguohan requested changes Nov 3, 2016
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more description for this commit.

@stcheng
Copy link
Contributor Author

stcheng commented Nov 3, 2016

This change disables DAD (IPv6's Duplicate Address Detection). DAD protects against IP address conflicts. The way it works is that after an address is added to an interface, the operating system uses the Neighbor Discovery Protocol to check if any other host on the network has the same address. If it finds a neighbor with the same address, the address is removed from the interface.
The problem here is that the time waiting for DAD to be done is fairly long and because that we set the host interface operating status to be down at first, the port cannot exchange the Neighbor Discovery Protocol and DAD will time out. The host interface is only brought up after we have received the port admin status up notification from the kernel, which happens only after the DAD is done or times out. This makes the whole host interfaces bringing up procedure very slow.
This the DAD is disabled. When it is disabled, addresses are immediately usable. Without DAD, we need to make sure that the IPv6 addresses don't have conflicts. For now, we have two IPv6 addresses. one is assigned manually, which prevents conflicts at first. another one is the IPv6 link-local address. It is derived from the MAC address and thus all the link-local addresses are the same on one box. Because link-local addresses are not used, it will not trigger issues even if they are the same.

@stcheng
Copy link
Contributor Author

stcheng commented Nov 3, 2016

Please take a look at the description above and I will add this to the commit messages after review.

@stcheng stcheng merged this pull request into sonic-net:master Nov 3, 2016
stcheng pushed a commit that referenced this pull request Nov 3, 2016
build_debian: Disable IPv6 DAD (#56)
5405b57 
This change disables DAD (IPv6's Duplicate Address Detection). DAD
protects against IP address conflicts. The way it works is that after
an address is added to an interface, the operating system uses the
Neighbor Discovery Protocol to check if any other host on the network
has the same address. If it finds a neighbor with the same address,
the address is removed from the interface.

The problem here is that the time waiting for DAD to be done is fairly
long and because that we set the host interface operating status to be
down at first, the port cannot exchange the Neighbor Discovery Protocol
and DAD will time out. The host interface is only brought up after we
have received the port admin status up notification from the kernel,
which happens only after the DAD is done or times out. This makes the
whole host interfaces bringing up procedure very slow.

This the DAD is disabled. When it is disabled, addresses are immediately
usable. Without DAD, we need to make sure that the IPv6 addresses don't
have conflicts. For now, we have two IPv6 addresses. One is assigned
manually, which prevents conflicts at first. Another one is the IPv6
link-local address. It is derived from the MAC address and thus all the
link-local addresses are the same on one box. Because link-local addresses
are not used, it will not trigger issues even if they are the same.
@stcheng stcheng deleted the dad branch November 3, 2016 19:17
stcheng pushed a commit that referenced this pull request Mar 22, 2017
@qiluo-msft
build_debian: Disable IPv6 DAD (#56)
140f8d7 
This change disables DAD (IPv6's Duplicate Address Detection). DAD
protects against IP address conflicts. The way it works is that after
an address is added to an interface, the operating system uses the
Neighbor Discovery Protocol to check if any other host on the network
has the same address. If it finds a neighbor with the same address,
the address is removed from the interface.

The problem here is that the time waiting for DAD to be done is fairly
long and because that we set the host interface operating status to be
down at first, the port cannot exchange the Neighbor Discovery Protocol
and DAD will time out. The host interface is only brought up after we
have received the port admin status up notification from the kernel,
which happens only after the DAD is done or times out. This makes the
whole host interfaces bringing up procedure very slow.

This the DAD is disabled. When it is disabled, addresses are immediately
usable. Without DAD, we need to make sure that the IPv6 addresses don't
have conflicts. For now, we have two IPv6 addresses. One is assigned
manually, which prevents conflicts at first. Another one is the IPv6
link-local address. It is derived from the MAC address and thus all the
link-local addresses are the same on one box. Because link-local addresses
are not used, it will not trigger issues even if they are the same.
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@sihuihan88
[portstat]: Provide both admin state and operation state (sonic-net#56)
b158a56 
* return empty table when there is no port
* refactor the get_port_status function
samaity pushed a commit to samaity/sonic-buildimage that referenced this pull request Mar 6, 2020
[sonic-head.yang]: Libyang sweep host bits from inet:ip-prefix, fixin… (
6eb21f6 
sonic-net#56)

* [sonic-head.yang]: Libyang sweep host bits from inet:ip-prefix, fixing that problem.

Changed inet:ip-prefix to custom ip-prefix.
Changed test case accordingly.

* [setup.py]: Build yang tree while package build.

Changes done:
1.) Build yang tree while package build.
2.) Add sonic_yang_tree as part of package.
3.) Fix sonic-loopback-interface.yang for ip-prefix problem.
lguohan pushed a commit that referenced this pull request Apr 20, 2020
@byu343 @lguohan
[arista]: Change kernel param for smartsville (#56)
e707590
@dzhangalibaba dzhangalibaba mentioned this pull request Jun 5, 2020
Merged
abdosi added a commit that referenced this pull request Jun 16, 2020
@abdosi
[submodule update] sonic-platfrom-daemons
85eb651 
[syseepromd] Prevent the syseepromd from termination (#56)
 [thermalctld] Fix invalid warning status (#58)
xumia referenced this pull request in xumia/sonic-buildimage-1 Feb 16, 2021
@jleveque @lguohan
[Jenkins] Install Click version >= 7.0 to fix sonic-utilities build (#56
b84f408 
)
@jleveque jleveque mentioned this pull request Apr 29, 2021
Closed
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jan 24, 2022
@kuanyu99
[syseepromd] Prevent the syseepromd from termination (sonic-net#56)
5b14368 
Since the termination of the syseepromd will lead to the termination of the pmon.
Regularly try to update the eeprom data, instead of exiting the syseepromd directly when the update_eeprom_to_db return with failure.
SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Mar 16, 2022
@qiluo-msft
Implement ipCidrRouteStatus for default route and loopback (sonic-net#56
bedc2ec 
)

Signed-off-by: Qi Luo <[email protected]>
@zjswhhh zjswhhh mentioned this pull request Apr 11, 2022
Merged
6 tasks
@zjswhhh zjswhhh mentioned this pull request Apr 28, 2022
Merged
6 tasks
zjswhhh added a commit that referenced this pull request May 2, 2022
@zjswhhh
[sonic-linkmgrd][202012] submodule update (#10703)
3da0327 
[sonic-linkmgrd][202012] submodule update

3523738 Jing Zhang      Sun Apr 3 20:54:40 2022 -0700   Reset link prober state when default route is back #56
8282e78 Jing Zhang      Fri Apr 15 15:59:34 2022 -0700  Keep incrementing sequence number when link prober is suspended and shutdown #55 (#65)
8246eb8 Jing Zhang      Thu Apr 14 18:49:36 2022 -0700  Shutdown ICMP heartbeats when default route state is missing and ToR is in auto mode #44 (#59)

sign-off: Jing Zhang [email protected]
prgeor pushed a commit that referenced this pull request Jun 21, 2022
@keboliu @stephenxs
[Mellanox] Enhance Platform API to support SN2201 - RJ45 ports and ne…
7ac590b 
…w components mgmt. (#10377)

* Support new platform SN2201 and RJ45 port

Signed-off-by: Kebo Liu <[email protected]>

* remove unused import and redundant function

Signed-off-by: Kebo Liu <[email protected]>

* fix error introduced by rebase

Signed-off-by: Kebo Liu <[email protected]>

* Revert the special handling of RJ45 ports (#56)

* Revert the special handling of RJ45 ports

sfp.py
sfp_event.py
chassis.py

Signed-off-by: Stephen Sun <[email protected]>

* Remove deadcode

Signed-off-by: Stephen Sun <[email protected]>

* Support CPLD update for SN2201

A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware
Change _install_firmware from private (starting with __) to protected, making it overloadable

Signed-off-by: Stephen Sun <[email protected]>

* Initialize component BIOS/CPLD

Signed-off-by: Stephen Sun <[email protected]>

* Remove swb_amb which doesn't on DVT board any more

Signed-off-by: Stephen Sun <[email protected]>

* Remove the unexisted sensor - switch board ambient - from platform.json

Signed-off-by: Stephen Sun <[email protected]>

* Do not report error on receiving unknown status on RJ45 ports

Translate it to disconnect for RJ45 ports
Report error for xSFP ports

Signed-off-by: Stephen Sun <[email protected]>

* Add reinit for RJ45 to avoid exception

Signed-off-by: Stephen Sun <[email protected]>

Co-authored-by: Stephen Sun <[email protected]>
Co-authored-by: Stephen Sun <[email protected]>
Pterosaur added a commit to Pterosaur/sonic-buildimage that referenced this pull request Jun 27, 2022
@Pterosaur
Update submodule for wpa-supplicant
a8d4fb9 
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (sonic-net#55)
a1142e251  [sonic_operators.cpp] Update sonic_db_manager::get_counter (sonic-net#56)
1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (sonic-net#54)

Signed-off-by: Ze Gan <[email protected]>
Pterosaur added a commit that referenced this pull request Jun 28, 2022
@Pterosaur
[submodule]: Update submodule for wpa-supplicant (#11264)
94556d3 
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (#55)
a1142e251  [sonic_operators.cpp] Update sonic_db_manager::get_counter (#56)
1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (#54)

Signed-off-by: Ze Gan <[email protected]>
yxieca pushed a commit that referenced this pull request Jun 28, 2022
@Pterosaur @yxieca
[submodule]: Update submodule for wpa-supplicant (#11264)
7d832d1 
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (#55)
a1142e251  [sonic_operators.cpp] Update sonic_db_manager::get_counter (#56)
1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (#54)

Signed-off-by: Ze Gan <[email protected]>
yxieca pushed a commit that referenced this pull request Jul 28, 2022
@keboliu @stephenxs @yxieca
[Mellanox] Enhance Platform API to support SN2201 - RJ45 ports and ne…
2f59460 
…w components mgmt. (#10377)

* Support new platform SN2201 and RJ45 port

Signed-off-by: Kebo Liu <[email protected]>

* remove unused import and redundant function

Signed-off-by: Kebo Liu <[email protected]>

* fix error introduced by rebase

Signed-off-by: Kebo Liu <[email protected]>

* Revert the special handling of RJ45 ports (#56)

* Revert the special handling of RJ45 ports

sfp.py
sfp_event.py
chassis.py

Signed-off-by: Stephen Sun <[email protected]>

* Remove deadcode

Signed-off-by: Stephen Sun <[email protected]>

* Support CPLD update for SN2201

A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware
Change _install_firmware from private (starting with __) to protected, making it overloadable

Signed-off-by: Stephen Sun <[email protected]>

* Initialize component BIOS/CPLD

Signed-off-by: Stephen Sun <[email protected]>

* Remove swb_amb which doesn't on DVT board any more

Signed-off-by: Stephen Sun <[email protected]>

* Remove the unexisted sensor - switch board ambient - from platform.json

Signed-off-by: Stephen Sun <[email protected]>

* Do not report error on receiving unknown status on RJ45 ports

Translate it to disconnect for RJ45 ports
Report error for xSFP ports

Signed-off-by: Stephen Sun <[email protected]>

* Add reinit for RJ45 to avoid exception

Signed-off-by: Stephen Sun <[email protected]>

Co-authored-by: Stephen Sun <[email protected]>
Co-authored-by: Stephen Sun <[email protected]>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
@Pterosaur @skbarista
[submodule]: Update submodule for wpa-supplicant (sonic-net#11264)
b33a19c 
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (sonic-net#55)
a1142e251  [sonic_operators.cpp] Update sonic_db_manager::get_counter (sonic-net#56)
1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (sonic-net#54)

Signed-off-by: Ze Gan <[email protected]>
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
@mssonicbld
Merge pull request sonic-net#56 from mssonicbld/sonicbld/202205-merge
e7826e6 
[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205
MuLinForest pushed a commit to MuLinForest/sonic-buildimage that referenced this pull request Aug 6, 2024
@bryan1978
Merge pull request sonic-net#56 from tigerfu000/202311.0_as9736_64d
02f59e1 
[Platform][AS9736-64D]: Fix syncd init failed during system boot-up phase for BRCM community SAI
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Mar 12, 2025
@mssonicbld
[submodule] Update submodule sonic-platform-common to the latest HEAD…
e661669 
… automatically (sonic-net#826)

#### Why I did it
src/sonic-platform-common
```
* b37907d - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (sonic-net#56) (23 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Mar 23, 2025
@mssonicbld
[submodule] Update submodule sonic-stp to the latest HEAD automatical…
4d0c6a8 
…ly (#22109)

#### Why I did it
src/sonic-stp
```
* 92342f9 - (HEAD -> master, origin/master, origin/HEAD) MSTP Feature - librabry API changes (#56) (33 hours ago) [Divya Kumaran Chandralekha]
* 44b2b0c - MSTP PRS/PIM state machine APIs (#52) (2 days ago) [Divya Kumaran Chandralekha]
* 16e8163 - MSTP PRT/PPM/TCM state machine APIs (#54) (2 days ago) [Divya Kumaran Chandralekha]
* 5bf98bb - Mstp feature - debug APIs (#57) (2 days ago) [Divya Kumaran Chandralekha]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Gfrom2016 pushed a commit to Gfrom2016/sonic-buildimage that referenced this pull request Apr 5, 2025
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
8727af1 
…lly (sonic-net#841)

#### Why I did it
src/sonic-swss
```
* d344d14 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (sonic-net#56) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit to jianyuewu/sonic-buildimage that referenced this pull request May 7, 2025
@mssonicbld
[code sync] Merge code from sonic-net/sonic-platform-common:202411 to…
b37907d 
… 202412 (sonic-net#56)

```<br>* 8aa4a87 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-08) [Sonic Automation]
* f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld]
* c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin]
* b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
skr31 pushed a commit to skr31/sonic-buildimage that referenced this pull request May 25, 2025
@mssonicbld
[submodule][202412] Update submodule sonic-sairedis to the latest HEA…
18736c2 
…D automatically (sonic-net#1105)

#### Why I did it
src/sonic-sairedis
```
* 3c33c26 - (HEAD -> 202412, origin/HEAD, origin/202412) Update codeql runs-on ubuntu version to 22.04 (sonic-net#56) (3 hours ago) [mssonicbld]
* 87d6f46 - [trim]: Add Packet Trimming to VS lib (sonic-net#55) (18 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
croos12 pushed a commit to croos12/sonic-buildimage that referenced this pull request Sep 29, 2025
@mssonicbld
[submodule][202412] Update submodule sonic-swss-common to the latest …
8f22427 
…HEAD automatically (sonic-net#1597)

#### Why I did it
src/sonic-swss-common
```
*   a3adbc6 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request sonic-net#56 from mssonicbld/cherry/msft-202412/964 (35 minutes ago) [Ze Gan]
|\  
| * 924cbf4 - Add swss::Table to c api (61 minutes ago) [Sonic Build Admin]
* 371dd39 - Merge pull request sonic-net#57 from mssonicbld/cherry/msft-202412/1007 (36 minutes ago) [Ze Gan]
* 7d9b914 - Update codeql runs-on ubuntu version to 22.04 (59 minutes ago) [Sonic Build Admin]
```
#### How I did it
#### How to verify it
#### Description for the changelog
croos12 pushed a commit to croos12/sonic-buildimage that referenced this pull request Sep 29, 2025
@mssonicbld
[submodule][202412] Update submodule sonic-gnmi to the latest HEAD au…
75c02c0 
…tomatically (sonic-net#1600)

#### Why I did it
src/sonic-gnmi
```
*   64e8539 - (HEAD -> 202412, origin/202412) Merge pull request sonic-net#97 from Azure/202412-dev (4 hours ago) [Zain Budhwani]
|\  
| * 0de6456 - Adapt to the new usages of arguments (sonic-net#93) (6 hours ago) [Changrong Wu]
| * 0be3a77 - Remove redundant helper function toString from show_common.go (sonic-net#86) (23 hours ago) [gnemuw]
| * ff54cad - Fetch arguments from path and supply getters with parsed arguments (sonic-net#82) (25 hours ago) [Zain Budhwani]
| * 14660a2 - Add `show dropcounters config` (sonic-net#79) (33 hours ago) [Changrong Wu]
| * 1b7b835 - Added telemetry support for the 'show queue watermark' command. (sonic-net#72) (5 days ago) [mramezani95]
| * 417ebe5 - interaces description implementation (sonic-net#69) (6 days ago) [Vijay Sharma]
| * d3140d8 - Implement 'show ipv6 route' command (sonic-net#64) (6 days ago) [gnemuw]
| * a715f58 - Add show services (sonic-net#74) (7 days ago) [Zhaoyang Zhang]
| * fe4ab1c - Fix the show headroom_pool typo (sonic-net#76) (7 days ago) [Guoqiang Yuan]
| * 0277718 - Add show interface naming_mode (sonic-net#73) (7 days ago) [axin]
| * 03519fe - Add show interface neighbor expected (sonic-net#54) (7 days ago) [jiayuj2021]
| * f29223a - Add 'show ipv6 fib' command (sonic-net#67) (7 days ago) [Guoqiang Yuan]
| * 8ae677e - Add SHOW implementation for processes (sonic-net#63) (8 days ago) [yiliu4]
| * 61927f9 - [202412] Add support of 'show ipv6 link-local-mode' command (sonic-net#65) (8 days ago) [cgangx]
| * 4dca30c - Add show interface flap support (sonic-net#66) (8 days ago) [axin]
| * 18c276b - Add show system memory (sonic-net#57) (8 days ago) [Changrong Wu]
| * 00cc010 - Add support for show interface status (sonic-net#32) (8 days ago) [Changrong Wu]
| * 941b3a2 - Minor changes from VLAN Brief PR Comments (sonic-net#68) (8 days ago) [Vijay Sharma]
| * af89dec - show uptime (sonic-net#39) (9 days ago) [Vijay Sharma]
| * 718ffd7 - Add show ipv6 bgp network (sonic-net#61) (9 days ago) [Zhaoyang Zhang]
| * 8346e29 - [202412] Add support for 'show ipv6 bgp neighbors (sonic-net#58) (9 days ago) [zitingguo-ms]
| * aec577c - Add implementation for show lldp neighbors (sonic-net#56) (10 days ago) [nanali-msft]
| * b561228 - Add show dropcounters counts / capabilities (sonic-net#40) (13 days ago) [jiayuj2021]
| * 16d6ccc - Add support for dev branches in CodeQL analysis (13 days ago) [Zain Budhwani]
* 8e41780 - Revert "Sync 202412 dev with 202412 (sonic-net#94)" (sonic-net#96) (4 hours ago) [Zain Budhwani]
* c5b5383 - Sync 202412 dev with 202412 (sonic-net#94) (5 hours ago) [Zain Budhwani]
```
#### How I did it
#### How to verify it
#### Description for the changelog
vmittal-msft pushed a commit to vmittal-msft/sonic-buildimage that referenced this pull request Oct 20, 2025
@mssonicbld
[submodule][202503] Update submodule sonic-sairedis to the latest HEA…
6e2043f 
…D automatically (sonic-net#1323)

#### Why I did it
src/sonic-sairedis
```
* c4d152d4 - (HEAD -> 202503, origin/202503) Merge pull request sonic-net#59 from mssonicbld/sonicbld/202503-merge (23 hours ago) [mssonicbld]
* 8f50be71 - Merge branch '202412' of https://github.com/Azure/sonic-sairedis.msft into 202503 (23 hours ago) [Sonic Automation]
* b36d5641 - (origin/HEAD, origin/202412, 202412) [trim]: Add Packet Trimming Asym DSCP to VS lib (sonic-net#68) (4 days ago) [mssonicbld]
* 6e75cc6c - [TAM]: Add default SAI_TAM_ATTR_TELEMETRY_OBJECTS_LIST of TAM for saivs create operation (sonic-net#1614) (sonic-net#66) (8 days ago) [Ze Gan]
* 0ae8494d - [unittest ]Conditionally enable TestServerSaiMockChannel (sonic-net#67) (8 days ago) [mssonicbld]
* 12b21f3b - [syncd] Check whether stat_st and tam_telemetry is defined (sonic-net#1590) (sonic-net#65) (13 days ago) [Ze Gan]
* 701a114b - [TAM]: Fix TAM notification and vslib implementation (sonic-net#1606) (sonic-net#62) (13 days ago) [Ze Gan]
* 6b97f74e - [SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM (sonic-net#1573) (sonic-net#63) (13 days ago) [Ze Gan]
* f21e12ce - [trim]: Add Packet Trimming Port/Queue stats to VS lib (sonic-net#60) (4 weeks ago) [Nazarii Hnydyn]
* 9d396448 - Merge pull request sonic-net#61 from mssonicbld/cherry/msft-202412/1548 (4 weeks ago) [Ze Gan]
|\ 
| failure_prs.log 613654bb - [syncd] Move log set function after api initialize (4 weeks ago) [Sonic Build Admin]
|/ 
* e18530c8 - Update SAI version to 1.16.1 (sonic-net#54) (8 weeks ago) [mramezani95]
* 3c33c26e - Update codeql runs-on ubuntu version to 22.04 (sonic-net#56) (8 weeks ago) [mssonicbld]
* 87d6f464 - [trim]: Add Packet Trimming to VS lib (sonic-net#55) (9 weeks ago) [mssonicbld]
* 80c43090 - Support auto negotiation on the VS platform to avoid error messages. (sonic-net#52) (10 weeks ago) [mssonicbld]
* 0209ab89 - [FlexCounter] add support for SRv6 MySID counters (sonic-net#50) (2 months ago) [mssonicbld]
* aceb9ed1 - Move time stamp to time stamp table in counter database to avoid frequently update the counter table (sonic-net#51) (2 months ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
tirupatihemanth pushed a commit to tirupatihemanth/sonic-buildimage that referenced this pull request Nov 7, 2025
@rchandramouli
[sonic-net#24386] rsyslog: restore kernel timestamp in the /dev/kmsg …
f840905 
…logs (sonic-net#56)

The `imklog` plugin of rsyslog collects the kernel logs from `/dev/kmsg` and
enqueues it to the syslog. With `CONFIG_PRINTK_TIME` the kernel messages are by
default prefixed with the elapsed time since boot. The `imklog` plugin parsing
these messages have a few options such as to keep the timestamps as such or to
interpret and adjust the syslog's reported time accordingly.

The rsylog release `8.2312.0` has fixes in interpreting these timestamps,
leading to the change in behavior observed in sonic-net#24386.

  https://salsa.debian.org/debian/rsyslog/-/blob/debian/8.2504.0-1/ChangeLog?ref_type=tags#L619

To restore the earlier behavior or retaining the kernel reported elapsed time,
disable `KlogParseKernelTimestamp` as this leads to removal of timestamp from
kernel messages and enable `KlogKeepKernelTimestamp` explicitly. The later is
required as the default is now to discard the kernel timestamp.

With this change, the logs retain the kernel timestamp:

    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | head -n 3
    2025 Nov  4 05:15:14.918946 sonic NOTICE kernel: [    0.000000] Linux version 6.12.41+deb13-sonic-amd64 ([email protected]) (x86_64-linux-gnu-gcc-14 (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) #1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12)
    2025 Nov  4 05:15:14.919533 sonic INFO kernel: [    0.000000] Command line: BOOT_IMAGE=/image-trixie.0-dirty-20251102.122837/boot/vmlinuz-6.12.41+deb13-sonic-amd64 root=UUID=ac0b6826-f8a3-461f-a8ff-701df60d90b6 rw console=tty0 console=ttyS0,115200n8 quiet processor.max_cstate=1 intel_idle.max_cstate=0 net.ifnames=0 biosdevname=0 loop=image-trixie.0-dirty-20251102.122837/fs.squashfs loopfstype=squashfs apparmor=1 security=apparmor varlog_size=4096 usbcore.autosuspend=-1 intel_iommu=off modprobe.blacklist=gpio_ich,i2c-ismt,i2c_ismt,i2c-i801,i2c_i801 crashkernel=0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M acpi_no_watchdog
    2025 Nov  4 05:15:14.919536 sonic INFO kernel: [    0.000000] BIOS-provided physical RAM map:
    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | tail -n 3
    2025 Nov  4 05:17:26.831607 sonic WARNING kernel: [  143.527486] PDDF_LED       set_status_led: Set [FANTRAY_LED;1] color[green]
    2025 Nov  4 05:17:26.912442 sonic WARNING kernel: [  143.607086] PDDF_LED       set_status_led: Set [FANTRAY_LED;2] color[green]
    2025 Nov  4 05:20:32.499634 sonic WARNING kernel: [  329.195319] PDDF_LED       set_status_led: Set [SYS_LED;0] color[amber]
    root@sonic:~#

Signed-off-by: Ramasamy Chandramouli <[email protected]>
Co-authored-by: Ramasamy Chandramouli <[email protected]>
Pavan-Nokia pushed a commit to Pavan-Nokia/sonic-buildimage that referenced this pull request Nov 10, 2025
@saiarcot895
fixup! [sonic-net#24386] rsyslog: restore kernel timestamp in the /de…
2277e27 
…v/kmsg logs (sonic-net#56)
nonodark pushed a commit to nonodark/sonic-buildimage that referenced this pull request Nov 18, 2025
@rchandramouli @saiarcot895
[sonic-net#24386] rsyslog: restore kernel timestamp in the /dev/kmsg …
1e4dca1 
…logs (sonic-net#56)

The `imklog` plugin of rsyslog collects the kernel logs from `/dev/kmsg` and
enqueues it to the syslog. With `CONFIG_PRINTK_TIME` the kernel messages are by
default prefixed with the elapsed time since boot. The `imklog` plugin parsing
these messages have a few options such as to keep the timestamps as such or to
interpret and adjust the syslog's reported time accordingly.

The rsylog release `8.2312.0` has fixes in interpreting these timestamps,
leading to the change in behavior observed in sonic-net#24386.

  https://salsa.debian.org/debian/rsyslog/-/blob/debian/8.2504.0-1/ChangeLog?ref_type=tags#L619

To restore the earlier behavior or retaining the kernel reported elapsed time,
disable `KlogParseKernelTimestamp` as this leads to removal of timestamp from
kernel messages and enable `KlogKeepKernelTimestamp` explicitly. The later is
required as the default is now to discard the kernel timestamp.

With this change, the logs retain the kernel timestamp:

    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | head -n 3
    2025 Nov  4 05:15:14.918946 sonic NOTICE kernel: [    0.000000] Linux version 6.12.41+deb13-sonic-amd64 ([email protected]) (x86_64-linux-gnu-gcc-14 (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) sonic-net#1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12)
    2025 Nov  4 05:15:14.919533 sonic INFO kernel: [    0.000000] Command line: BOOT_IMAGE=/image-trixie.0-dirty-20251102.122837/boot/vmlinuz-6.12.41+deb13-sonic-amd64 root=UUID=ac0b6826-f8a3-461f-a8ff-701df60d90b6 rw console=tty0 console=ttyS0,115200n8 quiet processor.max_cstate=1 intel_idle.max_cstate=0 net.ifnames=0 biosdevname=0 loop=image-trixie.0-dirty-20251102.122837/fs.squashfs loopfstype=squashfs apparmor=1 security=apparmor varlog_size=4096 usbcore.autosuspend=-1 intel_iommu=off modprobe.blacklist=gpio_ich,i2c-ismt,i2c_ismt,i2c-i801,i2c_i801 crashkernel=0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M acpi_no_watchdog
    2025 Nov  4 05:15:14.919536 sonic INFO kernel: [    0.000000] BIOS-provided physical RAM map:
    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | tail -n 3
    2025 Nov  4 05:17:26.831607 sonic WARNING kernel: [  143.527486] PDDF_LED       set_status_led: Set [FANTRAY_LED;1] color[green]
    2025 Nov  4 05:17:26.912442 sonic WARNING kernel: [  143.607086] PDDF_LED       set_status_led: Set [FANTRAY_LED;2] color[green]
    2025 Nov  4 05:20:32.499634 sonic WARNING kernel: [  329.195319] PDDF_LED       set_status_led: Set [SYS_LED;0] color[amber]
    root@sonic:~#

Signed-off-by: Ramasamy Chandramouli <[email protected]>
Co-authored-by: Ramasamy Chandramouli <[email protected]>
tirupatihemanth pushed a commit to tirupatihemanth/sonic-buildimage that referenced this pull request Nov 25, 2025
@rchandramouli @saiarcot895
[sonic-net#24386] rsyslog: restore kernel timestamp in the /dev/kmsg …
87b1ae0 
…logs (sonic-net#56)

The `imklog` plugin of rsyslog collects the kernel logs from `/dev/kmsg` and
enqueues it to the syslog. With `CONFIG_PRINTK_TIME` the kernel messages are by
default prefixed with the elapsed time since boot. The `imklog` plugin parsing
these messages have a few options such as to keep the timestamps as such or to
interpret and adjust the syslog's reported time accordingly.

The rsylog release `8.2312.0` has fixes in interpreting these timestamps,
leading to the change in behavior observed in sonic-net#24386.

  https://salsa.debian.org/debian/rsyslog/-/blob/debian/8.2504.0-1/ChangeLog?ref_type=tags#L619

To restore the earlier behavior or retaining the kernel reported elapsed time,
disable `KlogParseKernelTimestamp` as this leads to removal of timestamp from
kernel messages and enable `KlogKeepKernelTimestamp` explicitly. The later is
required as the default is now to discard the kernel timestamp.

With this change, the logs retain the kernel timestamp:

    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | head -n 3
    2025 Nov  4 05:15:14.918946 sonic NOTICE kernel: [    0.000000] Linux version 6.12.41+deb13-sonic-amd64 ([email protected]) (x86_64-linux-gnu-gcc-14 (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) #1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12)
    2025 Nov  4 05:15:14.919533 sonic INFO kernel: [    0.000000] Command line: BOOT_IMAGE=/image-trixie.0-dirty-20251102.122837/boot/vmlinuz-6.12.41+deb13-sonic-amd64 root=UUID=ac0b6826-f8a3-461f-a8ff-701df60d90b6 rw console=tty0 console=ttyS0,115200n8 quiet processor.max_cstate=1 intel_idle.max_cstate=0 net.ifnames=0 biosdevname=0 loop=image-trixie.0-dirty-20251102.122837/fs.squashfs loopfstype=squashfs apparmor=1 security=apparmor varlog_size=4096 usbcore.autosuspend=-1 intel_iommu=off modprobe.blacklist=gpio_ich,i2c-ismt,i2c_ismt,i2c-i801,i2c_i801 crashkernel=0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M acpi_no_watchdog
    2025 Nov  4 05:15:14.919536 sonic INFO kernel: [    0.000000] BIOS-provided physical RAM map:
    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | tail -n 3
    2025 Nov  4 05:17:26.831607 sonic WARNING kernel: [  143.527486] PDDF_LED       set_status_led: Set [FANTRAY_LED;1] color[green]
    2025 Nov  4 05:17:26.912442 sonic WARNING kernel: [  143.607086] PDDF_LED       set_status_led: Set [FANTRAY_LED;2] color[green]
    2025 Nov  4 05:20:32.499634 sonic WARNING kernel: [  329.195319] PDDF_LED       set_status_led: Set [SYS_LED;0] color[amber]
    root@sonic:~#

Signed-off-by: Ramasamy Chandramouli <[email protected]>
Co-authored-by: Ramasamy Chandramouli <[email protected]>
yanmarkman pushed a commit to yanmarkman/sonic-buildimage that referenced this pull request Nov 26, 2025
@rchandramouli @saiarcot895
[sonic-net#24386] rsyslog: restore kernel timestamp in the /dev/kmsg …
8ecffdb 
…logs (sonic-net#56)

The `imklog` plugin of rsyslog collects the kernel logs from `/dev/kmsg` and
enqueues it to the syslog. With `CONFIG_PRINTK_TIME` the kernel messages are by
default prefixed with the elapsed time since boot. The `imklog` plugin parsing
these messages have a few options such as to keep the timestamps as such or to
interpret and adjust the syslog's reported time accordingly.

The rsylog release `8.2312.0` has fixes in interpreting these timestamps,
leading to the change in behavior observed in sonic-net#24386.

  https://salsa.debian.org/debian/rsyslog/-/blob/debian/8.2504.0-1/ChangeLog?ref_type=tags#L619

To restore the earlier behavior or retaining the kernel reported elapsed time,
disable `KlogParseKernelTimestamp` as this leads to removal of timestamp from
kernel messages and enable `KlogKeepKernelTimestamp` explicitly. The later is
required as the default is now to discard the kernel timestamp.

With this change, the logs retain the kernel timestamp:

    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | head -n 3
    2025 Nov  4 05:15:14.918946 sonic NOTICE kernel: [    0.000000] Linux version 6.12.41+deb13-sonic-amd64 ([email protected]) (x86_64-linux-gnu-gcc-14 (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) sonic-net#1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12)
    2025 Nov  4 05:15:14.919533 sonic INFO kernel: [    0.000000] Command line: BOOT_IMAGE=/image-trixie.0-dirty-20251102.122837/boot/vmlinuz-6.12.41+deb13-sonic-amd64 root=UUID=ac0b6826-f8a3-461f-a8ff-701df60d90b6 rw console=tty0 console=ttyS0,115200n8 quiet processor.max_cstate=1 intel_idle.max_cstate=0 net.ifnames=0 biosdevname=0 loop=image-trixie.0-dirty-20251102.122837/fs.squashfs loopfstype=squashfs apparmor=1 security=apparmor varlog_size=4096 usbcore.autosuspend=-1 intel_iommu=off modprobe.blacklist=gpio_ich,i2c-ismt,i2c_ismt,i2c-i801,i2c_i801 crashkernel=0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M acpi_no_watchdog
    2025 Nov  4 05:15:14.919536 sonic INFO kernel: [    0.000000] BIOS-provided physical RAM map:
    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | tail -n 3
    2025 Nov  4 05:17:26.831607 sonic WARNING kernel: [  143.527486] PDDF_LED       set_status_led: Set [FANTRAY_LED;1] color[green]
    2025 Nov  4 05:17:26.912442 sonic WARNING kernel: [  143.607086] PDDF_LED       set_status_led: Set [FANTRAY_LED;2] color[green]
    2025 Nov  4 05:20:32.499634 sonic WARNING kernel: [  329.195319] PDDF_LED       set_status_led: Set [SYS_LED;0] color[amber]
    root@sonic:~#

Signed-off-by: Ramasamy Chandramouli <[email protected]>
Co-authored-by: Ramasamy Chandramouli <[email protected]>
yanmarkman pushed a commit to yanmarkman/sonic-buildimage that referenced this pull request Dec 3, 2025
@rchandramouli @saiarcot895
[sonic-net#24386] rsyslog: restore kernel timestamp in the /dev/kmsg …
261a661 
…logs (sonic-net#56)

The `imklog` plugin of rsyslog collects the kernel logs from `/dev/kmsg` and
enqueues it to the syslog. With `CONFIG_PRINTK_TIME` the kernel messages are by
default prefixed with the elapsed time since boot. The `imklog` plugin parsing
these messages have a few options such as to keep the timestamps as such or to
interpret and adjust the syslog's reported time accordingly.

The rsylog release `8.2312.0` has fixes in interpreting these timestamps,
leading to the change in behavior observed in sonic-net#24386.

  https://salsa.debian.org/debian/rsyslog/-/blob/debian/8.2504.0-1/ChangeLog?ref_type=tags#L619

To restore the earlier behavior or retaining the kernel reported elapsed time,
disable `KlogParseKernelTimestamp` as this leads to removal of timestamp from
kernel messages and enable `KlogKeepKernelTimestamp` explicitly. The later is
required as the default is now to discard the kernel timestamp.

With this change, the logs retain the kernel timestamp:

    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | head -n 3
    2025 Nov  4 05:15:14.918946 sonic NOTICE kernel: [    0.000000] Linux version 6.12.41+deb13-sonic-amd64 ([email protected]) (x86_64-linux-gnu-gcc-14 (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) sonic-net#1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12)
    2025 Nov  4 05:15:14.919533 sonic INFO kernel: [    0.000000] Command line: BOOT_IMAGE=/image-trixie.0-dirty-20251102.122837/boot/vmlinuz-6.12.41+deb13-sonic-amd64 root=UUID=ac0b6826-f8a3-461f-a8ff-701df60d90b6 rw console=tty0 console=ttyS0,115200n8 quiet processor.max_cstate=1 intel_idle.max_cstate=0 net.ifnames=0 biosdevname=0 loop=image-trixie.0-dirty-20251102.122837/fs.squashfs loopfstype=squashfs apparmor=1 security=apparmor varlog_size=4096 usbcore.autosuspend=-1 intel_iommu=off modprobe.blacklist=gpio_ich,i2c-ismt,i2c_ismt,i2c-i801,i2c_i801 crashkernel=0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M acpi_no_watchdog
    2025 Nov  4 05:15:14.919536 sonic INFO kernel: [    0.000000] BIOS-provided physical RAM map:
    root@sonic:~# cat /var/log/syslog | grep "sonic.*kernel:" | tail -n 3
    2025 Nov  4 05:17:26.831607 sonic WARNING kernel: [  143.527486] PDDF_LED       set_status_led: Set [FANTRAY_LED;1] color[green]
    2025 Nov  4 05:17:26.912442 sonic WARNING kernel: [  143.607086] PDDF_LED       set_status_led: Set [FANTRAY_LED;2] color[green]
    2025 Nov  4 05:20:32.499634 sonic WARNING kernel: [  329.195319] PDDF_LED       set_status_led: Set [SYS_LED;0] color[amber]
    root@sonic:~#

Signed-off-by: Ramasamy Chandramouli <[email protected]>
Co-authored-by: Ramasamy Chandramouli <[email protected]>
yanmarkman added a commit to yanmarkman/sonic-buildimage that referenced this pull request Jan 15, 2026
@yanmarkman
[submod] mrvl-prestera update 15jan
75d22d6 
intDriver: Add timeout WA for lost IRQs (sonic-net#56)
sonic-ext.target wrapper for sonic.target (sonic-net#60)
amd64: ethDriver.c force DMA_BIT_MASK 32bits (sonic-net#59)

Signed-off-by: Yan Markman <[email protected]>
@yanmarkman yanmarkman mentioned this pull request Jan 15, 2026
Closed
6 tasks
@yanmarkman yanmarkman mentioned this pull request Feb 12, 2026
Merged
6 tasks
mssonicbld added a commit that referenced this pull request Feb 19, 2026
@mssonicbld
[submodule] Update submodule sonic-dash-api to the latest HEAD automa…
736a156 
…tically (#25545)

#### Why I did it
src/sonic-dash-api
```
* 459cad6 - (HEAD -> master, origin/master, origin/HEAD) Add two extra HA states (#59) (3 hours ago) [Changrong Wu]
* b3dfda7 - Add list of trusted VNIs (#56) (29 hours ago) [Lawrence Lee]
```
#### How I did it
#### How to verify it
#### Description for the changelog
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
@mssonicbld @FengPan-Frank
[submodule] Update submodule sonic-dash-api to the latest HEAD automa…
4de75b0 
…tically (sonic-net#25545)

#### Why I did it
src/sonic-dash-api
```
* 459cad6 - (HEAD -> master, origin/master, origin/HEAD) Add two extra HA states (sonic-net#59) (3 hours ago) [Changrong Wu]
* b3dfda7 - Add list of trusted VNIs (sonic-net#56) (29 hours ago) [Lawrence Lee]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <[email protected]>
dprital pushed a commit that referenced this pull request Mar 19, 2026
@mssonicbld @dprital
[submodule] Update submodule sonic-dash-api to the latest HEAD automa…
f4b12c9 
…tically (#25545)

#### Why I did it
src/sonic-dash-api
```
* 459cad6 - (HEAD -> master, origin/master, origin/HEAD) Add two extra HA states (#59) (3 hours ago) [Changrong Wu]
* b3dfda7 - Add list of trusted VNIs (#56) (29 hours ago) [Lawrence Lee]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft left review comments

@lguohan lguohan lguohan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stcheng @lguohan @qiluo-msft