Skip to content

remove minlink initial value while fallback is define#4090

Open
twtseng-tim wants to merge 2 commits intosonic-net:masterfrom
twtseng-tim:fix_fallback
Open

remove minlink initial value while fallback is define#4090
twtseng-tim wants to merge 2 commits intosonic-net:masterfrom
twtseng-tim:fix_fallback

Conversation

@twtseng-tim
Copy link

@twtseng-tim twtseng-tim commented Jan 31, 2020

- What I did
remove minlink initial value while fallback is define [#2053]
- How I did it

- How to verify it
add <Fallback>true</Fallback> in minigraph.xml where defined Portchannel
Do: config load_minigraph -y

- Description for the changelog

before this change I got following error message:

Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json--write-to-db
Traceback (most recent call last):
  File "/usr/local/bin/sonic-cfggen", line 280, in <module>
    main()
  File "/usr/local/bin/sonic-cfggen", line 212, in main
    deep_update(data, parse_xml(minigraph, platform))
  File "/usr/local/lib/python2.7/dist-packages/minigraph.py", line 562, in parse_xml
    (intfs, lo_intfs, mgmt_intf, vlans, vlan_members, pcs, pc_members, acls, vni) = parse_dpg(child, hostname)
  File "/usr/local/lib/python2.7/dist-packages/minigraph.py", line 206, in parse_dpg
    pcs[pcintfname] = {'members': pcmbr_list, 'fallback': pcintf.find(str(QName(ns, "Fallback"))).text, 'min_links': str(int(math.ceil(len() * 0.75)))}
TypeError: len() takes exactly one argument (0 given)

after this change it can load normally:

~$ sudo config load_minigraph -y
Running command: systemctl stop dhcp_relay
Running command: systemctl stop swss
Running command: systemctl stop snmp
Warning: Stopping snmp.service, but it can still be activated by:
  snmp.timer
Running command: systemctl stop lldp
Running command: systemctl stop pmon
Running command: systemctl stop bgp
Running command: systemctl stop teamd
Running command: systemctl stop hostcfgd
Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json --write-to-db
Running command: pfcwd start_default
Running command: config qos reload
Buffer definition template not found at /usr/share/sonic/device/x86_64-accton_as7816_64x-r0/Accton-AS7816-64X/buffers.json.j2

Running command: systemctl restart hostname-config
Running command: systemctl restart interfaces-config
Running command: systemctl restart ntp-config
Running command: systemctl restart rsyslog-config
Running command: systemctl restart swss
Running command: systemctl restart bgp
Running command: systemctl restart teamd
Running command: systemctl restart pmon
Running command: systemctl restart lldp
Running command: systemctl restart snmp
Running command: systemctl restart dhcp_relay
Running command: systemctl restart hostcfgd
Please note setting loaded from minigraph will be lost after system reboot. To preserve setting, run `config save`.
**- A picture of a cute animal (not mandatory but encouraged)**

chenkelly
chenkelly previously approved these changes Feb 7, 2020
@twtseng-tim
Copy link
Author

Hi, @hzheng5 @stcheng , should i do any modify for pass this pr.

@twtseng-tim
Copy link
Author

Hi, @hzheng5 @stcheng , Is there any suggestion for this pr?

@prsunny prsunny requested review from lguohan and pavel-shirshov May 18, 2020 18:16
pc_members[(pcintfname, pcmbr_list[i])] = {'NULL': 'NULL'}
if pcintf.find(str(QName(ns, "Fallback"))) != None:
pcs[pcintfname] = {'members': pcmbr_list, 'fallback': pcintf.find(str(QName(ns, "Fallback"))).text, 'min_links': str(int(math.ceil(len() * 0.75)))}
pcs[pcintfname] = {'members': pcmbr_list, 'fallback': pcintf.find(str(QName(ns, "Fallback"))).text}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put pcmbr_list as len parameter here.

Copy link
Author

@twtseng-tim twtseng-tim May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see here #2053 (comment) decided to remove this parameter
fallback support multi-member now?

@pavel-shirshov
Copy link
Contributor

sonic-net/sonic-swss#951

mssonicbld added a commit that referenced this pull request Jan 31, 2026
…lly (#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request #4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/ 
* 76f9b4b7 - Merge pull request #4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/ 
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request #4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/ 
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request #4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog
xincunli-sonic pushed a commit to xincunli-sonic/sonic-buildimage that referenced this pull request Feb 2, 2026
…lly (sonic-net#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (sonic-net#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (sonic-net#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (sonic-net#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request sonic-net#4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/
* 76f9b4b7 - Merge pull request sonic-net#4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (sonic-net#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (sonic-net#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request sonic-net#4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (sonic-net#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (sonic-net#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request sonic-net#4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
…lly (sonic-net#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (sonic-net#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (sonic-net#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (sonic-net#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request sonic-net#4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/
* 76f9b4b7 - Merge pull request sonic-net#4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (sonic-net#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (sonic-net#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request sonic-net#4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (sonic-net#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (sonic-net#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request sonic-net#4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <[email protected]>
dprital pushed a commit that referenced this pull request Mar 19, 2026
…lly (#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request #4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/
* 76f9b4b7 - Merge pull request #4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request #4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request #4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants