[swss service] flush fast-reboot enabled flag upon swss stopping#3908
Merged
yxieca merged 1 commit intosonic-net:masterfrom Dec 16, 2019
Merged
[swss service] flush fast-reboot enabled flag upon swss stopping#3908yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
If we need to stop swss during fast-reboot procedure on the boot up path, it means that something went wrong, like syncd/orchagent crashed already, we are stopping and restarting swss/syncd to re-initialize. In this case, we should proceed as if it is a cold reboot. Signed-off-by: Ying Xie <[email protected]>
Contributor
Author
|
retest vsimage please |
lguohan
approved these changes
Dec 16, 2019
yxieca
added a commit
that referenced
this pull request
Dec 16, 2019
If we need to stop swss during fast-reboot procedure on the boot up path, it means that something went wrong, like syncd/orchagent crashed already, we are stopping and restarting swss/syncd to re-initialize. In this case, we should proceed as if it is a cold reboot. Signed-off-by: Ying Xie <[email protected]>
abdosi
pushed a commit
that referenced
this pull request
Jan 3, 2020
If we need to stop swss during fast-reboot procedure on the boot up path, it means that something went wrong, like syncd/orchagent crashed already, we are stopping and restarting swss/syncd to re-initialize. In this case, we should proceed as if it is a cold reboot. Signed-off-by: Ying Xie <[email protected]>
mssonicbld
added a commit
that referenced
this pull request
Jan 31, 2026
…lly (#25253) #### Why I did it src/sonic-swss ``` * 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (#3908) (4 hours ago) [prabhataravind] * 1d348170 - Enabling the FEC histogram for gbsyncd counters (#4067) (9 hours ago) [arpit-nexthop] * 2ee85de5 - [ci] fix docker slave name (#4090) (29 hours ago) [yijingyan2] * 0f99a399 - Merge pull request #4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570] |/ * 76f9b4b7 - Merge pull request #4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570] |/ * b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan] * 61724451 - Add drop monitor attributes to supported debug counter attributes (#4120) (7 days ago) [manish1-arista] * 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (#4150) (7 days ago) [Jing Zhang] * 8b18beef - Merge pull request #4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570] | failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570] |/ * a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (#3977) (9 days ago) [saksarav-nokia] * 416a0eb8 - [countersyncd]: Add retry between client and otel collector (#4131) (10 days ago) [Janet Cui] * 5fdb2456 - Merge pull request #4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle] * 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570] ``` #### How I did it #### How to verify it #### Description for the changelog
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
…lly (sonic-net#25253) #### Why I did it src/sonic-swss ``` * 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (sonic-net#3908) (4 hours ago) [prabhataravind] * 1d348170 - Enabling the FEC histogram for gbsyncd counters (sonic-net#4067) (9 hours ago) [arpit-nexthop] * 2ee85de5 - [ci] fix docker slave name (sonic-net#4090) (29 hours ago) [yijingyan2] * 0f99a399 - Merge pull request sonic-net#4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570] |/ * 76f9b4b7 - Merge pull request sonic-net#4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570] |/ * b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan] * 61724451 - Add drop monitor attributes to supported debug counter attributes (sonic-net#4120) (7 days ago) [manish1-arista] * 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (sonic-net#4150) (7 days ago) [Jing Zhang] * 8b18beef - Merge pull request sonic-net#4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570] | failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570] |/ * a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (sonic-net#3977) (9 days ago) [saksarav-nokia] * 416a0eb8 - [countersyncd]: Add retry between client and otel collector (sonic-net#4131) (10 days ago) [Janet Cui] * 5fdb2456 - Merge pull request sonic-net#4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle] * 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…lly (sonic-net#25253) #### Why I did it src/sonic-swss ``` * 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (sonic-net#3908) (4 hours ago) [prabhataravind] * 1d348170 - Enabling the FEC histogram for gbsyncd counters (sonic-net#4067) (9 hours ago) [arpit-nexthop] * 2ee85de5 - [ci] fix docker slave name (sonic-net#4090) (29 hours ago) [yijingyan2] * 0f99a399 - Merge pull request sonic-net#4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570] |/ * 76f9b4b7 - Merge pull request sonic-net#4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570] |/ * b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan] * 61724451 - Add drop monitor attributes to supported debug counter attributes (sonic-net#4120) (7 days ago) [manish1-arista] * 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (sonic-net#4150) (7 days ago) [Jing Zhang] * 8b18beef - Merge pull request sonic-net#4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570] | failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570] |/ * a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (sonic-net#3977) (9 days ago) [saksarav-nokia] * 416a0eb8 - [countersyncd]: Add retry between client and otel collector (sonic-net#4131) (10 days ago) [Janet Cui] * 5fdb2456 - Merge pull request sonic-net#4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle] * 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…lly (#25253) #### Why I did it src/sonic-swss ``` * 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (#3908) (4 hours ago) [prabhataravind] * 1d348170 - Enabling the FEC histogram for gbsyncd counters (#4067) (9 hours ago) [arpit-nexthop] * 2ee85de5 - [ci] fix docker slave name (#4090) (29 hours ago) [yijingyan2] * 0f99a399 - Merge pull request #4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570] |/ * 76f9b4b7 - Merge pull request #4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570] |/ * b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan] * 61724451 - Add drop monitor attributes to supported debug counter attributes (#4120) (7 days ago) [manish1-arista] * 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (#4150) (7 days ago) [Jing Zhang] * 8b18beef - Merge pull request #4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570] | failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570] |/ * a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (#3977) (9 days ago) [saksarav-nokia] * 416a0eb8 - [countersyncd]: Add retry between client and otel collector (#4131) (10 days ago) [Janet Cui] * 5fdb2456 - Merge pull request #4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle] * 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
If we need to stop swss during fast-reboot procedure on the boot up path, it means that something went wrong, like syncd/orchagent crashed already, we are stopping and restarting swss/syncd to re-initialize. In this case, we should proceed as if it is a cold reboot.
Signed-off-by: Ying Xie [email protected]
- How to verify it
Instrument code to cause an failure on fast-reboot recovering path. Without the change, syncd/swss will restart 3 times and stuck at failure state until manually resets the state and try again. With the change, the fast reboot fail once and recovered with a cold start automatically.