Skip to content

Increasing the startsecs for teamsyncd in supervisor.conf#4083

Merged
lguohan merged 1 commit intosonic-net:masterfrom
judyjoseph:teamd_fix
Jan 30, 2020
Merged

Increasing the startsecs for teamsyncd in supervisor.conf#4083
lguohan merged 1 commit intosonic-net:masterfrom
judyjoseph:teamd_fix

Conversation

@judyjoseph
Copy link
Contributor

- What I did
Updating the startsecs=5sec for teamsyncd to make the time for which …the process needs to stay up before declaring the startup successful.

- How I did it
Added the statement startsecs=5sec for teamsyncd process in supervisor.conf file in teamd docker.

- How to verify it
Back to back config reloads was tried.

- Description for the changelog
As per the current implementation in teamsyncd, When a TeamPortSync object is created, if there is a failure in team_init/team_alloc, it is retried 3 times with a sleep of 1 sec in between. So the teamsyncd could take upto 3 secs for coming up in case it hits the error. Hence increasing the startsecs to 5sec, so that supervisord will recognize the failure of teamsyncd and try starting again.

- A picture of a cute animal (not mandatory but encouraged)

…the process needs to stay up

before declaring the startup successfull.
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this get cherry-picked into 201911?

@judyjoseph
Copy link
Contributor Author

Should this get cherry-picked into 201911?

Yes, will add the labels.

@lguohan
Copy link
Collaborator

lguohan commented Jan 30, 2020

retest vsimage please

@lguohan lguohan merged commit c95d8e4 into sonic-net:master Jan 30, 2020
@judyjoseph judyjoseph deleted the teamd_fix branch January 30, 2020 15:07
yxieca pushed a commit that referenced this pull request Jan 30, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
rlhui pushed a commit that referenced this pull request Jan 31, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
mssonicbld added a commit that referenced this pull request Jan 31, 2026
…lly (#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request #4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/ 
* 76f9b4b7 - Merge pull request #4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/ 
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request #4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\ 
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/ 
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request #4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog
xincunli-sonic pushed a commit to xincunli-sonic/sonic-buildimage that referenced this pull request Feb 2, 2026
…lly (sonic-net#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (sonic-net#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (sonic-net#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (sonic-net#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request sonic-net#4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/
* 76f9b4b7 - Merge pull request sonic-net#4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (sonic-net#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (sonic-net#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request sonic-net#4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (sonic-net#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (sonic-net#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request sonic-net#4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
…lly (sonic-net#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (sonic-net#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (sonic-net#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (sonic-net#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request sonic-net#4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/
* 76f9b4b7 - Merge pull request sonic-net#4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (sonic-net#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (sonic-net#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request sonic-net#4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (sonic-net#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (sonic-net#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request sonic-net#4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <[email protected]>
dprital pushed a commit that referenced this pull request Mar 19, 2026
…lly (#25253)

#### Why I did it
src/sonic-swss
```
* 9b237a2e - (HEAD -> master, origin/master, origin/HEAD) [vnet/vxlan]: Handle SAI failures without crashing swss (#3908) (4 hours ago) [prabhataravind]
* 1d348170 - Enabling the FEC histogram for gbsyncd counters (#4067) (9 hours ago) [arpit-nexthop]
* 2ee85de5 - [ci] fix docker slave name (#4090) (29 hours ago) [yijingyan2]
* 0f99a399 - Merge pull request #4089 from divyagayathri-hcl/6_multicast (34 hours ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 0cb64f2d - [P4Orch] Implement functions to process/drain multicast router interface table entries. (2 days ago) [mint570]
|/
* 76f9b4b7 - Merge pull request #4087 from divyagayathri-hcl/5_multicast (3 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 69e09ff0 - [P4Orch] Implement functions for both deleting and updating a multicast router interface table entries. (4 days ago) [mint570]
|/
* b60191c9 - This PR adds communication statistics recording and debugging utilities to countersyncd for analyzing online issues and performance. The changes introduce a new utilities module with functions for formatting hex dumps and tracking inter-actor channel statistics. Changes: Added utilities module with hex formatting and channel statistics tracking Instrumented all actor message receive points to record queue lengths Added debug logging for raw netlink message payloads Reviewed changes (7 days ago) [Ze Gan]
* 61724451 - Add drop monitor attributes to supported debug counter attributes (#4120) (7 days ago) [manish1-arista]
* 48c3c201 - [Vnetorch] Relax attr parsing for vnet route table (#4150) (7 days ago) [Jing Zhang]
* 8b18beef - Merge pull request #4085 from divyagayathri-hcl/3_multicast (7 days ago) [StephenWangGoogle]
|\
| failure_prs.log skip_prs.log 6125fc55 - [P4Orch] Implement functions to add multicast router interface table entries. (8 days ago) [mint570]
| failure_prs.log skip_prs.log 2571bbb8 - [P4Orch] Add L3MulticastManager class definition and begin to populate its unit test. (8 days ago) [mint570]
|/
* a8d968c9 - Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU (#3977) (9 days ago) [saksarav-nokia]
* 416a0eb8 - [countersyncd]: Add retry between client and otel collector (#4131) (10 days ago) [Janet Cui]
* 5fdb2456 - Merge pull request #4083 from divyagayathri-hcl/1_multicast (10 days ago) [StephenWangGoogle]
* 8e72c3d9 - [P4Orch] Add support for SAI functions needed for swss multicast support. (12 days ago) [mint570]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants