[Mellanox] Fix thermal_updater polling interval get issue#25031
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Jan 29, 2026
Merged
[Mellanox] Fix thermal_updater polling interval get issue#25031liat-grozovik merged 2 commits intosonic-net:masterfrom
liat-grozovik merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
platform/mellanox/mlnx-platform-api/sonic_platform/thermal_updater.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/tests/test_thermal_updater.py
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
approved these changes
Jan 12, 2026
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jianyue Wu <jianyuew@nvidia.com>
jianyuewu
force-pushed
the
thermal_match_poll_key
branch
from
b0e754c to
13d3ac0
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Jan 29, 2026
Collaborator
|
@jianyuewu can you please have a dedicated PR for 202511 due to conflict? |
jianyuewu
added
Request for msft-202412 Branch
and removed
Approved for msft-202412 Branch
Cherry Pick Conflict_msft-202412
labels
Contributor
Author
@liat-grozovik Sure. |
r12f
added
Approved for msft-202412 Branch
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
Contributor
|
merged in 202412. |
Contributor
|
thanks @jianyuewu ! |
Contributor
Author
|
Thank you @r12f 😊 |
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
…25031) - Why I did it The thermal updater's load_tc_config method was unable to correctly parse tc_config files that use regex-based parameter. - How I did it Added _find_matching_key method: Implements regex pattern matching to find parameter keys in dictionary. Updated load_tc_config method: Changed ASIC parameter lookup to use regex pattern r'asic\\d*' Changed Module parameter lookup to use regex pattern r'module\\d+' - How to verify it Test in switch, check if corrected parsed. Signed-off-by: Jianyue Wu <jianyuew@nvidia.com> Signed-off-by: Xincun Li <stli@microsoft.com>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…25031) - Why I did it The thermal updater's load_tc_config method was unable to correctly parse tc_config files that use regex-based parameter. - How I did it Added _find_matching_key method: Implements regex pattern matching to find parameter keys in dictionary. Updated load_tc_config method: Changed ASIC parameter lookup to use regex pattern r'asic\\d*' Changed Module parameter lookup to use regex pattern r'module\\d+' - How to verify it Test in switch, check if corrected parsed. Signed-off-by: Jianyue Wu <jianyuew@nvidia.com> Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
- Why I did it The thermal updater's load_tc_config method was unable to correctly parse tc_config files that use regex-based parameter. - How I did it Added _find_matching_key method: Implements regex pattern matching to find parameter keys in dictionary. Updated load_tc_config method: Changed ASIC parameter lookup to use regex pattern r'asic\\d*' Changed Module parameter lookup to use regex pattern r'module\\d+' - How to verify it Test in switch, check if corrected parsed. Signed-off-by: Jianyue Wu <jianyuew@nvidia.com> Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The thermal updater's
load_tc_configmethod was unable to correctly parse tc_config files that use regex-based parameter.How I did it
_find_matching_keymethod: Implements regex pattern matching to find parameter keys in dictionary.load_tc_configmethod:r'asic\\d*'r'module\\d+'How to verify it
Test in switch, check if corrected parsed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202511