Skip to content

Commit b0e754c

Browse files
committed
Update thermal updater poll interval handling and error logging
Signed-off-by: Jianyue Wu <[email protected]>
1 parent 00e3f25 commit b0e754c

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

platform/mellanox/mlnx-platform-api/sonic_platform/thermal_updater.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,33 +104,35 @@ def load_tc_config(self):
104104
sfp_poll_interval = 10
105105
data = utils.load_json_file(TC_CONFIG_FILE, log_func=None)
106106
if not data:
107-
logger.log_notice(f'{TC_CONFIG_FILE} does not exist, use default polling interval')
107+
logger.log_error(f'{TC_CONFIG_FILE} does not exist, use default polling interval')
108108

109109
if data:
110110
dev_parameters = data.get('dev_parameters')
111-
if dev_parameters is not None:
111+
if not dev_parameters:
112+
logger.log_error('dev_parameters not configured or empty, using default intervals')
113+
else:
112114
# Find ASIC parameter using regex pattern
113115
asic_key, asic_parameter = self._find_matching_key(dev_parameters, r'asic\\d*')
114116
if asic_parameter is not None:
115117
asic_poll_interval_config = asic_parameter.get('poll_time')
116118
if asic_poll_interval_config:
117-
asic_poll_interval = int(asic_poll_interval_config) / 2
119+
asic_poll_interval = int(asic_poll_interval_config)
118120
logger.log_notice(f'ASIC parameter found with key "{asic_key}", poll_time: {asic_poll_interval_config}, interval: {asic_poll_interval}')
119121
else:
120-
logger.log_notice(f'ASIC poll_time not configured in "{asic_key}", using default interval: {asic_poll_interval}')
122+
logger.log_error(f'ASIC poll_time not configured in "{asic_key}", using default interval: {asic_poll_interval}')
121123
else:
122-
logger.log_notice(f'ASIC parameter not found (pattern: asic\\d*), using default interval: {asic_poll_interval}')
124+
logger.log_error(f'ASIC parameter not found (pattern: asic\\d*), using default interval: {asic_poll_interval}')
123125
# Find Module parameter using regex pattern
124126
module_key, module_parameter = self._find_matching_key(dev_parameters, r'module\\d+')
125127
if module_parameter is not None:
126128
sfp_poll_interval_config = module_parameter.get('poll_time')
127129
if sfp_poll_interval_config:
128-
sfp_poll_interval = int(sfp_poll_interval_config) / 2
130+
sfp_poll_interval = int(sfp_poll_interval_config)
129131
logger.log_notice(f'Module parameter found with key "{module_key}", poll_time: {sfp_poll_interval_config}, interval: {sfp_poll_interval}')
130132
else:
131-
logger.log_notice(f'Module poll_time not configured in "{module_key}", using default interval: {sfp_poll_interval}')
133+
logger.log_error(f'Module poll_time not configured in "{module_key}", using default interval: {sfp_poll_interval}')
132134
else:
133-
logger.log_notice(f'Module parameter not found (pattern: module\\d+), using default interval: {sfp_poll_interval}')
135+
logger.log_error(f'Module parameter not found (pattern: module\\d+), using default interval: {sfp_poll_interval}')
134136

135137
if self._update_asic:
136138
logger.log_notice(f'ASIC polling interval: {asic_poll_interval}')

0 commit comments

Comments
 (0)