Skip to content

[Mellanox] Fix thermal_updater polling interval get issue#25258

Merged
vmittal-msft merged 1 commit intosonic-net:202511from
jianyuewu:2511_thermal_match_poll_key
Jan 29, 2026
Merged

[Mellanox] Fix thermal_updater polling interval get issue#25258
vmittal-msft merged 1 commit intosonic-net:202511from
jianyuewu:2511_thermal_match_poll_key

Conversation

@jianyuewu
Copy link
Copy Markdown
Contributor

Why I did it

The thermal updater's load_tc_config method was unable to correctly parse tc_config files that use regex-based parameter.

How I did it

  1. Added _find_matching_key method: Implements regex pattern matching to find parameter keys in dictionary.
  2. Updated load_tc_config method:
    • Changed ASIC parameter lookup to use regex pattern r'asic\\d*'
    • Changed Module parameter lookup to use regex pattern r'module\\d+'

How to verify it

Test in switch, check if corrected parsed.

Which release branch to backport (provide reason below if selected)

  • 202412
  • 202511

Tested branch (Please provide the tested image version)

202511

@jianyuewu jianyuewu requested a review from lguohan as a code owner January 29, 2026 10:04
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

- Why I did it
The thermal updater's load_tc_config method was unable to correctly parse tc_config files that use regex-based parameter.

- How I did it
Added _find_matching_key method: Implements regex pattern matching to find parameter keys in dictionary.
Updated load_tc_config method:
Changed ASIC parameter lookup to use regex pattern r'asic\\d*'
Changed Module parameter lookup to use regex pattern r'module\\d+'

- How to verify it
Test in switch, check if corrected parsed.

Signed-off-by: Jianyue Wu <jianyuew@nvidia.com>
@jianyuewu jianyuewu force-pushed the 2511_thermal_match_poll_key branch from 9be9003 to 49299f4 Compare January 29, 2026 10:14
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft vmittal-msft merged commit 535866c into sonic-net:202511 Jan 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants