[Mellanox|FFB]: Add support for Mellanox fast-fast boot by volodymyrsamotiy · Pull Request #2294 · sonic-net/sonic-buildimage

volodymyrsamotiy · 2018-11-23T16:56:47Z

Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com

Depends on:
sonic-net/sonic-utilities#390
sonic-net/sonic-sairedis#389

- What I did
Added support for Mellanox fast-fast boot
- How I did it
Added support for Mellanox fast-fast boot
- How to verify it
Run "warm-reboot" CLI command and verify that all is up after reboot
- Description for the changelog
[Mellanox|FFB]: Add support for Mellanox fast-fast boot

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

lguohan · 2018-11-28T08:54:21Z

platform/mellanox/mlnx-issu/scripts/ffb

+
+
+import time
+import swsssdk


use swsscommon python bind, it has notificationconsumer implemented, do not use swssdk.

swsssdk is used here because swsscommon is not available inside syncd docker container, only swsssdk

lguohan · 2018-11-28T09:02:28Z

files/build_templates/docker_image_ctl.j2

+    warm*)
        TYPE='warm'
        ;;
+    fast-fast)


lguohan · 2018-11-28T09:03:20Z

files/scripts/swss.sh

+        # Don't flush APP_DB during MLNX fast-fast boot
+        BOOT_TYPE="$(cat /proc/cmdline | grep -o 'SONIC_BOOT_TYPE=\S*' | cut -d'=' -f2)"
+        if [[ x"$BOOT_TYPE" != x"fast-fast" ]] && [[ ! -f /var/warmboot/issu_started ]]; then
+            /usr/bin/docker exec database redis-cli -n 0 FLUSHDB


why do not flush app_db?

lguohan · 2018-11-28T09:24:41Z

platform/mellanox/mlnx-issu/scripts/ffb

+        self.pubSub = self.state_db.redis_clients[self.state_db.STATE_DB].pubsub()
+        self.pubSub.psubscribe(**{'__key*@6__:{}'.format(self.DB_WARM_TABLE_KEY): self.eventHandler})
+
+        self.timeoutTimer = Timer(self.STOP_TIMER_TIMEOUT, self.finish)


I do not feel the finish is tied to bgp reconciliation logic. let's have an offline discussion.

* Change naming convention from "fast-fast" to "fastfast" Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

lguohan · 2018-12-03T19:32:02Z

@volodymyrsamotiy, can we merge this now?

volodymyrsamotiy · 2018-12-04T08:38:55Z

@lguohan, yes we can merge now

qiluo-msft · 2019-06-25T01:56:01Z

files/build_templates/docker_image_ctl.j2

-        ;;
-    *SONIC_BOOT_TYPE=warm*)
+    local BOOT_TYPE
+    case "$(cat /proc/cmdline | grep -o 'SONIC_BOOT_TYPE=\S*' | cut -d'=' -f2)" in


SONIC_BOOT_TYPE= [](start = 41, length = 16)

We should handle both cases for backward-compatible with 201803:

fast-reboot

SONIC_BOOT_TYPE=fast-reboot

Otherwise we cannot fast-reboot from 201803 into 201811.

* 910bfd4 2022-05-28 | [ACL] Add default action_list for default ACL table type (sonic-net#2298) (github/master) [bingwang-ms] * 4d6fa42 2022-05-27 | [ci] Change artifact reference pipeline to common lib pipeline. (sonic-net#2294) [Shilong Liu] * 583236f 2022-05-26 | [P4Orch] Lazy UDF match creation to avoid failure during warm reboot (sonic-net#2282) [Yilan Ji] * d7b5ff7 2022-05-26 | [ci] Use correct branch when downloading artifact. (sonic-net#2292) [Shilong Liu] * 2f13244 2022-05-26 | [ci] Improve azp trigger settings to automaticlly support new release branch. (sonic-net#2289) [Shilong Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* 910bfd4 2022-05-28 | [ACL] Add default action_list for default ACL table type (#2298) (github/master) [bingwang-ms] * 4d6fa42 2022-05-27 | [ci] Change artifact reference pipeline to common lib pipeline. (#2294) [Shilong Liu] * 583236f 2022-05-26 | [P4Orch] Lazy UDF match creation to avoid failure during warm reboot (#2282) [Yilan Ji] * d7b5ff7 2022-05-26 | [ci] Use correct branch when downloading artifact. (#2292) [Shilong Liu] * 2f13244 2022-05-26 | [ci] Improve azp trigger settings to automaticlly support new release branch. (#2289) [Shilong Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…anch Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980

639d10e (HEAD, origin/202012) [PFC_WD] [202012] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2310) 475ae19 [202012] [cherry-pick] Apply `DSCP_TO_TC_MAP` from `PORT_QOS_MAP|global` to switch level (sonic-net#2328) aa6f855 [ci] Change artifact reference pipeline to common lib pipeline. (sonic-net#2294) 752f8c5 [ci] Use correct branch when downloading artifact. (sonic-net#2292) b3fcc5d [ci] Improve azp trigger settings to automaticlly support new release branch. (sonic-net#2289) Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

Update sonic-swss submodule ``` 639d10e [PFC_WD] [202012] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2310) 475ae19 [202012] [cherry-pick] Apply `DSCP_TO_TC_MAP` from `PORT_QOS_MAP|global` to switch level (#2328) aa6f855 [ci] Change artifact reference pipeline to common lib pipeline. (#2294) 752f8c5 [ci] Use correct branch when downloading artifact. (#2292) b3fcc5d [ci] Improve azp trigger settings to automaticlly support new release branch. (#2289) ```

…c-net#2294) * [ci] Change artifact reference pipeline to common lib pipeline.

Stepan Blyschak and others added 2 commits November 23, 2018 14:22

[mlnx|ffb] Add support for mellanox fast-fast boot

ca90d72

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

[mlnx|ffb]: Add support of "config end" event for mlnx fast-fast boot

14c571c

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

stcheng added Enhancement ➕ Platform: Mellanox labels Nov 24, 2018

lguohan reviewed Nov 28, 2018

View reviewed changes

files/build_templates/docker_image_ctl.j2 Outdated

warm*)

TYPE='warm'

;;

fast-fast)

Copy link

Collaborator

lguohan Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastfast

lguohan reviewed Nov 28, 2018

View reviewed changes

[Mellanox|FFB]: Fix review comments

ee8c5a2

* Change naming convention from "fast-fast" to "fastfast" Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

volodymyrsamotiy changed the title ~~[mlnx|ffb]: Add support for mellanox fast-fast boot~~ [Mellanox|FFB]: Add support for Mellanox fast-fast boot Dec 1, 2018

lguohan merged commit 75b4123 into sonic-net:master Dec 4, 2018

qiluo-msft reviewed Jun 25, 2019

View reviewed changes

yxieca mentioned this pull request May 27, 2022

[swss] advance sonic-swss submodule head #10959

Merged

prsunny mentioned this pull request Jul 6, 2022

[Submodule] Update sonic-swss #11369

Merged

7 tasks

vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 26, 2022

[ci] Change artifact reference pipeline to common lib pipeline. (soni…

4d6fa42

…c-net#2294) * [ci] Change artifact reference pipeline to common lib pipeline.

volodymyrsamotiy deleted the mlnx-ffb branch February 14, 2023 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox|FFB]: Add support for Mellanox fast-fast boot#2294

[Mellanox|FFB]: Add support for Mellanox fast-fast boot#2294
lguohan merged 3 commits intosonic-net:masterfrom
volodymyrsamotiy:mlnx-ffb

volodymyrsamotiy commented Nov 23, 2018 •

edited

Loading

Uh oh!

lguohan Nov 28, 2018

Uh oh!

volodymyrsamotiy Nov 30, 2018

Uh oh!

lguohan Nov 28, 2018

Uh oh!

lguohan Nov 28, 2018

Uh oh!

lguohan Nov 28, 2018

Uh oh!

lguohan commented Dec 3, 2018

Uh oh!

volodymyrsamotiy commented Dec 4, 2018

Uh oh!

qiluo-msft Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants



		import time
		import swsssdk

Conversation

volodymyrsamotiy commented Nov 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

volodymyrsamotiy Nov 30, 2018

Choose a reason for hiding this comment

Uh oh!

lguohan Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

lguohan Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

lguohan Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

lguohan commented Dec 3, 2018

Uh oh!

volodymyrsamotiy commented Dec 4, 2018

Uh oh!

qiluo-msft Jun 25, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

volodymyrsamotiy commented Nov 23, 2018 •

edited

Loading