Add YANG model and unit tests for sonic-telemetry by zbud-msft · Pull Request #10840 · sonic-net/sonic-buildimage

zbud-msft · 2022-05-16T00:52:29Z

Why I did it

YANG schema is missing for sonic-telemetry

How I did it

Added YANG schema and unit tests

How to verify it

Build sonic-yang-models python wheels target

Which release branch to backport (provide reason below if selected)

Description for the changelog

Fix #10552

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

* Update configuration.md with telemetry table * Update configuration.md header * Update Configuration.md * Update configuration.md spacing

qiluo-msft · 2022-05-17T21:46:41Z

src/sonic-yang-models/yang-models/sonic-telemetry.yang

+
+                leaf ca_crt {
+                    type string {
+                        pattern '(/[a-zA-Z0-9_-]+)*/dsmsroot.cer';


dsmsroot.cer

Is this pattern enforced by sonic-telemetry implementation? If not, we can relax. #Closed

According to:

https://github.com/Azure/sonic-mgmt/blob/a51f9fa3125ebca8a60f8e55c7f46eaf8a0e5754/ansible/group_vars/all/telemetry_certs.yml,

All telemetry certs will have the exact path listed. Maybe it makes sense to enforce the entire path instead of just the file name and extension.

The file name must be dsmsroot.cer? Can we use other name like abc.cer?

Changed pattern to not include filename in the case that file name changes in the future.

qiluo-msft · 2022-05-17T21:48:03Z

src/sonic-yang-models/tests/yang_model_tests/tests_config/telemetry.json

+            "sonic-telemetry:TELEMETRY": {
+                "certs": {
+                    "ca_crt": "/etc/sonic/telemetry/dsmsroot.cer",
+		    "server_crt": "/etc/sonic/telemetry/streamingtelemetryserver.cer",


[](http://example.com/codeflow?start=0&length=6)

Mixing tabs/spaces. Prefer 4-space indentation. #Closed

qiluo-msft · 2022-05-17T21:48:27Z

src/sonic-yang-models/tests/yang_model_tests/tests/telemetry.json

+	"eStrKey": "InvalidValue"
+    },
+    "TELEMETRY_TABLE_WITH_VALID_CONFIG": {
+	"desc": "TABLE WITH VALID CONFIG."


Mixing tabs/spaces. Prefer 4-space indentation. #Closed

qiluo-msft · 2022-05-17T21:48:54Z

src/sonic-yang-models/doc/Configuration.md

-         * [Versions](#versions)  
+         * [TC to Queue map](#tc-to-queue-map)    
+         * [Telemetry](#telemetry)    
+         * [Versions](#versions)    


[](http://example.com/codeflow?start=32&length=4)

Do not add unnecessary trailing blanks. #Closed

* Replace tabs for 4 spaces * Replace tabs for 4 spaces in telemetry file Co-authored-by: Ubuntu <zain@zb-dev-vm.022x1jpnpm4u1iy2d325acts3c.yx.internal.cloudapp.net>

…anch Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980

zbud-msft and others added 7 commits May 10, 2022 16:02

Add telemetry table to configuration.md (#2)

db9e603

* Update configuration.md with telemetry table * Update configuration.md header * Update Configuration.md * Update configuration.md spacing

Add yang model for sonic-telemetry

8ee9f9f

Resolving conflict

eeae234

Merge branch 'Azure:master' into master

39807aa

Change sample config.db

a828c39

Merge branch 'master' of github.com:zbud-msft/sonic-buildimage

68e0d50

Fix key path in sample config.db

e36dd16

zbud-msft marked this pull request as ready for review May 16, 2022 05:45

zbud-msft requested a review from qiluo-msft as a code owner May 16, 2022 05:45

zbud-msft requested review from hui-ma and yozhao101 May 17, 2022 19:15

qiluo-msft requested a review from ganglyu May 17, 2022 21:12

qiluo-msft reviewed May 17, 2022

View reviewed changes

Ubuntu and others added 6 commits May 19, 2022 01:17

Replace tabs for 4 spaces

78674f9

Merge branch 'sonic-telemetry-yang'

d53a8a8

Replace tabs for 4 spaces in telemetry file

ed4ebab

Merge branch 'sonic-telemetry-yang'

00f37c0

Sonic telemetry yang (#4)

71f553e

* Replace tabs for 4 spaces * Replace tabs for 4 spaces in telemetry file Co-authored-by: Ubuntu <zain@zb-dev-vm.022x1jpnpm4u1iy2d325acts3c.yx.internal.cloudapp.net>

Update Configuration.md

b44ea93

qiluo-msft mentioned this pull request May 19, 2022

TELEMETRY yang model #10873

Closed

6 tasks

MaratGubaiev mentioned this pull request May 19, 2022

[yang] Need Yang for TELEMETRY table #10552

Closed

Ubuntu added 3 commits May 19, 2022 17:43

Remove harcoded file name from pattern

97a1720

Merge branch 'sonic-telemetry-yang'

6768b03

Merge branch 'master' of github.com:zbud-msft/sonic-buildimage

f753be7

ganglyu approved these changes May 19, 2022

View reviewed changes

qiluo-msft approved these changes May 19, 2022

View reviewed changes

hui-ma approved these changes May 20, 2022

View reviewed changes

Merge branch 'Azure:master' into master

2e37406

zbud-msft merged commit 8315d11 into sonic-net:master May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add YANG model and unit tests for sonic-telemetry#10840

Add YANG model and unit tests for sonic-telemetry#10840
zbud-msft merged 17 commits intosonic-net:masterfrom
zbud-msft:master

zbud-msft commented May 16, 2022 •

edited by ganglyu

Loading

Uh oh!

qiluo-msft May 17, 2022 •

edited

Loading

Uh oh!

zbud-msft May 18, 2022

Uh oh!

ganglyu May 19, 2022

Uh oh!

zbud-msft May 19, 2022

Uh oh!

qiluo-msft May 17, 2022 •

edited

Loading

Uh oh!

zbud-msft May 19, 2022

Uh oh!

qiluo-msft May 17, 2022 •

edited

Loading

Uh oh!

zbud-msft May 19, 2022

Uh oh!

qiluo-msft May 17, 2022 •

edited

Loading

Uh oh!

zbud-msft May 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zbud-msft commented May 16, 2022 • edited by ganglyu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

qiluo-msft May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zbud-msft May 18, 2022

Choose a reason for hiding this comment

Uh oh!

ganglyu May 19, 2022

Choose a reason for hiding this comment

Uh oh!

zbud-msft May 19, 2022

Choose a reason for hiding this comment

Uh oh!

qiluo-msft May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zbud-msft May 19, 2022

Choose a reason for hiding this comment

Uh oh!

qiluo-msft May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zbud-msft May 19, 2022

Choose a reason for hiding this comment

Uh oh!

qiluo-msft May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zbud-msft May 19, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zbud-msft commented May 16, 2022 •

edited by ganglyu

Loading

qiluo-msft May 17, 2022 •

edited

Loading

qiluo-msft May 17, 2022 •

edited

Loading

qiluo-msft May 17, 2022 •

edited

Loading

qiluo-msft May 17, 2022 •

edited

Loading