skip frr_bmp container from monit by FengPan-Frank · Pull Request #22588 · sonic-net/sonic-buildimage

FengPan-Frank · 2025-05-09T23:49:45Z

Why I did it

frr_bmp is only feature switch used for bgpd to start as "/usr/lib/frr/bgpd -A 127.0.0.1 -M bmp", so that bmp container later rollout could work, thus is should be skipped from container check.

Work item tracking

Microsoft ADO (number only):30807821

How I did it

skip container check from monit.

How to verify it

before fix

after fix, the error log disappears.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mssonicbld · 2025-05-09T23:49:53Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-05-09T23:50:05Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2025-05-10T17:15:10Z

Please update "How to verify it" in PR description

qiluo-msft · 2025-05-10T17:15:28Z

lgtm.

StormLiangMS · 2025-05-12T05:51:04Z

hi @FengPan-Frank could you help to clarify why we don't capture this in nightly?

FengPan-Frank · 2025-05-12T11:37:52Z

hi @FengPan-Frank could you help to clarify why we don't capture this in nightly?

Hi @StormLiangMS previously we were trading-off on using frr_bmp first or using bmp feature as one time enablement, thus for not missing last image update window, refer https://github.com/sonic-net/sonic-buildimage/pull/22148/files feature switch implementation supports either of them, as a result of that existing mgmt test overwrite golden_config test with bmp feature switch was not broken. I add one more test for frr_bmp feature switch sonic-net/sonic-mgmt#18346

kperumalbfn · 2025-05-13T00:33:54Z

@FengPan-Frank We could add this to 202411, let me know.

FengPan-Frank · 2025-05-13T00:40:19Z

@FengPan-Frank We could add this to 202411, let me know.

Thanks @kperumalbfn. Yes please add this into 202411

mssonicbld · 2025-05-13T00:45:19Z

Cherry-pick PR to 202411: #22603

mssonicbld · 2025-05-16T23:01:15Z

@FengPan-Frank cherry pick PR didn't pass PR checker. Please check!!!
#22603

…h to block regression (#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results

…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results

mssonicbld · 2025-06-07T02:52:54Z

Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#1212

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes #18753

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753

…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\$SystemLogRateLimit/\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753

skip frr_bmp container from monit

…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Yael Tzur <ytzur@nvidia.com>

skip frr_bmp container from monit

817197a

FengPan-Frank requested a review from lguohan as a code owner May 9, 2025 23:49

FengPan-Frank requested a review from qiluo-msft May 9, 2025 23:50

qiluo-msft approved these changes May 12, 2025

View reviewed changes

kperumalbfn merged commit ba0bd66 into sonic-net:master May 13, 2025
19 checks passed

FengPan-Frank added the Request for 202411 Branch label May 13, 2025

kperumalbfn added the Approved for 202411 Branch label May 13, 2025

mssonicbld mentioned this pull request May 13, 2025

[action] [PR:22588] skip frr_bmp container from monit #22603

Merged

11 tasks

mssonicbld added the Created PR to 202411 Branch label May 13, 2025

FengPan-Frank mentioned this pull request May 27, 2025

Add monit test case with disable bmp but enable frr_bmp feature switch to block regression sonic-net/sonic-mgmt#18615

Merged

11 tasks

This was referenced Jun 2, 2025

Bug: test_posttest.py::test_recover_rsyslog_rate_limit fails with Error response from daemon: No such container: frr_bmp sonic-net/sonic-mgmt#18753

Closed

Skip frr_bmp in test_posttest.py::test_recover_rsyslog_rate_limit sonic-net/sonic-mgmt#18754

Merged

liushilongbuaa added Included in 202411 Branch and removed Created PR to 202411 Branch labels Jun 5, 2025

Pterosaur added Request for msft-202412 Branch Approved for msft-202412 Branch labels Jun 7, 2025

mssonicbld mentioned this pull request Jun 7, 2025

[action] [PR:22588] skip frr_bmp container from monit Azure/sonic-buildimage-msft#1212

Merged

11 tasks

mssonicbld added the Created PR to msft-202412 Branch label Jun 7, 2025

r12f added Included in msft-202412 Branch and removed Created PR to msft-202412 Branch labels Jun 12, 2025

qiluo-msft pushed a commit to qiluo-msft/sonic-buildimage that referenced this pull request Jan 26, 2026

skip frr_bmp container from monit (sonic-net#22588)

1b28fb7

skip frr_bmp container from monit

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

skip frr_bmp container from monit#22588

skip frr_bmp container from monit#22588
kperumalbfn merged 1 commit intosonic-net:masterfrom
FengPan-Frank:monitskip

FengPan-Frank commented May 9, 2025 •

edited

Loading

Uh oh!

mssonicbld commented May 9, 2025

Uh oh!

azure-pipelines bot commented May 9, 2025

Uh oh!

qiluo-msft commented May 10, 2025

Uh oh!

qiluo-msft commented May 10, 2025

Uh oh!

StormLiangMS commented May 12, 2025

Uh oh!

FengPan-Frank commented May 12, 2025

Uh oh!

Uh oh!

kperumalbfn commented May 13, 2025

Uh oh!

FengPan-Frank commented May 13, 2025

Uh oh!

mssonicbld commented May 13, 2025

Uh oh!

mssonicbld commented May 16, 2025

Uh oh!

mssonicbld commented Jun 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

FengPan-Frank commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented May 9, 2025

Uh oh!

azure-pipelines bot commented May 9, 2025

Uh oh!

qiluo-msft commented May 10, 2025

Uh oh!

qiluo-msft commented May 10, 2025

Uh oh!

StormLiangMS commented May 12, 2025

Uh oh!

FengPan-Frank commented May 12, 2025

Uh oh!

Uh oh!

kperumalbfn commented May 13, 2025

Uh oh!

FengPan-Frank commented May 13, 2025

Uh oh!

mssonicbld commented May 13, 2025

Uh oh!

mssonicbld commented May 16, 2025

Uh oh!

mssonicbld commented Jun 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

FengPan-Frank commented May 9, 2025 •

edited

Loading