Skip frr_bmp in test_posttest.py::test_recover_rsyslog_rate_limit#18754
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Jun 13, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
approved these changes
Jun 12, 2025
Contributor
|
I think one bigger improvement that we can make here is to add a field in feature table to indicate whether a docker container (and maybe which container) is associated with a feature key. |
FengPan-Frank
approved these changes
Jun 13, 2025
11 tasks
qiluo-msft
approved these changes
Jun 13, 2025
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\$SystemLogRateLimit/\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753 Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
test_posttest.py::test_recover_rsyslog_rate_limit iterates over the results of show feature status and executes the following commands: docker exec -i frr_bmp sed -i 's/^#\\$SystemLogRateLimit/\\$SystemLogRateLimit/g' /etc/rsyslog.conf docker exec -i frr_bmp supervisorctl restart rsyslogd frr_bmp shows up in show feature status but it isn't a real docker container so we should skip it. Similar PR: sonic-net/sonic-buildimage#22588 Summary: Fixes sonic-net#18753
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_posttest.py::test_recover_rsyslog_rate_limititerates over the results ofshow feature statusand executes the following commands:frr_bmpshows up inshow feature statusbut it isn't a real docker container so we should skip it.Similar PR: sonic-net/sonic-buildimage#22588
Summary:
Fixes #18753
Type of change
Back port request