Add monit test case with disable bmp but enable frr_bmp feature switch to block regression#18615
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom May 27, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
frr_bmp_verify
branch
from
5205dd6 to
622ccf9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
frr_bmp_verify
branch
from
622ccf9 to
48fad88
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
May 26, 2025
tests/bmp/test_frr_bmp_sanity.py
Outdated
| ] | ||
|
|
||
|
|
||
| def test_frr_bmp_bgp_facts(duthosts, enum_frontend_dut_hostname, enum_asic_index): |
Contributor
Contributor
Author
There was a problem hiding this comment.
Updated into PR desc.
qiluo-msft
reviewed
May 26, 2025
tests/bmp/test_frr_bmp_sanity.py
Outdated
| def test_frr_bmp_bgp_facts(duthosts, enum_frontend_dut_hostname, enum_asic_index): | ||
| duthost = duthosts[enum_frontend_dut_hostname] | ||
| disable_bmp_feature(duthost) | ||
| run_bgp_facts(duthost, enum_asic_index) |
Contributor
Contributor
Author
There was a problem hiding this comment.
changed to use check_monit_expected_container_logging
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
changed the title
qiluo-msft
approved these changes
May 27, 2025
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…h to block regression (sonic-net#18615) Approach What is the motivation for this PR? Add monit test case with disable bmp but enable frr_bmp feature switch to block regression How did you do it? Add one more test for monit syslog checking and disable bmp in advance which reflects real production config. How did you verify/test it? New test case passed without issue Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add monit test case with disable bmp but enable frr_bmp feature switch to block regression
How did you do it?
Add one more test for monit syslog checking and disable bmp in advance which reflects real production config.
How did you verify/test it?
New test case passed without issue
Used old image which does not have monit fix sonic-net/sonic-buildimage#22588 it broke the test case
With new image all test verification with frr_bmp enable + bmp disable are also passed, result could be found https://dev.azure.com/mssonic/build/_build/results?buildId=859705&view=results
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation