Skip to content

Rename enable_sff_mgr flag to enable_sff_mgr_controlled_tx #21176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
longhuan-cisco wants to merge 1 commit into from
Closed

Rename enable_sff_mgr flag to enable_sff_mgr_controlled_tx #21176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dockers/docker-platform-monitor/docker-pmon.supervisord.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ dependent_startup_wait_for=rsyslogd:running
{%- set options = options + " --skip_cmis_mgr" %}
{% endif -%}

{% if enable_xcvrd_sff_mgr %}
{%- set options = options + " --enable_sff_mgr" %}
{% if enable_xcvrd_sff_mgr_controlled_tx %}
Copy link
Contributor

@prgeor prgeor Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longhuan-cisco why the existing flag enable_xcvrd_sff_mgr will not work?

Copy link
Contributor Author

@longhuan-cisco longhuan-cisco Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to sonic-net/sonic-platform-daemons#574 (comment), will keep existing flag. This PR is no longer needed.

{%- set options = options + " --enable_sff_mgr_controlled_tx" %}
{% endif -%}

{% if delay_xcvrd %}
Expand Down