[make file] add document for KEEP_SLAVE_ON with stretch builds by yxieca · Pull Request #2035 · sonic-net/sonic-buildimage

yxieca · 2018-09-11T21:55:34Z

Signed-off-by: Ying Xie [email protected]

- What I did
Adding more document for build option KEEP_SLAVE_ON with stretch build environment.

This document change is target to address question in issue #2029.

Signed-off-by: Ying Xie <[email protected]>

jleveque · 2018-09-12T01:51:26Z

Makefile.work

 #  * PASSWORD: Desired password -- default at rules/config
 #  * KEEP_SLAVE_ON: Keeps slave container up after building-process concludes.
+#  *                Please note that with current stretch build structure,
+#  *                user of KEEP_SLAVE_ON feature will have to be concious


Typo: "conscious"

Thanks, changed now.

jleveque · 2018-09-12T01:52:20Z

Makefile.work

+#  *                - If user desire to stay on stretch docker, please issue
+#  *                  make KEEP_SLAVE_ON=yes stretch
+#  *                - If user desire to stay on jessie docker, please issue
+#  *                  (a susccessful "make stretch" may needed before following)


Typo: "successful"

Thanks, changed now.

jleveque · 2018-09-12T01:52:35Z

Makefile.work

+#  *                about which docker to stay on.
+#  *                - If user desire to stay on stretch docker, please issue
+#  *                  make KEEP_SLAVE_ON=yes stretch
+#  *                - If user desire to stay on jessie docker, please issue


desire -> desires

Also, maybe it should read, "If user desires to keep the Jessie Docker running, please issue..."

Thanks, changed now.

jleveque · 2018-09-12T01:52:46Z

Makefile.work

+#  *                Please note that with current stretch build structure,
+#  *                user of KEEP_SLAVE_ON feature will have to be concious
+#  *                about which docker to stay on.
+#  *                - If user desire to stay on stretch docker, please issue


desire -> desires

Also, maybe it should read, "If user desires to keep the Stretch Docker running, please issue..."

Thanks, changed now.

jleveque · 2018-09-12T01:54:17Z

Makefile.work

 #  * KEEP_SLAVE_ON: Keeps slave container up after building-process concludes.
+#  *                Please note that with current stretch build structure,
+#  *                user of KEEP_SLAVE_ON feature will have to be concious
+#  *                about which docker to stay on.


Maybe we should say "stay running" to coincide with Docker terminology instead of "stay on"?

Thanks, changed now.

bb0733a [aclorch] Add ACL_TABLE_TYPE configuration (sonic-net#1982) 59cab5d Support for setting switch level DSCP to TC QoS map (sonic-net#2023) da21172 [aclorch] add generic AclOrch::updateAclRule() method (sonic-net#1993) 4f6cb05 [Reclaiming buffer] Support reclaiming buffer in traditional model (sonic-net#2011) 32d7a69 [Reclaiming buffer] Common code update (sonic-net#1996) b91d8ba [swss] L2 Forwarding Enhancements (sonic-net#1716) 797dab4 [muxorch] Bind all ports to drop ACL table (sonic-net#2027) 99929cd [lgtm.yml] add libgmock-dev (sonic-net#2035) 8727ae5 [flex counter] Flex counter threads consume too much CPU resources sonic-net#9202 (sonic-net#2031) 103fdf0 Remove redundant calls to get child scheduler group during initialization (sonic-net#1965) 18ea840 [macsec]: MACsec statistics support (sonic-net#1867) 0c46242 [orchagent] Flush pipeline every 1 second, not only when select will timeout (sonic-net#2003) 339101c [cbf] Add class-based forwarding support (sonic-net#1963) 24a615b Fix issue: accumulative headroom can exceed limit in rare scenario (sonic-net#2020) 708e232 Test divide by zero processing path (sonic-net#2028) 8f1d035 [macsecmgr]: Wait for port up before enabling macsec (sonic-net#2032) 4912a77 Remove buffer drop counter when port is removed (sonic-net#1860) f9462c4 [Dynamic buffer] [Mellanox] Calculate the peer response time according to the speed (sonic-net#1930) 8b5a401 Routed subinterface enhancements (sonic-net#2017) cdea5e9 Fix next hop compilation (sonic-net#2025) 37c197d [SRV6] Sonic-swss changes for SRV6 (sonic-net#1964) f502c32 [vnetorch] Add ECMP support for vnet tunnel routes (sonic-net#1960) Signed-off-by: Stephen Sun <[email protected]>

bb0733a [aclorch] Add ACL_TABLE_TYPE configuration (#1982) 59cab5d Support for setting switch level DSCP to TC QoS map (#2023) da21172 [aclorch] add generic AclOrch::updateAclRule() method (#1993) 4f6cb05 [Reclaiming buffer] Support reclaiming buffer in traditional model (#2011) 32d7a69 [Reclaiming buffer] Common code update (#1996) b91d8ba [swss] L2 Forwarding Enhancements (#1716) 797dab4 [muxorch] Bind all ports to drop ACL table (#2027) 99929cd [lgtm.yml] add libgmock-dev (#2035) 8727ae5 [flex counter] Flex counter threads consume too much CPU resources #9202 (#2031) 103fdf0 Remove redundant calls to get child scheduler group during initialization (#1965) 18ea840 [macsec]: MACsec statistics support (#1867) 0c46242 [orchagent] Flush pipeline every 1 second, not only when select will timeout (#2003) 339101c [cbf] Add class-based forwarding support (#1963) 24a615b Fix issue: accumulative headroom can exceed limit in rare scenario (#2020) 708e232 Test divide by zero processing path (#2028) 8f1d035 [macsecmgr]: Wait for port up before enabling macsec (#2032) 4912a77 Remove buffer drop counter when port is removed (#1860) f9462c4 [Dynamic buffer] [Mellanox] Calculate the peer response time according to the speed (#1930) 8b5a401 Routed subinterface enhancements (#2017) cdea5e9 Fix next hop compilation (#2025) 37c197d [SRV6] Sonic-swss changes for SRV6 (#1964) f502c32 [vnetorch] Add ECMP support for vnet tunnel routes (#1960) Signed-off-by: Stephen Sun <[email protected]>

sonic-swss 1aa40f7 Remove port serdes object before removing port (#2152) 876d690 [doc] Updating Policer config in Configuration manual (#2144) sonic-utilities dfed952 show_platfom_info not run for simx (#2042) 71fdee7 [aclshow] fix aclshow when clear is called before counters are populated (#2037) a48a027 [sonic-package-manager] implement blocking feature state change (#2035) c51871d [ci] Fix python dependencies reference path. (#2060)

``` Commits on Jan 31, 2022 [sonic-package-manager] implement blocking feature state change (#2035) Commits on Feb 12, 2022 [ci] pipeline fixes for VS test (#2059) Commits on Feb 14, 2022 [ci] allow download partially succeeded suilds for sonic-swss-pytests… [build] allowPartiallySucceededBuilds true in the step of download so… Commits on Feb 16, 2022 [config] Fix snmpagentaddress doesn't support the uppercase letters f… Commits on Feb 17, 2022 [ci] Fix pipeline on build_and_install_module (#2074) Enable diff coverage and set the threshold to 50% (#2061) Commits on Feb 18, 2022 check for adding default vlan attempt added (#2075) [GCU] Adding unit-test where path and ref paths are under the same YA… [GCU] Turning port admin down before some critical port changes (#1998) Commits on Feb 20, 2022 show_platfom_info not run for simx (#2042) [aclshow] fix aclshow when clear is called before counters are popula… ```

…c-net#2035) Signed-off-by: Stepan Blyschak [email protected] Motivation for this change is to handle the TODO: # TODO: Replace with "config feature" command. # The problem with current "config feature" command # is that it is asynchronous, thus can't be used # for package upgrade purposes where we need to wait # till service stops before upgrading docker image. # It would be really handy if we could just call # something like: "config feature state <name> <state> --wait" # instead of operating on systemd service since # this is basically a duplicated code from "hostcfgd". What I did Implement blocking feature state change for CLI command and sonic-package-manager. How I did it Implemented a wait loop that blocks till feature reaches desired state. How to verify it Run UT, run on switch.

[make file] add document for KEEP_SLAVE_ON with stretch builds

1f02601

Signed-off-by: Ying Xie <[email protected]>

yxieca self-assigned this Sep 11, 2018

yxieca added the Enhancement ➕ label Sep 11, 2018

yxieca requested review from jleveque, lguohan and wendani September 11, 2018 21:57

lguohan approved these changes Sep 12, 2018

View reviewed changes

jleveque suggested changes Sep 12, 2018

View reviewed changes

Update Makefile.work

d41ba86

jleveque approved these changes Sep 12, 2018

View reviewed changes

lguohan merged commit 5d23a43 into sonic-net:master Sep 12, 2018

yxieca deleted the make_doc branch September 12, 2018 21:10

theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022

[lgtm.yml] add libgmock-dev (sonic-net#2035)

99929cd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[make file] add document for KEEP_SLAVE_ON with stretch builds#2035

[make file] add document for KEEP_SLAVE_ON with stretch builds#2035
lguohan merged 2 commits intosonic-net:masterfrom
yxieca:make_doc

yxieca commented Sep 11, 2018

Uh oh!

jleveque Sep 12, 2018

Uh oh!

yxieca Sep 12, 2018

Uh oh!

jleveque Sep 12, 2018

Uh oh!

yxieca Sep 12, 2018

Uh oh!

jleveque Sep 12, 2018

Uh oh!

yxieca Sep 12, 2018

Uh oh!

jleveque Sep 12, 2018

Uh oh!

yxieca Sep 12, 2018

Uh oh!

jleveque Sep 12, 2018

Uh oh!

yxieca Sep 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yxieca commented Sep 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants