Skip to content

[platform/device] - Update sonic-platform-module-cel and device configuration for haliburton #1960

Closed
mudsut4ke wants to merge 23 commits intomasterfrom
unknown repository
Closed

[platform/device] - Update sonic-platform-module-cel and device configuration for haliburton #1960
mudsut4ke wants to merge 23 commits intomasterfrom
unknown repository

Conversation

@mudsut4ke
Copy link
Copy Markdown
Contributor

@mudsut4ke mudsut4ke commented Aug 21, 2018

- What I did

Signed-off-by: Wirut Getbamrung [email protected]

@mudsut4ke mudsut4ke changed the title [platform/device] - Update platform-module-cel and device configuration for haliburton [platform/device] - Update sonic-platform-module-cel and device configuration for haliburton Aug 21, 2018
lguohan
lguohan reviewed Aug 21, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-dx010.init Outdated
echo lm75b 0x4a > /sys/bus/i2c/devices/i2c-7/new_device
echo lm75b 0x48 > /sys/bus/i2c/devices/i2c-14/new_device
echo lm75b 0x4e > /sys/bus/i2c/devices/i2c-15/new_device
echo dx010_lm75b 0x48 > /sys/bus/i2c/devices/i2c-5/new_device
Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can you use original lm75b?

Copy link
Copy Markdown
Contributor Author

@mudsut4ke mudsut4ke Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will review it again.

lguohan
lguohan reviewed Aug 21, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-cel/dx010/modules/dx010-fan-led.c Outdated
@@ -0,0 +1,209 @@
/*
* dx010-fan-led.c - Kernel module for Seastone DX010 fan LEDs
Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fan led control should be left to user space, can you revert this dx010-fan-led change?

Copy link
Copy Markdown
Contributor Author

@mudsut4ke mudsut4ke Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pphuchar Please help to check this one.

Copy link
Copy Markdown
Contributor

@pphuchar pphuchar Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will expose fan led to user-space to control.

Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current ask is just revert this to previous version, we can deal with the user-space fan led control later. Not in this PR.

lguohan
lguohan reviewed Aug 21, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-cel/dx010/modules/lm75.c Outdated
@@ -0,0 +1,553 @@
/*
* lm75.c - Part of lm_sensors, Linux kernel modules for hardware
Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use original lm75 in the kernel, why build your own?

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Aug 21, 2018

please remove binary file. lpc_cpld_x64_64

lguohan
lguohan reviewed Aug 21, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-haliburton.init Outdated
modprobe i2c-mux-pca954x
modprobe smc

(cd /usr/local/etc && ./lpc_cpld_x64_64 blu w 0x222 0x1f)
Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot check-in a binary file.

Copy link
Copy Markdown
Contributor Author

@mudsut4ke mudsut4ke Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our team need to use this tool to reset phy port.
How can I use this tool ?

Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expose the register in your cpld. smc.c driver?

lguohan
lguohan requested changes Aug 21, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Aug 21, 2018

retest this please

lguohan
lguohan reviewed Aug 23, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-cel/debian/platform-modules-haliburton.init Outdated
@@ -16,9 +16,10 @@ start)
echo -n "Setting up board... "

depmod -a
Copy link
Copy Markdown
Collaborator

@lguohan lguohan Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not have depmod -a in the init script, depmod -a should be in the postinst script.

@mudsut4ke mudsut4ke closed this Aug 23, 2018
@mudsut4ke mudsut4ke mentioned this pull request Aug 23, 2018
Merged
@mudsut4ke
Copy link
Copy Markdown
Contributor Author

mudsut4ke commented Aug 23, 2018

Move to #1975

stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Nov 23, 2021
@stephenxs
Advance sonic-swss
aa1d777 
bb0733a [aclorch] Add ACL_TABLE_TYPE configuration  (sonic-net#1982)
59cab5d Support for setting switch level DSCP to TC QoS map (sonic-net#2023)
da21172 [aclorch] add generic AclOrch::updateAclRule() method (sonic-net#1993)
4f6cb05 [Reclaiming buffer] Support reclaiming buffer in traditional model (sonic-net#2011)
32d7a69 [Reclaiming buffer] Common code update (sonic-net#1996)
b91d8ba [swss] L2 Forwarding Enhancements (sonic-net#1716)
797dab4 [muxorch] Bind all ports to drop ACL table (sonic-net#2027)
99929cd [lgtm.yml] add libgmock-dev (sonic-net#2035)
8727ae5 [flex counter] Flex counter threads consume too much CPU resources sonic-net#9202 (sonic-net#2031)
103fdf0 Remove redundant calls to get child scheduler group during initialization (sonic-net#1965)
18ea840 [macsec]: MACsec statistics support (sonic-net#1867)
0c46242 [orchagent] Flush pipeline every 1 second, not only when select will timeout (sonic-net#2003)
339101c [cbf] Add class-based forwarding support (sonic-net#1963)
24a615b Fix issue: accumulative headroom can exceed limit in rare scenario (sonic-net#2020)
708e232 Test divide by zero processing path (sonic-net#2028)
8f1d035 [macsecmgr]: Wait for port up before enabling macsec (sonic-net#2032)
4912a77 Remove buffer drop counter when port is removed (sonic-net#1860)
f9462c4 [Dynamic buffer] [Mellanox] Calculate the peer response time according to the speed (sonic-net#1930)
8b5a401 Routed subinterface enhancements (sonic-net#2017)
cdea5e9 Fix next hop compilation (sonic-net#2025)
37c197d [SRV6] Sonic-swss changes for SRV6 (sonic-net#1964)
f502c32 [vnetorch] Add ECMP support for vnet tunnel routes (sonic-net#1960)

Signed-off-by: Stephen Sun <[email protected]>
liat-grozovik pushed a commit that referenced this pull request Nov 24, 2021
@stephenxs
[sonic-swss] Advance submodule (#9288)
9c4b787 
bb0733a [aclorch] Add ACL_TABLE_TYPE configuration  (#1982)
59cab5d Support for setting switch level DSCP to TC QoS map (#2023)
da21172 [aclorch] add generic AclOrch::updateAclRule() method (#1993)
4f6cb05 [Reclaiming buffer] Support reclaiming buffer in traditional model (#2011)
32d7a69 [Reclaiming buffer] Common code update (#1996)
b91d8ba [swss] L2 Forwarding Enhancements (#1716)
797dab4 [muxorch] Bind all ports to drop ACL table (#2027)
99929cd [lgtm.yml] add libgmock-dev (#2035)
8727ae5 [flex counter] Flex counter threads consume too much CPU resources #9202 (#2031)
103fdf0 Remove redundant calls to get child scheduler group during initialization (#1965)
18ea840 [macsec]: MACsec statistics support (#1867)
0c46242 [orchagent] Flush pipeline every 1 second, not only when select will timeout (#2003)
339101c [cbf] Add class-based forwarding support (#1963)
24a615b Fix issue: accumulative headroom can exceed limit in rare scenario (#2020)
708e232 Test divide by zero processing path (#2028)
8f1d035 [macsecmgr]: Wait for port up before enabling macsec (#2032)
4912a77 Remove buffer drop counter when port is removed (#1860)
f9462c4 [Dynamic buffer] [Mellanox] Calculate the peer response time according to the speed (#1930)
8b5a401 Routed subinterface enhancements (#2017)
cdea5e9 Fix next hop compilation (#2025)
37c197d [SRV6] Sonic-swss changes for SRV6 (#1964)
f502c32 [vnetorch] Add ECMP support for vnet tunnel routes (#1960)

Signed-off-by: Stephen Sun <[email protected]>
@xumia xumia mentioned this pull request Jan 17, 2022
Merged
5 tasks
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@shi-su
[vnetorch] Add ECMP support for vnet tunnel routes (sonic-net#1960)
f502c32 
What I did
Add functions to create/remove next hop groups for vnet tunnel routes.
Count the reference count of next hop groups to create and remove as needed.
Share the counter of next hop groups with routeorch.
Add vs test

Why I did it
To add support for overlay ECMP.

How I verified it
Verify ECMP groups are properly created and removed with the functions.
Verify vs test passes
Staphylo pushed a commit to Staphylo/sonic-buildimage that referenced this pull request Feb 5, 2026
@jianyuewu
[Mellanox] Fix thermal_updater polling interval get issue (sonic-net#…
cd114a8 
…1960)

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
The thermal updater's `load_tc_config` method was unable to correctly
parse tc_config files that use regex-based parameter.

#### How I did it
1. **Added `_find_matching_key` method**: Implements regex pattern
matching to find parameter keys in dictionary.
2. **Updated `load_tc_config` method**:
   - Changed ASIC parameter lookup to use regex pattern `r'asic\\d*'`
- Changed Module parameter lookup to use regex pattern `r'module\\d+'`
 
#### How to verify it
Test in switch, check if corrected parsed.

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [x] 202412
- [x] 202511

#### Tested branch (Please provide the tested image version)
202511

Signed-off-by: Jianyue Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan requested changes

+1 more reviewer

@pphuchar pphuchar pphuchar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Platform: Celestica Submodule Update ⏫

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mudsut4ke @lguohan @pphuchar @stcheng