Skip to content

[docker-orchagent] add -R flag for ring mode in orchagent.sh#19652

Merged
kperumalbfn merged 7 commits intosonic-net:masterfrom
a114j0y:master
Feb 28, 2025
Merged

[docker-orchagent] add -R flag for ring mode in orchagent.sh#19652
kperumalbfn merged 7 commits intosonic-net:masterfrom
a114j0y:master

Conversation

@a114j0y
Copy link
Copy Markdown
Contributor

@a114j0y a114j0y commented Jul 22, 2024

Why I did it

Enable the feature in BGP Loading Optimization HLD #1521 GitHub issue/pull request detail

Work item tracking
  • Microsoft ADO (number only):

How I did it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@a114j0y a114j0y marked this pull request as ready for review February 1, 2025 01:10
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link
Copy Markdown

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RING_BUFFER_CONFIG

seems like a new table in ConfigDB. Could you add it into HLD? Could you add yang model and UT?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a114j0y you can find SONiC yang model and test from https://github.com/sonic-net/sonic-buildimage/tree/master/src/sonic-yang-models/

Seems you need a new yang file for RING_BUFFER_CONFIG.

Copy link
Copy Markdown
Contributor Author

@a114j0y a114j0y Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it into the existing table "DEVICE_METADATA | localhost"

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link
Copy Markdown

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link
Copy Markdown

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link
Copy Markdown

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Feb 24, 2025
…nodes_cisco (#17078)

What is the motivation for this PR?
ring buffer feature should be able to get turned on/off by a flag in configuration

How did you do it?
Add a field "ring_thread_enabled" in "DEVICE_METADATA"| "localhost" table

How did you verify/test it?
sonic-net/sonic-buildimage#19652
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link
Copy Markdown

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kperumalbfn kperumalbfn merged commit 2d7b827 into sonic-net:master Feb 28, 2025
21 checks passed
miatttao pushed a commit to miatttao/sonic-buildimage that referenced this pull request Mar 5, 2025
…et#19652)

[docker-orchagent] add -R flag for ring mode in orchagent.sh
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
…nodes_cisco (sonic-net#17078)

What is the motivation for this PR?
ring buffer feature should be able to get turned on/off by a flag in configuration

How did you do it?
Add a field "ring_thread_enabled" in "DEVICE_METADATA"| "localhost" table

How did you verify/test it?
sonic-net/sonic-buildimage#19652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants