Skip to content

Add "ring_thread_enabled" field in confdb_jsons/7nodes_cisco#17078

Merged
wangxin merged 1 commit intosonic-net:masterfrom
a114j0y:master
Feb 24, 2025
Merged

Add "ring_thread_enabled" field in confdb_jsons/7nodes_cisco#17078
wangxin merged 1 commit intosonic-net:masterfrom
a114j0y:master

Conversation

@a114j0y
Copy link
Copy Markdown
Contributor

@a114j0y a114j0y commented Feb 21, 2025

…nodes_cisco

Description of PR

Summary:
Add a field "ring_thread_enabled" in every node in confdb_jsons/7nodes_cisco to enable ring feature by default in this topology

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

ring buffer feature should be able to get turned on/off by a flag in configuration

How did you do it?

Add a field "ring_thread_enabled" in "DEVICE_METADATA"| "localhost" table

How did you verify/test it?

sonic-net/sonic-buildimage#19652

Any platform specific information?

No

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit d964cb4 into sonic-net:master Feb 24, 2025
17 checks passed
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
…nodes_cisco (sonic-net#17078)

What is the motivation for this PR?
ring buffer feature should be able to get turned on/off by a flag in configuration

How did you do it?
Add a field "ring_thread_enabled" in "DEVICE_METADATA"| "localhost" table

How did you verify/test it?
sonic-net/sonic-buildimage#19652
@Javier-Tan Javier-Tan mentioned this pull request Apr 9, 2025
11 tasks
yejianquan pushed a commit that referenced this pull request Apr 23, 2025
Description of PR
Summary:
Fixes #17078

Approach
What is the motivation for this PR?
Create testcase for cold upgrade for T2

How did you do it?
Add test_upgrade_path_t2 testcase to test_upgrade_path.py based on previous upgrade path tests

How did you verify/test it?
Ran on multiple T2 devices, also ran on T1 warm upgrade to make sure it's not breaking

Any platform specific information?
N/A

Supported testbed topology if it's a new test case?
N/A

Documentation
Please run using variables:

--upgrade_type=cold
--base_image_list=
--target_image_list=
e.g.

sudo ./run_tests.sh -i <INV FILE> -n <TB NAME> -m individual -l INFO -e '--showlocals --assert plain -rav --enable_cpa --upgrade_type=cold --skip_sanity --base_image_list=<FROM IMAGE URL> --target_image_list=<TO IMAGE URL>' -u -c upgrade_path/test_upgrade_path.py::test_upgrade_path_t2

Signed-off-by: Javier Tan javiertan@microsoft.com
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Description of PR
Summary:
Fixes sonic-net#17078

Approach
What is the motivation for this PR?
Create testcase for cold upgrade for T2

How did you do it?
Add test_upgrade_path_t2 testcase to test_upgrade_path.py based on previous upgrade path tests

How did you verify/test it?
Ran on multiple T2 devices, also ran on T1 warm upgrade to make sure it's not breaking

Any platform specific information?
N/A

Supported testbed topology if it's a new test case?
N/A

Documentation
Please run using variables:

--upgrade_type=cold
--base_image_list=
--target_image_list=
e.g.

sudo ./run_tests.sh -i <INV FILE> -n <TB NAME> -m individual -l INFO -e '--showlocals --assert plain -rav --enable_cpa --upgrade_type=cold --skip_sanity --base_image_list=<FROM IMAGE URL> --target_image_list=<TO IMAGE URL>' -u -c upgrade_path/test_upgrade_path.py::test_upgrade_path_t2

Signed-off-by: Javier Tan javiertan@microsoft.com
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Description of PR
Summary:
Fixes sonic-net#17078

Approach
What is the motivation for this PR?
Create testcase for cold upgrade for T2

How did you do it?
Add test_upgrade_path_t2 testcase to test_upgrade_path.py based on previous upgrade path tests

How did you verify/test it?
Ran on multiple T2 devices, also ran on T1 warm upgrade to make sure it's not breaking

Any platform specific information?
N/A

Supported testbed topology if it's a new test case?
N/A

Documentation
Please run using variables:

--upgrade_type=cold
--base_image_list=
--target_image_list=
e.g.

sudo ./run_tests.sh -i <INV FILE> -n <TB NAME> -m individual -l INFO -e '--showlocals --assert plain -rav --enable_cpa --upgrade_type=cold --skip_sanity --base_image_list=<FROM IMAGE URL> --target_image_list=<TO IMAGE URL>' -u -c upgrade_path/test_upgrade_path.py::test_upgrade_path_t2

Signed-off-by: Javier Tan javiertan@microsoft.com
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Description of PR
Summary:
Fixes sonic-net#17078

Approach
What is the motivation for this PR?
Create testcase for cold upgrade for T2

How did you do it?
Add test_upgrade_path_t2 testcase to test_upgrade_path.py based on previous upgrade path tests

How did you verify/test it?
Ran on multiple T2 devices, also ran on T1 warm upgrade to make sure it's not breaking

Any platform specific information?
N/A

Supported testbed topology if it's a new test case?
N/A

Documentation
Please run using variables:

--upgrade_type=cold
--base_image_list=
--target_image_list=
e.g.

sudo ./run_tests.sh -i <INV FILE> -n <TB NAME> -m individual -l INFO -e '--showlocals --assert plain -rav --enable_cpa --upgrade_type=cold --skip_sanity --base_image_list=<FROM IMAGE URL> --target_image_list=<TO IMAGE URL>' -u -c upgrade_path/test_upgrade_path.py::test_upgrade_path_t2

Signed-off-by: Javier Tan javiertan@microsoft.com
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary:
Fixes sonic-net#17078

Approach
What is the motivation for this PR?
Create testcase for cold upgrade for T2

How did you do it?
Add test_upgrade_path_t2 testcase to test_upgrade_path.py based on previous upgrade path tests

How did you verify/test it?
Ran on multiple T2 devices, also ran on T1 warm upgrade to make sure it's not breaking

Any platform specific information?
N/A

Supported testbed topology if it's a new test case?
N/A

Documentation
Please run using variables:

--upgrade_type=cold
--base_image_list=
--target_image_list=
e.g.

sudo ./run_tests.sh -i <INV FILE> -n <TB NAME> -m individual -l INFO -e '--showlocals --assert plain -rav --enable_cpa --upgrade_type=cold --skip_sanity --base_image_list=<FROM IMAGE URL> --target_image_list=<TO IMAGE URL>' -u -c upgrade_path/test_upgrade_path.py::test_upgrade_path_t2

Signed-off-by: Javier Tan javiertan@microsoft.com
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants