BGP Loading Optimization HLD#1521
Conversation
a114j0y
force-pushed
the
master
branch
7 times, most recently
from
59e7d20 to
3d8434c
Compare
qiluo-msft
requested review from
Pterosaur,
kcudnik,
liuh-80,
prsunny,
qiluo-msft and
saiarcot895
|
not reviewed in sonic community yet. |
a114j0y
force-pushed
the
master
branch
2 times, most recently
from
ff8ad44 to
34d6862
Compare
a114j0y
force-pushed
the
master
branch
2 times, most recently
from
05e97a0 to
4ecddec
Compare
a114j0y
force-pushed
the
master
branch
2 times, most recently
from
fc5039a to
127cb07
Compare
a114j0y
force-pushed
the
master
branch
6 times, most recently
from
3eb70ac to
f4a58af
Compare
|
Community review recording https://zoom.us/rec/share/PkNNRipPYi-z2Q0nkK_FCoFWqXk5oQcQYkNvitanIaWkWw98VXYkdE1SYnSAvQTD.tkZEa9zzBzHlex3c |
|
Question: is there sufficient test coverage (unit or integration) to make sure that the ring buffer is drained during warm shutdown? |
|
Suggestion: can you separate the lambda function enhancement itself in a separate PR and the other performance improvement code in another PR? |
I have already separated fpmsyncd / orchagent enhancement into two PRs. The lambda function is the type of ring entries, so kind of bound with the ring buffer PR. Without lambda, it would be a different implementation and much code change. But might help understand the codes…Do you still think we need to do this？ |
|
HLD PR and two code PRs are not merged yet, move to backlog |
|
@qiluo-msft @prsunny all code PRs are merged. Should we merge this HLD as well? |
eddieruan-alibaba
left a comment
eddieruan-alibaba
left a comment
There was a problem hiding this comment.
All PRs are merged
|
@qiluo-msft can we merge this PR? All code PRs are merged |
|
/azp run |
|
No pipelines are associated with this pull request. |
9 participants
This HLD introduces how we increases the end-to-end BGP loading speed of SONiC by 50%