Rename the leaf nodes to lower case.#18704
Merged
qiluo-msft merged 8 commits intosonic-net:masterfrom Apr 26, 2024
Merged
Conversation
Contributor
|
This PR is making the column names in portconfig.ini consistent with yang models |
arlakshm
added
the
Chassis for 202205 branch
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Apr 26, 2024
11 tasks
This was referenced May 3, 2024
arlakshm
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
May 6, 2024
…12719) In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed: - # name lanes alias index role speed asic_port_name coreId corePortId numVoq + # name lanes alias index role speed asic_port_name core_id core_port_id num_voq But port_alias.py depends on the header names and wasn't updated: ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed', 'coreid', 'coreportid', 'numvoq'] This PR updates port_alias.py to account for the port_config.ini change. Summary: Fixes #12718 Type of change
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
### Why I did it Consolidate the `numvoq`, `coreid`, `coreportid` to be lower case which matches other leaf node convention. ### How I did it Rename to lower case. #### How to verify it No need to verify.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 20, 2024
…onic-net#12719) In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed: - # name lanes alias index role speed asic_port_name coreId corePortId numVoq + # name lanes alias index role speed asic_port_name core_id core_port_id num_voq But port_alias.py depends on the header names and wasn't updated: ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed', 'coreid', 'coreportid', 'numvoq'] This PR updates port_alias.py to account for the port_config.ini change. Summary: Fixes sonic-net#12718 Type of change
mssonicbld
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jun 20, 2024
…12719) In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed: - # name lanes alias index role speed asic_port_name coreId corePortId numVoq + # name lanes alias index role speed asic_port_name core_id core_port_id num_voq But port_alias.py depends on the header names and wasn't updated: ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed', 'coreid', 'coreportid', 'numvoq'] This PR updates port_alias.py to account for the port_config.ini change. Summary: Fixes #12718 Type of change
Collaborator
|
@arlakshm Can we get this PR cherry-picked to 202205 ASAP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Consolidate the
numvoq,coreid,coreportidto be lower case which matches other leaf node convention.Work item tracking
How I did it
Rename to lower case.
How to verify it
No need to verify.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)