port_alias.py: Handle port_config.ini header change#12719
Merged
arlakshm merged 1 commit intosonic-net:masterfrom May 6, 2024
Merged
port_alias.py: Handle port_config.ini header change#12719arlakshm merged 1 commit intosonic-net:masterfrom
arlakshm merged 1 commit intosonic-net:masterfrom
Conversation
xincunli-sonic
approved these changes
May 3, 2024
arlakshm
approved these changes
May 3, 2024
Contributor
|
@wangxin @StormLiangMS could you help merge this in 202205, this PR is needed without which the swss/syncd crashes for sonic-mgmt test/pipeline runs |
Contributor
|
pinged @StormLiangMS |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 20, 2024
…onic-net#12719) In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed: - # name lanes alias index role speed asic_port_name coreId corePortId numVoq + # name lanes alias index role speed asic_port_name core_id core_port_id num_voq But port_alias.py depends on the header names and wasn't updated: ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed', 'coreid', 'coreportid', 'numvoq'] This PR updates port_alias.py to account for the port_config.ini change. Summary: Fixes sonic-net#12718 Type of change
Collaborator
|
Cherry-pick PR to 202205: #13374 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 20, 2024
…12719) In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed: - # name lanes alias index role speed asic_port_name coreId corePortId numVoq + # name lanes alias index role speed asic_port_name core_id core_port_id num_voq But port_alias.py depends on the header names and wasn't updated: ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed', 'coreid', 'coreportid', 'numvoq'] This PR updates port_alias.py to account for the port_config.ini change. Summary: Fixes #12718 Type of change
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed:
But port_alias.py depends on the header names and wasn't updated:
This PR updates port_alias.py to account for the port_config.ini change.
Summary:
Fixes #12718
Type of change
[x] Bug fix