[VOQ] Fix the parsing of core_port_id and core_id for Inband and Recirc Port.#19755
Merged
kperumalbfn merged 34 commits intosonic-net:masterfrom Aug 1, 2024
Merged
[VOQ] Fix the parsing of core_port_id and core_id for Inband and Recirc Port.#19755kperumalbfn merged 34 commits intosonic-net:masterfrom
kperumalbfn merged 34 commits intosonic-net:masterfrom
Conversation
peer device's Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
higher value so that BGP learnt default route is higher priority. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
save as `slice_type` as part of DEVICE_METADATA Signed-off-by: Abhishek Dosi <[email protected]>
…graph and" This reverts commit 0f2d26d.
save as `slice_type` as part of DEVICE_METADATA for Chassis Device type Signed-off-by: Abhishek Dosi <[email protected]>
pmon need to enable asap to detect ASIC's on Supervisor. pmonm need to enable asap for bring-up of 400G ports on LC's fast becuase of CMIS state machine present in PMON. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Inband and Recirc Port was not done correctlly. Also fixed the UT Signed-off-by: Abhishek Dosi <[email protected]>
gechiang
approved these changes
Jul 31, 2024
kperumalbfn
approved these changes
Aug 1, 2024
Collaborator
|
NOTE; this change will not be backported to any older releases other than 202405 per dicussion with @abdosi. Just capturing here so we know we did discuss about it. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 2, 2024
…rc Port. (sonic-net#19755) [VOQ] Fix the parsing of core_port_id and core_id for Inband and Recirc Port. Signed-off-by: Abhishek Dosi <[email protected]>
Collaborator
|
Cherry-pick PR to 202405: #19782 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2024
…rc Port. (#19755) [VOQ] Fix the parsing of core_port_id and core_id for Inband and Recirc Port. Signed-off-by: Abhishek Dosi <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
After the PR: #18704 parsing for
core_port_idandcore_idfor Inband and Recicrc Port needs updates otherwise value of these 2 fields comes asNonecasuing SAI not configure this ports correctly and also yang validation failure.Microsoft ADO: 28897483
How I verify:
This issue could have been caught via but UT also had bug. Fixed the UT also.
Manual verified the change for SAI and Yang Validation