Skip to content

Enable sairedis counter thread in 3 minutes after SONiC was started#1813

Merged
lguohan merged 2 commits intosonic-net:201803from
pavel-shirshov:pavelsh/counter_after
Jun 26, 2018
Merged

Enable sairedis counter thread in 3 minutes after SONiC was started#1813
lguohan merged 2 commits intosonic-net:201803from
pavel-shirshov:pavelsh/counter_after

Conversation

@pavel-shirshov
Copy link
Contributor

- What I did
Downport PR #1805 to 201803 branch

- How I did it
Manually copying files

- How to verify it
Build an image and test it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)


[Service]
Type=oneshot
ExecStart=/usr/bin/counterpoll queue enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable counters for all types, including queue, port and pfcwd?
with /usr/bin/counterpoll queue enable /usr/bin/counterpoll port enable, /usr/bin/pfcwd counter_poll enable?
The latter pfcwd counter requires following to be taken into build image

sonic-net/sonic-swss@72a7f3a

sonic-net/sonic-utilities#273

Copy link
Contributor Author

@pavel-shirshov pavel-shirshov Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I created PR #1814 for master branch. After we test it in the master I'll update this PR

@lguohan lguohan merged commit 6568203 into sonic-net:201803 Jun 26, 2018
tiantianlv pushed a commit to tiantianlv/sonic-buildimage that referenced this pull request Jul 30, 2018
qiluo-msft pushed a commit that referenced this pull request Jul 13, 2021
#### Why I did it
Update submodule pointer for swss to include recent changes

4f1d726 [portsorch] fix errors when moving port from one lag to another. (#1797)
ae44701 [orchagent] Put port configuration to APPL_DB according to autoneg mode (#1769)
5295f91 Add failure handling for SAI get operations (#1768)
7c7c451 Revert recirc port change (#1813)
5528ebf Cleanup code (#1814)
judyjoseph pushed a commit that referenced this pull request Aug 7, 2021
#### Why I did it
Update submodule pointer for swss to include recent changes

4f1d726 [portsorch] fix errors when moving port from one lag to another. (#1797)
ae44701 [orchagent] Put port configuration to APPL_DB according to autoneg mode (#1769)
5295f91 Add failure handling for SAI get operations (#1768)
7c7c451 Revert recirc port change (#1813)
5528ebf Cleanup code (#1814)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
#### Why I did it
Update submodule pointer for swss to include recent changes

4f1d726 [portsorch] fix errors when moving port from one lag to another. (sonic-net#1797)
ae44701 [orchagent] Put port configuration to APPL_DB according to autoneg mode (sonic-net#1769)
5295f91 Add failure handling for SAI get operations (sonic-net#1768)
7c7c451 Revert recirc port change (sonic-net#1813)
5528ebf Cleanup code (sonic-net#1814)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
Recirc port support has been added to recent versions of DNX SAI.
The earlier special handling for recirc port is not required anymore
and thus reverted.
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 16, 2022
linkmgrrd:
* d6518dd 2022-06-14 | Fix IP header checksum in handleSendSwitchCommand (sonic-net#88) (HEAD -> 202205, github/202205) [Jing Zhang]

swss:
* 4430445 2022-06-03 | Add port counter sanity check (sonic-net#2300) (HEAD -> 202205, github/202205) [Junhua Zhai]
* 01b017c 2022-05-28 | [counter] Support gearbox counters (sonic-net#2218) [Junhua Zhai]

utilities:
* ce96543 2022-05-26 | [subinterface]Avoid removing the subinterface when last configured ip is removed (sonic-net#2181) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* ed97c6f 2022-05-26 | [subinterface] Fix route add command to accept subinterface as dev (sonic-net#2180) [Sudharsan Dhamal Gopalarathnam]
* 53ff644 2022-06-09 | [gendump] Add Support to dump BCM-DNX commands (sonic-net#1813) [saksarav-nokia]
* 0e31790 2022-06-15 | [config][muxcable] fix minor config DB logic issue (sonic-net#2210) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Jun 16, 2022
linkmgrrd:
* d6518dd 2022-06-14 | Fix IP header checksum in handleSendSwitchCommand (#88) (HEAD -> 202205, github/202205) [Jing Zhang]

swss:
* 4430445 2022-06-03 | Add port counter sanity check (#2300) (HEAD -> 202205, github/202205) [Junhua Zhai]
* 01b017c 2022-05-28 | [counter] Support gearbox counters (#2218) [Junhua Zhai]

utilities:
* ce96543 2022-05-26 | [subinterface]Avoid removing the subinterface when last configured ip is removed (#2181) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* ed97c6f 2022-05-26 | [subinterface] Fix route add command to accept subinterface as dev (#2180) [Sudharsan Dhamal Gopalarathnam]
* 53ff644 2022-06-09 | [gendump] Add Support to dump BCM-DNX commands (#1813) [saksarav-nokia]
* 0e31790 2022-06-15 | [config][muxcable] fix minor config DB logic issue (#2210) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
wen587 pushed a commit that referenced this pull request Jun 22, 2022
05c79ef Fix header for the output table following 'show ipv6 interface' command (#2219)
fc5633f increase coverage to 80% (#2214)
c0dffba [config][muxcable] fix minor config DB logic issue (#2210)
a50eca0 [generic-config-updater] Add NTP validator  (#2212)
a3d1345 [gendump] Add Support to dump BCM-DNX commands (#1813)
bb185d5 [yang] remove mistakenly added parameter for 'get_module_name' (#2193)
2cccf26 [counters] skip showing counters that are not enabled (#2199)
ff05bc8 [config][muxcable] Add support for displaying soc_ipv4 and cable_type in config/show muxcable commands (#2189)
3197f39 Add check to not allow deleting PO if its member of vlan. (#2141)
2513da1 [dump] Optimized dump state cli and modified tests to not use common data  (#2175)
9e310e5 Fix sonic-installer and 'show version' command crash when database docker not running issue. (#2183)
4ad70b9 [sonic-installer] use host docker startup arguments when running dockerd in chroot  (#2179)
3d3c89b fix for non-coherent cmis modules (#2163)
2054680 [subinterface] Fix route add command to accept subinterface as dev (#2180)
5383e92 [subinterface]Avoid removing the subinterface when last configured ip is removed (#2181)
f5af780 [GCU] Handling type1 lists (#2171)
4516179 [yang] extend ConfigMgmt constructor to pass YANG options (#2118)
2f53bd4 [dump] implement ACL modules (#2153)
494dd62 show commands for SYSTEM READY (#1851)
4fc09b1 [GCU] Handling non-compliant leaf-list with string values (#2174)
675c7b6 Add sonic-delayed.target to Application Extension .timer file generator (#2176)
c587933 [portconfig] Allow to configure interface mtu for physical ports only
9881f3e Broadcast Unknown-multicast and Unknown-unicast Storm-control  (#928)
88286cb sonic-utils: initial support for link-training (#2071)
vadymhlushko-mlnx pushed a commit to vadymhlushko-mlnx/sonic-buildimage that referenced this pull request Nov 11, 2022
In generate_dump script, the function collect_broadcom tries to dump BCM XGS commands
even in DNX switchs and error message is printed, hence generate_dump command fails.
Modified the collect_broadcom function to check for BCM family and dump
the DNX commands if the family is DNX.

Signed-off-by: Sakthivadivu Saravanaraj [email protected]

What I did
Modified the generate_dump script to dump the corresponding Broadcom diag shell commands based on Broadcom asic family.

How I did it
Modified the collect_broadcom function in generate_dump to get the Broadcom asic family by extracting the "version" command output as per Broadcom's suggestion and dump the Broadcom DNX commands if the Broadcom asic is DNX family.
If it is not DNX family, dump the existing XGS commands.

How to verify it
Ran sonic cli command "sudo generate_dump " in DNX platform and XGS platform and verified that the tgz files are created with all the information dumped by generate_dump script.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
noaOrMlnx pushed a commit to noaOrMlnx/sonic-buildimage that referenced this pull request Nov 24, 2025
…tomatically (sonic-net#1813)

#### Why I did it
src/sonic-gnmi
```
* 22b7767 - (HEAD -> 202412, origin/202412) [202412] Code sync sonic-net/sonic-gnmi:202411 => 202412 (sonic-net#145) (23 hours ago) [Riff]
* 057765a - Merge remote-tracking branch 'base/202411' into code-sync-202412 (5 days ago) [r12f]
* d044158 - Merge pull request sonic-net#417 from FengPan-Frank/temptest (sonic-net#535) (13 days ago) [Zain Budhwani]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants