[Mellanox] Use sysfs for sfp reset/LPM/presence#14130
Merged
liat-grozovik merged 5 commits intosonic-net:masterfrom May 24, 2023
Merged
[Mellanox] Use sysfs for sfp reset/LPM/presence#14130liat-grozovik merged 5 commits intosonic-net:masterfrom
liat-grozovik merged 5 commits intosonic-net:masterfrom
Conversation
Collaborator
Author
|
Depending on new SDK/FW |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
May 5, 2023
prgeor
approved these changes
May 10, 2023
liat-grozovik
approved these changes
May 24, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 25, 2023
- Why I did it The current implementation of SFP reset, LPM, present relies on SDK API. This PR moves the implementation to SDK sysfs. By this PR, it gains following benefit: 1. SDK sysfs provides better performance. 2. Host side and container side share the same code. 3. Code is much cleaner. - How I did it Use SDK sysfs to implement SFP reset, LPM, present. - How to verify it 1. Manual test. 2. Unit test.
Collaborator
|
Cherry-pick PR to 202211: #15215 |
This was referenced Jun 8, 2023
6 tasks
keboliu
added a commit
to keboliu/sonic-buildimage
that referenced
this pull request
Nov 2, 2023
)" This reverts commit 18cf719.
11 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Nov 27, 2023
- Why I did it The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status. - How I did it Revert the recent changes related to LPM in PR #14130 and #16545 - How to verify it Run all sfputil and SFP platform API related tests on all the Mellanox platforms. Signed-off-by: Kebo Liu <kebol@nvidia.com>
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 30, 2023
- Why I did it The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status. - How I did it Revert the recent changes related to LPM in PR sonic-net#14130 and sonic-net#16545 - How to verify it Run all sfputil and SFP platform API related tests on all the Mellanox platforms. Signed-off-by: Kebo Liu <kebol@nvidia.com>
yxieca
pushed a commit
that referenced
this pull request
Dec 4, 2023
- Why I did it The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status. - How I did it Revert the recent changes related to LPM in PR #14130 and #16545 - How to verify it Run all sfputil and SFP platform API related tests on all the Mellanox platforms. Signed-off-by: Kebo Liu <kebol@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on new Nvidia SDK/FW #15072, please don't merge until new SDK/FW merge.
Why I did it
The current implementation of SFP reset, LPM, present relies on SDK API. This PR moves the implementation to SDK sysfs. By this PR, it gains following benefit:
How I did it
Use SDK sysfs to implement SFP reset, LPM, present.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)