Skip to content

[Nvidia] Update lpmode tests#29

Closed
JibinBao wants to merge 1 commit intomasterfrom
b_change_lpmode_tests
Closed

[Nvidia] Update lpmode tests#29
JibinBao wants to merge 1 commit intomasterfrom
b_change_lpmode_tests

Conversation

@JibinBao
Copy link
Copy Markdown
Owner

@JibinBao JibinBao commented Jun 8, 2023

Description of PR

Update lpmode tests

  1. Update lpmode tests due to the design change for Nvidia devices: [Mellanox] Use sysfs for sfp reset/LPM/presence sonic-net/sonic-buildimage#14130
    a) For Nvidia devices, before setting lpmode we need to shutdown admin ports
    b) Add one step to check when setting lpmode to enabled with admin port up, lpmode is still off and port is still up.
  2. Fix issue of test_check_sfputil_low_power_mode. Previously after setting the lpmode, test checks the value is on or off, which is not correct. we should check if the value of lpmode is the set one.
  3. Optimize test of test_check_sfputil_low_power_mode, reduce time for looking up if port supports lpmode. Previously it was needed to look up two times, currently only one time.
  4. Fix test issue for functions of links_status_down and links_status_up by stripping the space for every output

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Update lpmode tests due to desgin change for Nvidia platform

How did you do it?

Update regarding tests according to the design

How did you verify/test it?

Run tests regarding lpmode on the image including new desgin

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Any

Documentation

@JibinBao JibinBao force-pushed the b_change_lpmode_tests branch from 3d9305c to 9b65870 Compare June 9, 2023 05:49
@JibinBao
Copy link
Copy Markdown
Owner Author

JibinBao commented Jun 9, 2023

Open PR

@JibinBao JibinBao closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant