[Mellanox] Update lpmode tests#8556
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jun 14, 2023
Merged
Conversation
Junchao-Mellanox
approved these changes
Jun 12, 2023
liat-grozovik
changed the title
liat-grozovik
approved these changes
Jun 14, 2023
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Sep 28, 2023
Cherry-pick #8556 from master to 202205 1. Update lpmode tests due to the design change for Nvidia devices: a) For Nvidia devices, before setting lpmode we need to shutdown admin ports b) Add one step to check when setting lpmode to enabled with admin port up, lpmode is still off and port is still up. 2. Fix issue of test_check_sfputil_low_power_mode. Previously after setting the lpmode, test checks the value is on or off, which is not correct. we should check if the value of lpmode is the set one. 3. Optimize test of test_check_sfputil_low_power_mode, reduce time for looking up if port supports lpmode. Previously it was needed to look up two times, currently only one time. 4. Fix test issue for functions of links_status_down and links_status_up by stripping the space for every output
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
Update lpmode tests 1, Update lpmode tests due to the design change for Nvidia devices: [Mellanox] Use sysfs for sfp reset/LPM/presence sonic-buildimage#14130 a) For Nvidia devices, before setting lpmode we need to shutdown admin ports b) Add one step to check when setting lpmode to enabled with admin port up, lpmode is still off and port is still up. 2. Fix issue of test_check_sfputil_low_power_mode. Previously after setting the lpmode, test checks the value is on or off, which is not correct. we should check if the value of lpmode is the set one. 3. Optimize test of test_check_sfputil_low_power_mode, reduce time for looking up if port supports lpmode. Previously it was needed to look up two times, currently only one time. 4. Fix test issue for functions of links_status_down and links_status_up by stripping the space for every output
Collaborator
|
@JibinBao PR conflicts with 202305 branch |
Contributor
Author
|
will fix it. and open one new PR for 202305 |
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Nov 30, 2023
This reverts commit e01f135.
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Nov 30, 2023
This reverts commit e01f135.
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Update lpmode tests 1, Update lpmode tests due to the design change for Nvidia devices: [Mellanox] Use sysfs for sfp reset/LPM/presence sonic-buildimage#14130 a) For Nvidia devices, before setting lpmode we need to shutdown admin ports b) Add one step to check when setting lpmode to enabled with admin port up, lpmode is still off and port is still up. 2. Fix issue of test_check_sfputil_low_power_mode. Previously after setting the lpmode, test checks the value is on or off, which is not correct. we should check if the value of lpmode is the set one. 3. Optimize test of test_check_sfputil_low_power_mode, reduce time for looking up if port supports lpmode. Previously it was needed to look up two times, currently only one time. 4. Fix test issue for functions of links_status_down and links_status_up by stripping the space for every output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update lpmode tests
a) For Nvidia devices, before setting lpmode we need to shutdown admin ports
b) Add one step to check when setting lpmode to enabled with admin port up, lpmode is still off and port is still up.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update lpmode tests due to desgin change for Nvidia platform
How did you do it?
Update regarding tests according to the design
How did you verify/test it?
Run tests regarding lpmode on the image including new desgin
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Any
Documentation