[build] Fix unexpected warnings: No names found, cannot describe anything.#12963
Merged
xumia merged 1 commit intosonic-net:masterfrom Dec 20, 2022
Merged
Conversation
liushilongbuaa
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Collaborator
|
can you give details, what is the reason for the errors, why the patch fixed the problem? |
Contributor
Author
|
Contributor
Author
|
':=' will calculate SONiC Version on the first reference. |
xumia
approved these changes
Dec 20, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 21, 2022
…hing. (sonic-net#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 21, 2022
…hing. (sonic-net#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
Collaborator
|
Cherry-pick PR to 202211: #13133 |
Collaborator
|
Cherry-pick PR to 202205: #13134 |
mssonicbld
added a commit
that referenced
this pull request
Dec 21, 2022
mssonicbld
pushed a commit
that referenced
this pull request
Dec 22, 2022
…hing. (#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
mssonicbld
added
Included in 202211 Branch
and removed
Request for 202211 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 22, 2023
…hing. (sonic-net#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 22, 2023
…hing. (sonic-net#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
Collaborator
|
Cherry-pick PR to 202106: #13927 |
Collaborator
|
Cherry-pick PR to 202111: #13928 |
mssonicbld
added a commit
that referenced
this pull request
Feb 22, 2023
mssonicbld
added
Included in 202106 Branch
and removed
Approved for 202106 Branch
Created PR to 202106 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Mar 10, 2023
…hing. (#12963) Why I did it In PR check pipelines, there are too many duplicated warnings: fatal: No names found, cannot describe anything. SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it. In Makefile, '=' will calculate again and again when it is referred. How I did it Fix it in Makefile. How to verify it Check this PR's check pipeline result.
mssonicbld
added
Included in 202111 Branch
and removed
Created PR to 202111 Branch
Approved for 202111 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
In PR check pipelines, there are too many duplicated warnings:
fatal: No names found, cannot describe anything.
SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it.
In Makefile, '=' will calculate again and again when it is referred.
How I did it
Fix it in Makefile.
How to verify it
Check this PR's check pipeline result.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)