[build] fix CI warnings issued by "git describe"#13098
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 3, 2023
Merged
[build] fix CI warnings issued by "git describe"#13098lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
guillaumelambert
force-pushed
the
shallow
branch
from
980ba8d to
31f9b28
Compare
./functions.sh script contains twice the command "git describe --tags". Azure pipelines currently retrieves the repository content by using a "git clone" or "git fetch" command with the option "--depth". When the depth is not enough sized to reach a tag in the "git log" history, "git describe --tags" generates on stderr the warning: "fatal: No names found, cannot describe anything." https://stackoverflow.com/questions/4916492/git-describe-fails-with-fatal-no-names-found-cannot-describe-anything During the build process, the functions.sh script is a lot consumed and this pointless warning appears in CI thousand lines w/o any added value. This situation can be easily avoided by redirecting related commands stderr output to /dev/null. Signed-off-by: Guillaume Lambert <[email protected]>
guillaumelambert
force-pushed
the
shallow
branch
from
31f9b28 to
5c544e2
Compare
Collaborator
|
@xumia , any concern here? changes lgtm. |
lguohan
approved these changes
Dec 20, 2022
xumia
approved these changes
Dec 21, 2022
Collaborator
|
Shilong fixed the git describe issue in another PR: #12963, but the change looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./functions.sh script contains twice the command "git describe --tags". Azure pipelines currently retrieves the repository content by using a "git clone" or "git fetch" command with the option "--depth". When the depth is not enough sized to reach a tag in the "git log" history, "git describe --tags" generates on stderr the warning: "fatal: No names found, cannot describe anything."
https://stackoverflow.com/questions/4916492/git-describe-fails-with-fatal-no-names-found-cannot-describe-anything
During the build process, the functions.sh script is a lot consumed and this pointless warning appears in CI thousand lines w/o any added value.
This situation can be easily avoided by redirecting related commands stderr output to /dev/null.
Issue #13106
Which release branch to backport (provide reason below if selected)
all
Description for the changelog
[build] fix CI warnings issued by "git describe"
A picture of a cute animal (not mandatory but encouraged)
//
('>
/rr
*))_