Skip to content

[action] [PR:12963] [build] Fix unexpected warnings: No names found, cannot describe anything.#13133

Merged
mssonicbld merged 1 commit intosonic-net:202211from
mssonicbld:cherry/202211/12963
Dec 22, 2022
Merged

[action] [PR:12963] [build] Fix unexpected warnings: No names found, cannot describe anything.#13133
mssonicbld merged 1 commit intosonic-net:202211from
mssonicbld:cherry/202211/12963

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

No description provided.

…hing. (sonic-net#12963)

Why I did it
In PR check pipelines, there are too many duplicated warnings:
fatal: No names found, cannot describe anything.
SONIC_IMAGE_VERSION will not change in one build. We don't need to calculate in every reference. We just need calculate one time, then record it.
In Makefile, '=' will calculate again and again when it is referred.

How I did it
Fix it in Makefile.

How to verify it
Check this PR's check pipeline result.
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #12963

@liushilongbuaa
Copy link
Copy Markdown
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 13133 in repo sonic-net/sonic-buildimage

@liushilongbuaa
Copy link
Copy Markdown
Contributor

/azpw run Azure.sonic-buildimage

@xumia
Copy link
Copy Markdown
Collaborator

xumia commented Dec 22, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit ac904ce into sonic-net:202211 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants