[BGP] support BGP pending FIB suppression by stepanblyschak · Pull Request #12853 · sonic-net/sonic-buildimage

stepanblyschak · 2022-11-28T13:03:12Z

Signed-off-by: Stepan Blyschak [email protected]

DEPENDS: #12852

Why I did it

To support BGP pending FIB suppression.

How I did it

I backported patches from FRR 8.4 feature that allows communicating ASIC route status back to FRR.
Also, added a new field in DEVICE_METADATA YANG model table. Added UT for YANG model changes.

How to verify it

Run on the switch.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

As part of these changes: - Switch to dplane_fpm_nl zebra plugin from old fpm plugin which is not supported anymore - Remove stale patches for old fpm plugin and add similar patches for dplane_fpm_nl - FRR patch backport from 8.4 to add support for fpm dataplane feedback - Templates are updated to read new feature configuration and configure FRR accordingly - YANG models updates to reflect new configuration Signed-off-by: Stepan Blyschak <[email protected]>

Signed-off-by: Stepan Blyschak <[email protected]>

…pm-dplane-nl

Signed-off-by: Stepan Blyschak <[email protected]>

This reverts commit 735ab84.

Signed-off-by: Stepan Blyschak <[email protected]>

mssonicbld · 2023-03-28T15:26:45Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-03-28T15:27:01Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2023-03-28T20:37:20Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2023-03-28T20:37:22Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-03-28T20:37:35Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2023-04-03T15:59:09Z

FRR PR - FRRouting/frr#13086

prsunny · 2023-04-03T15:59:32Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2023-04-03T15:59:46Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS

@stepanblyschak could you add the testcase link or test plan for sonic-mgmt of this feature?

src/sonic-frr/patch/0016-zebra-Add-zrouter.asic_notification_nexthop_control.patch

src/sonic-bgpcfgd/bgpcfgd/managers_bgp.py

stepanblyschak · 2023-04-10T14:10:16Z

@StormLiangMS Test Plan sonic-net/sonic-mgmt#7475

stepanblyschak · 2023-04-13T16:26:47Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2023-04-13T16:26:50Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-04-13T16:27:04Z

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak · 2023-04-14T08:55:01Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2023-04-14T08:55:04Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-04-14T08:55:16Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 79a21ce. DEPENDS ON: sonic-net/sonic-buildimage#12853 What I did Reverted changes back How I did it Reverted changes back How to verify it UT

…eboot Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken, where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an effort to get the warm reboot PR checker re-enabled, disable checking the IPv6 BGP routing for now. Once that PR is either fixed or reverted, revert this PR. Signed-off-by: Saikrishna Arcot <[email protected]>

…eboot (#8735) * Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken, where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an effort to get the warm reboot PR checker re-enabled, disable checking the IPv6 BGP routing for now. Once that PR is either fixed or reverted, revert this PR. Signed-off-by: Saikrishna Arcot <[email protected]> * Add todo comment Signed-off-by: Saikrishna Arcot <[email protected]> --------- Signed-off-by: Saikrishna Arcot <[email protected]>

This reverts commit 79a21ce. DEPENDS ON: sonic-net/sonic-buildimage#12853 What I did Reverted changes back How I did it Reverted changes back How to verify it UT

…eboot (sonic-net#8735) * Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken, where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an effort to get the warm reboot PR checker re-enabled, disable checking the IPv6 BGP routing for now. Once that PR is either fixed or reverted, revert this PR. Signed-off-by: Saikrishna Arcot <[email protected]> * Add todo comment Signed-off-by: Saikrishna Arcot <[email protected]> --------- Signed-off-by: Saikrishna Arcot <[email protected]>

Why I did it BGP pending FIB suppression is introduced in #12853, hence updating the YANG model. Work item tracking Microsoft ADO (number only): 28398135 How I did it Added a new field 'suppress-fib-pending' in the DEVICE_METADATA YANG model table. Added UT for YANG model changes. How to verify it Run PR tests. Apply empty.json file to verify: admin@str2-7050cx3-acs-02:~$ sudo config apply-patch empty.json Patch Applier: Patch application starting. Patch Applier: Patch: [] Patch Applier: Getting current config db. Patch Applier: Simulating the target full config after applying the patch. Patch Applier: Validating all JsonPatch operations are permitted on the specified fields Patch Applier: Validating target config does not have empty tables, since they do not show up in ConfigDb. Patch Applier: Sorting patch updates. Patch Applier: The patch was converted into 0 changes. Patch Applier: Applying 0 changes in order. Patch Applier: Verifying patch updates are reflected on ConfigDB. Patch Applier: Patch application completed. Patch applied successfully. admin@str2-7050cx3-acs-02:~$ Signed-off-by: zitingguo-ms [email protected]

stepanblyschak and others added 21 commits October 20, 2022 13:33

Merge branch 'master' into bgp-suppress-fib-pending

112797f

organize patches

3079089

Signed-off-by: Stepan Blyschak <[email protected]>

remove redundant files

ad59c4f

Signed-off-by: Stepan Blyschak <[email protected]>

update patches

8b4db68

Signed-off-by: Stepan Blyschak <[email protected]>

remove yang

0880950

Signed-off-by: Stepan Blyschak <[email protected]>

fix

58026cc

Signed-off-by: Stepan Blyschak <[email protected]>

Merge branch 'master' of github.com:azure/sonic-buildimage into frr-f…

226c7ab

…pm-dplane-nl

fixups

0b88bd1

Signed-off-by: Stepan Blyschak <[email protected]>

update py2 templates

c99ca4a

Signed-off-by: Stepan Blyschak <[email protected]>

fix patch

3ceb01d

Signed-off-by: Stepan Blyschak <[email protected]>

backport fix from FRR

15671f0

Signed-off-by: Stepan Blyschak <[email protected]>

update template in tests

57e85e5

Signed-off-by: Stepan Blyschak <[email protected]>

[BGP] support BGP pending FIB suppression

d867a1d

Signed-off-by: Stepan Blyschak <[email protected]>

fix yang test

92f7e37

Signed-off-by: Stepan Blyschak <[email protected]>

fix config-engine tests

735ab84

Signed-off-by: Stepan Blyschak <[email protected]>

Revert "fix config-engine tests"

8a6b555

This reverts commit 735ab84.

fix tests

5c56180

Signed-off-by: Stepan Blyschak <[email protected]>

fix py2 tests

314be81

Signed-off-by: Stepan Blyschak <[email protected]>

fix bgpcfgd tests

711d48b

Signed-off-by: Stepan Blyschak <[email protected]>

change field name

9f2cc0f

Signed-off-by: Stepan Blyschak <[email protected]>

stepanblyschak requested review from StormLiangMS, lguohan and qiluo-msft as code owners November 28, 2022 13:03

stepanblyschak marked this pull request as draft November 28, 2022 13:03

stepanblyschak mentioned this pull request Nov 28, 2022

FIB Suppress Announcements of Routes Not Installed in HW sonic-net/SONiC#1103

Merged

stepanblyschak added 4 commits December 6, 2022 14:48

use dplane_fpm_nl in vs as well

0328b2e

Signed-off-by: Stepan Blyschak <[email protected]>

Merge branch 'frr-fpm-dplane-nl' into bgp-suppress-fib

ed884b5

use asic-offload option for vs

ed5a97f

Signed-off-by: Stepan Blyschak <[email protected]>

configure zebra for VS

4cbb06b

Signed-off-by: Stepan Blyschak <[email protected]>

stepanblyschak marked this pull request as ready for review April 3, 2023 07:52

StormLiangMS requested a review from jcaiMR April 8, 2023 13:20

StormLiangMS reviewed Apr 8, 2023

View reviewed changes

src/sonic-frr/patch/0016-zebra-Add-zrouter.asic_notification_nexthop_control.patch Show resolved Hide resolved

src/sonic-bgpcfgd/bgpcfgd/managers_bgp.py Show resolved Hide resolved

StormLiangMS approved these changes Apr 20, 2023

View reviewed changes

StormLiangMS merged commit 04099f0 into sonic-net:master Apr 20, 2023

saiarcot895 mentioned this pull request Jun 27, 2023

Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot sonic-net/sonic-mgmt#8735

Merged

6 tasks

Gfrom2016 mentioned this pull request Jun 18, 2024

[YANG] Update device_metadata to add suppress-fib-pending field #19329

Merged

11 tasks

Conversation

stepanblyschak commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented Mar 28, 2023

Uh oh!

azure-pipelines bot commented Mar 28, 2023

Uh oh!

stepanblyschak commented Mar 28, 2023

Uh oh!

mssonicbld commented Mar 28, 2023

Uh oh!

azure-pipelines bot commented Mar 28, 2023

Uh oh!

prsunny commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prsunny commented Apr 3, 2023

Uh oh!

azure-pipelines bot commented Apr 3, 2023

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stepanblyschak commented Apr 10, 2023

Uh oh!

stepanblyschak commented Apr 13, 2023

Uh oh!

mssonicbld commented Apr 13, 2023

Uh oh!

azure-pipelines bot commented Apr 13, 2023

Uh oh!

stepanblyschak commented Apr 14, 2023

Uh oh!

mssonicbld commented Apr 14, 2023

Uh oh!

azure-pipelines bot commented Apr 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stepanblyschak commented Nov 28, 2022 •

edited

Loading

prsunny commented Apr 3, 2023 •

edited

Loading