[FRR] Switch to dplane_fpm_nl plugin instead of fpm#12852
Merged
lguohan merged 19 commits intosonic-net:masterfrom Feb 6, 2023
Merged
[FRR] Switch to dplane_fpm_nl plugin instead of fpm#12852lguohan merged 19 commits intosonic-net:masterfrom
lguohan merged 19 commits intosonic-net:masterfrom
Conversation
As part of these changes: - Switch to dplane_fpm_nl zebra plugin from old fpm plugin which is not supported anymore - Remove stale patches for old fpm plugin and add similar patches for dplane_fpm_nl - FRR patch backport from 8.4 to add support for fpm dataplane feedback - Templates are updated to read new feature configuration and configure FRR accordingly - YANG models updates to reflect new configuration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
requested review from
StormLiangMS and
lguohan
as code owners
This was referenced Nov 28, 2022
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
why build failed? |
bluecmd
pushed a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Dec 24, 2024
…net#21053) During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Dec 24, 2024
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Dec 24, 2024
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
bluecmd
pushed a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Dec 28, 2024
…net#21053) During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
dplane_fpm_nlis a new FPM implementation in FRR. The old pluginfpmwill not have any new features implemented. Usage of the new plugin gives us ability to use BGP suppression feature and next hop groups in the future.How I did it
How to verify it
Build and run on the switch.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)