Skip to content

Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot#8735

Merged
saiarcot895 merged 2 commits intosonic-net:masterfrom
saiarcot895:disable-ipv6-check
Jun 28, 2023
Merged

Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot#8735
saiarcot895 merged 2 commits intosonic-net:masterfrom
saiarcot895:disable-ipv6-check

Conversation

@saiarcot895
Copy link
Contributor

Description of PR

Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken, where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an effort to get the warm reboot PR checker re-enabled, disable checking the IPv6 BGP routing for now.

Once that PR is either fixed or reverted, revert this PR.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…eboot

Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken,
where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an
effort to get the warm reboot PR checker re-enabled, disable checking
the IPv6 BGP routing for now.

Once that PR is either fixed or reverted, revert this PR.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
kellyyeh
kellyyeh previously approved these changes Jun 27, 2023
vaibhavhd
vaibhavhd previously approved these changes Jun 27, 2023
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@saiarcot895 saiarcot895 dismissed stale reviews from vaibhavhd and kellyyeh via ecc72ad June 27, 2023 22:06
@yxieca yxieca requested a review from StormLiangMS June 27, 2023 23:14
@saiarcot895 saiarcot895 merged commit ff4bbf3 into sonic-net:master Jun 28, 2023
@saiarcot895 saiarcot895 deleted the disable-ipv6-check branch June 28, 2023 17:10
saiarcot895 added a commit to saiarcot895/sonic-mgmt that referenced this pull request Jul 12, 2023
saiarcot895 added a commit that referenced this pull request Jul 14, 2023
* Revert "Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot (#8735)"

This reverts commit ff4bbf3.

* Revert "Remove the bgp_v6 check, which adds failure since the IPv6 BGP doesn't come up (#8746)"

This reverts commit 5db3a06.
mrkcmo pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 3, 2023
…eboot (sonic-net#8735)

* Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot

Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken,
where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an
effort to get the warm reboot PR checker re-enabled, disable checking
the IPv6 BGP routing for now.

Once that PR is either fixed or reverted, revert this PR.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Add todo comment

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
…eboot (sonic-net#8735)

* Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot

Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken,
where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an
effort to get the warm reboot PR checker re-enabled, disable checking
the IPv6 BGP routing for now.

Once that PR is either fixed or reverted, revert this PR.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Add todo comment

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
* Revert "Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot (sonic-net#8735)"

This reverts commit ff4bbf3.

* Revert "Remove the bgp_v6 check, which adds failure since the IPv6 BGP doesn't come up (sonic-net#8746)"

This reverts commit 5db3a06.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants