Skip to content

Configurable drop counters HLD#434

Merged
lguohan merged 25 commits intosonic-net:masterfrom
daall:drop_counters
Oct 9, 2019
Merged

Configurable drop counters HLD#434
lguohan merged 25 commits intosonic-net:masterfrom
daall:drop_counters

Conversation

@daall
Copy link
Copy Markdown
Contributor

@daall daall commented Jul 30, 2019

This document describes the high level design details for configurable packet drop counters in SONiC.

Signed-off-by: Danny Allen [email protected]

@daall daall requested review from lguohan, prsunny, wendani and yxieca July 30, 2019 21:15
@yxieca yxieca requested a review from kcudnik July 30, 2019 21:37
@yxieca
Copy link
Copy Markdown
Contributor

yxieca commented Jul 30, 2019

It might make sense to specifically separate SAI requirement v.s. SONiC requirement. Though most of the requirements are SONiC requirements.

@daall daall requested a review from prsunny July 31, 2019 19:50
"SWITCH_INGRESS_DROPS": {
"total": 3,
"used": 1,
"reasons": [L2_ANY, L3_ANY, SMAC_EQUALS_DMAC]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the scope of L2_ANY drop reason? is this specific hardware platform? what are the SONiC platforms supported this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L2_ANY refers to any drop reason coming from layer 2, so for example if a frame has the same source mac and destination mac, if a frame is larger than the MTU, etc. Any packet dropped due to problems at layer 2 will be counted under L2_ANY.

L2_ANY is defined in the SAI so in theory it should not be platform specific. That being said, I don't think any of the platforms support this drop reason yet except for maybe Mellanox (let me get back to you on that!)

@daall daall deleted the drop_counters branch November 20, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants