Add CLI support for configurable drop counters#688
Conversation
|
I got some feedback on the behavior of the scripts that I wanted to note here:
|
scripts/dropconfig
Outdated
There was a problem hiding this comment.
Do user need to reset the drop counter explicitly when drop_reasons are added/removed?
There was a problem hiding this comment.
Good catch! I don't believe the counter gets cleared when drop reasons are added and removed from the counter but I need to verify.
There was a problem hiding this comment.
They don't appear to be automatically cleared when drop reasons are added/removed. Do you have any concerns with this approach?
There was a problem hiding this comment.
The counters are cleared when drop reasons are added and removed.
|
can you follow example here to add unit test for your show command. https://github.com/Azure/sonic-utilities/tree/master/sonic-utilities-tests |
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
need unit test for show commands
added! |
- Adds dropconfig script to configure drop counters - Adds dropstat script to show and clear drop counters - Adds handlers for drop counters to show, config, and sonic-clear Signed-off-by: Danny Allen <[email protected]>
daall
force-pushed
the
drop_counter_cli
branch
from
d54e96f to
3597154
Compare
|
retest this please |
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Looks good to me. Please check other review comments.
In future, please minimize force-push, because we are using internal tool to compare between iterations, and force push will lose comment context.
Will do, thanks for the heads up! And thanks for the review! :) |
6 participants
Add CLI support for configurable drop counters
New command output (if the output of a command-line utility has changed)
Details if related
Depends on:
Signed-off-by: Danny Allen [email protected]