[orchagent] Adds swss support for drop counters#1075
Merged
yxieca merged 30 commits intosonic-net:masterfrom Nov 19, 2019
Merged
[orchagent] Adds swss support for drop counters#1075yxieca merged 30 commits intosonic-net:masterfrom
yxieca merged 30 commits intosonic-net:masterfrom
Conversation
daall
force-pushed
the
drop_counters
branch
2 times, most recently
from
7ba0a4d to
7cbe631
Compare
This was referenced Oct 12, 2019
dev-aviz
reviewed
Oct 22, 2019
| this->counter_id = debug_counter_id; | ||
| } | ||
|
|
||
| void DebugCounter::removeDebugCounterFromSAI() |
There was a problem hiding this comment.
How do handle warm reboot case?
Can the SWSS reset the counters? or reconcile the debug counters?
Contributor
Author
There was a problem hiding this comment.
I'll have to verify but yes, the counters should be reconciled upon warm reboot.
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
reviewed
Oct 29, 2019
qiluo-msft
requested changes
Oct 29, 2019
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Please also resolve conflicts and fix vs tests.
- Creates a new orchestrator for managing debug counters - Adds utility functions for managing flex counters - Adds utility functions for managing debug counters Signed-off-by: Danny Allen <[email protected]>
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
yxieca
reviewed
Nov 15, 2019
Contributor
|
My comments are mostly cosmetic issues. Overall the change looks pretty good. Thanks for adding these comments in source code to tell tricky choices. These comments helps a lot. Add some comments to state the purpose of test steps would also help readers. I found that you used quite a bit 'this->' to specify scope in your code. This is not wrong per-se. Just curious why are you doing compiler's job? :-) |
qiluo-msft
reviewed
Nov 16, 2019
qiluo-msft
approved these changes
Nov 18, 2019
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Looks good to me. Please also check others' comments
Contributor
Author
|
retest this please |
Contributor
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Aligned single back quotes in .md file
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…t#1075) SAI_OBJECT_TYPE_TUNNEL has fewer attributes in 201811 than in 202012. These new attributes are CREATE only, and can't be added using just SET oper. Hence old object needs to be removed, and new object needs to be added. Moreover existing sequence (make before break) causes SAI errors in removing VXLAN tunnel (as part of CPA teardown). Adding SAI_OBJECT_TYPE_TUNNEL to break before make to avoid creating a new object before removing existing ones.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* [orchagent] Adds swss support for drop counters - Creates a new orchestrator for managing debug counters - Adds utility functions for managing flex counters - Adds utility functions for managing debug counters Signed-off-by: Danny Allen <[email protected]> * Fix build issues * Fix log levels * Cast drop reasons before serializing * Fix testing issues * Clean up flex counter utilities * Expose switch ids in redis * Clean-up comments and namespace usage * Add basic drop counter vswitch tests * Add drop reasons * Fix rebase merge conflicts * Move flex counter and switch related work to different PRs * Fix first round of feedback comments * Fix free counters review comments * Reorganize helper classes * Delete extra makefile * Only put useful capabilities in STATE DB * Use new flex counter manager naming * Update mock tests to build with debug counter orch * Add remaining ingress drop reasons * Fix reference style issue * Update tests to match virtual switch implementation * Respond to C++ style issues * Improve documentation for vs tests * Add test case for removing all drop reasons from a counter * Specify exception type being caught * Add range check for drop counter indices * Undo range check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds swss support for drop counters
How I verified it
A set of vswitch tests is included.
Details if related
Depends on:
[flex_counter] Add sairedis support for drop counters sonic-sairedis#520[utilities] Create utility classes for interacting with flex counters #1093Signed-off-by: Danny Allen [email protected]